Skip to content

[Due for payment 2025-11-07] [$250] LHN - Workspace chat disappears when owner change admin role to member #72356

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.29-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #71910
Email or phone of affected tester (no customers): gocemate+b2154495@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. As Owner User A invite User B to workspace as Admin
  2. Verify admin room and workspace chat appears on User B side
  3. User A change the role of User B to member

Expected Result:

Workspace chat should remain on LHN on member's side

Actual Result:

Workspace chat disappears from LHN

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6970907_1760108822705.Recording__6205.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021977819658616372515
  • Upwork Job ID: 1977819658616372515
  • Last Price Increase: 2025-10-20
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2025
  2. melvin-bot commented on Oct 10, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. paulnjs commented on Oct 11, 2025

    @paulnjs
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace chat disappears from the LHN

    What is the root cause of that problem?

    When a user's role is changed from admin to member, the backend sometimes incorrectly clears the notification data in the participants list for the policy expense chat.

    In the frontend, we currently treat any notification value that is null, undefined, or an empty string as hidden. As a result, the policy expense chat is excluded from the LHN:

    if (isHidden && !shouldOverrideHidden) {
    return {shouldDisplay: false};
    }

    What changes do you think we should make in order to solve the problem?

    If the user is the owner of the policy expense chat, we should override the hidden state and ensure the chat remains visible. This can be done by appending the condition || report.isOwnPolicyExpenseChat to the logic at:

    const shouldOverrideHidden =

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    N/A

  4. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    @clarajones-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. changed the title [-]LHN - Workspace chat disappears when owner change admin role to member[/-] [+][$250] LHN - Workspace chat disappears when owner change admin role to member[/+] on Oct 13, 2025
  6. melvin-bot commented on Oct 13, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 13, 2025
  8. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

  9. melvin-bot commented on Oct 17, 2025

    @melvin-bot

    @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. 25 remaining items

  11. melvin-bot commented on Nov 7, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  12. mallenexpensify commented on Nov 8, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @paulnjs paid $250 via Upwork
    Contributor+: @brunovjk due $250 via NewDot

    @brunovjk plz complete the BZ checklist.

    @paulnjs can you please apply to the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021977819658616372515

  13. mallenexpensify commented on Nov 8, 2025

    @mallenexpensify
    Contributor

    Issue is ready for payment but no BZ is assigned.

    Strange.. @clarajones-expensify is assigned. ¯_(ツ)_/¯

  14. paulnjs commented on Nov 9, 2025

    @paulnjs
    Contributor

    @mallenexpensify I applied to the job. Thank you!

  15. mallenexpensify commented on Nov 10, 2025

    @mallenexpensify
    Contributor

    @paulnjs can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021977819658616372515

  16. paulnjs commented on Nov 11, 2025

    @paulnjs
    Contributor

    @mallenexpensify I accepted it. Thanks!

  17. mallenexpensify commented on Nov 11, 2025

    @mallenexpensify
    Contributor

    @paulnjs paid, summary updated above.

    @brunovjk plz complete the BZ checklist.

  18. brunovjk commented on Nov 12, 2025

    @brunovjk
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No PR directly introduced this bug.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. As Owner User A invite User B to workspace as Admin
    2. Verify admin room and workspace chat appears on User B side
    3. User A change the role of User B to member
    4. Workspace chat should remain on LHN on member's side

    Do we agree 👍 or 👎

  19. brunovjk commented on Nov 12, 2025

    @brunovjk
    Contributor

    Requested in ND, thank you.

  20. clarajones-expensify commented on Nov 12, 2025

    @clarajones-expensify
    Contributor

    @mallenexpensify whoop it said no BZ is assigned bc I am temporarily off the BZ team to focus on a pilot program for 2 weeks so that I don't get assigned any new BZ issues. But one of the effects is that it will say no BZ is assigned on my already assigned issues

  21. JmillsExpensify commented on Nov 13, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @brunovjk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions