You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-07] [$250] LHN - Workspace chat disappears when owner change admin role to member #72356
Version Number: 9.2.29-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:#71910 Email or phone of affected tester (no customers):gocemate+b2154495@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
As Owner User A invite User B to workspace as Admin
Verify admin room and workspace chat appears on User B side
User A change the role of User B to member
Expected Result:
Workspace chat should remain on LHN on member's side
Actual Result:
Workspace chat disappears from LHN
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6970907_1760108822705.Recording__6205.mp4
Please re-state the problem that we are trying to solve in this issue.
Workspace chat disappears from the LHN
What is the root cause of that problem?
When a user's role is changed from admin to member, the backend sometimes incorrectly clears the notification data in the participants list for the policy expense chat.
In the frontend, we currently treat any notification value that is null, undefined, or an empty string as hidden. As a result, the policy expense chat is excluded from the LHN:
What changes do you think we should make in order to solve the problem?
If the user is the owner of the policy expense chat, we should override the hidden state and ensure the chat remains visible. This can be done by appending the condition || report.isOwnPolicyExpenseChat to the logic at:
changed the title [-]LHN - Workspace chat disappears when owner change admin role to member[/-][+][$250] LHN - Workspace chat disappears when owner change admin role to member[/+]on Oct 13, 2025
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No PR directly introduced this bug.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
As Owner User A invite User B to workspace as Admin
Verify admin room and workspace chat appears on User B side
User A change the role of User B to member
Workspace chat should remain on LHN on member's side
@mallenexpensify whoop it said no BZ is assigned bc I am temporarily off the BZ team to focus on a pilot program for 2 weeks so that I don't get assigned any new BZ issues. But one of the effects is that it will say no BZ is assigned on my already assigned issues
Activity
melvin-bot commentedon Oct 10, 2025
Triggered auto assignment to @clarajones-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.paulnjs commentedon Oct 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace chat disappears from the LHN
What is the root cause of that problem?
When a user's role is changed from admin to member, the backend sometimes incorrectly clears the
notificationdata in the participants list for the policy expense chat.In the frontend, we currently treat any
notificationvalue that isnull,undefined, or an empty string as hidden. As a result, the policy expense chat is excluded from the LHN:App/src/libs/SidebarUtils.ts
Lines 199 to 201 in 35e6f75
What changes do you think we should make in order to solve the problem?
If the user is the owner of the policy expense chat, we should override the hidden state and ensure the chat remains visible. This can be done by appending the condition
|| report.isOwnPolicyExpenseChatto the logic at:App/src/libs/SidebarUtils.ts
Line 196 in 35e6f75
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Oct 13, 2025
@clarajones-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]LHN - Workspace chat disappears when owner change admin role to member[/-][+][$250] LHN - Workspace chat disappears when owner change admin role to member[/+]melvin-bot commentedon Oct 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021977819658616372515
melvin-bot commentedon Oct 13, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (
External)melvin-bot commentedon Oct 17, 2025
@brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!
25 remaining items
melvin-bot commentedon Nov 7, 2025
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
mallenexpensify commentedon Nov 8, 2025
Payment Summary
Contributor: @paulnjs paid $250 via Upwork
Contributor+: @brunovjk due $250 via NewDot
@brunovjk plz complete the BZ checklist.
@paulnjs can you please apply to the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~021977819658616372515
mallenexpensify commentedon Nov 8, 2025
Strange.. @clarajones-expensify is assigned. ¯_(ツ)_/¯
paulnjs commentedon Nov 9, 2025
@mallenexpensify I applied to the job. Thank you!
mallenexpensify commentedon Nov 10, 2025
@paulnjs can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~021977819658616372515
paulnjs commentedon Nov 11, 2025
@mallenexpensify I accepted it. Thanks!
mallenexpensify commentedon Nov 11, 2025
@paulnjs paid, summary updated above.
@brunovjk plz complete the BZ checklist.
brunovjk commentedon Nov 12, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No PR directly introduced this bug.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
brunovjk commentedon Nov 12, 2025
Requested in ND, thank you.
clarajones-expensify commentedon Nov 12, 2025
@mallenexpensify whoop it said no BZ is assigned bc I am temporarily off the BZ team to focus on a pilot program for 2 weeks so that I don't get assigned any new BZ issues. But one of the effects is that it will say no BZ is assigned on my already assigned issues
JmillsExpensify commentedon Nov 13, 2025
$250 approved for @brunovjk