Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.29-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1235/folder/13177049/41237817/945415338
Email or phone of affected tester (no customers): applausetester+101001kh@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
- User A default currency is USD
- User B has a workspace
- Go to staging.new.expensify.com
- [User A] Submit an IOU expense to User B
- [User B] Open the IOU report
- [User B] Go offline
- {User B] Click Pay > Pay via workspace
- [User B] Close the RHP
Expected Result:
Report view will not turn to skeleton loader
Actual Result:
Report view turns to skeleton loader after paying IOU expense via workspace offline
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6972348_1760215823398.offline.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021978695300058866413
- Upwork Job ID: 1978695300058866413
- Last Price Increase: 2025-10-23
Activity
melvin-bot commentedon Oct 12, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mukhrr commentedon Oct 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When User B pays an IOU expense via workspace while offline and then closes the payment RHP, the report view incorrectly displays a skeleton loader instead of showing the optimistic payment data
What is the root cause of that problem?
We are missing offline check in the skeleton loader condition at
MoneyRequestReportView.tsx:App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx
Lines 182 to 202 in f05f7b7
What changes do you think we should make in order to solve the problem?
We should check again
isOfflinetoo.We already do the same in codebase
App/src/pages/home/report/ReportActionsView.tsx
Lines 297 to 302 in f05f7b7
App/src/pages/workspace/WorkspacesListPage.tsx
Line 116 in f05f7b7
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Tony-MK commentedon Oct 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report view turns to skeleton loader after paying IOU expense via workspace offline
What is the root cause of that problem?
In
MoneyRequestReportView, the app shows the skeleton view instead of theMoneyRequestReportActionsListbecause it is loading, and the condition is met.App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx
Lines 186 to 187 in d41575d
What changes do you think we should make in order to solve the problem?
We should change the condition to check if the report's pending action is not available.
Screen.Recording.2025-10-12.at.22.11.09.mov
paulnjs commentedon Oct 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/components/KYCWall/BaseKYCWall.tsx
Lines 124 to 127 in f05f7b7
App/src/libs/actions/Report.ts
Line 5389 in f05f7b7
App/src/libs/actions/Report.ts
Line 5439 in f05f7b7
App/src/components/KYCWall/BaseKYCWall.tsx
Line 126 in f05f7b7
{reportName: Chat Report}:App/src/libs/actions/Report.ts
Line 1056 in f05f7b7
What changes do you think we should make in order to solve the problem?
setNavigationActionToMicrotaskQueueutility, which waits until the next microtask before executing the navigation. Example:App/src/components/KYCWall/BaseKYCWall.tsx
Lines 125 to 139 in f05f7b7
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
None
[-]Expense - Report view turns to skeleton loader after paying IOU expense via workspace offline[/-][+][$250] Expense - Report view turns to skeleton loader after paying IOU expense via workspace offline[/+]melvin-bot commentedon Oct 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021978695300058866413
melvin-bot commentedon Oct 16, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)25 remaining items
melvin-bot commentedon Nov 10, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.stephanieelliott commentedon Nov 10, 2025
Adding the
Buglabel to reassign this as I am going on leave til Dec 1.Status: this just needs to be paid on 11/12! Also:
trjExpensify commentedon Nov 12, 2025
👋 Checklist time, @ishpaul777.
melvin-bot commentedon Nov 12, 2025
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Nov 17, 2025
Bump on the checklist, @ishpaul777.
ishpaul777 commentedon Nov 18, 2025
sorry missed it! will fill out soon today
ishpaul777 commentedon Nov 19, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/66790/files#r2541856531
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No need
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Precondition:
Test:
Do we agree 👍 or 👎
trjExpensify commentedon Nov 19, 2025
Thanks!
Payment summary as follows:
@paulnjs please send me your Upwork profile.
paulnjs commentedon Nov 20, 2025
@trjExpensify My profile: https://www.upwork.com/freelancers/~01b14cc7311ec91efa
trjExpensify commentedon Nov 21, 2025
Thanks, offer sent.
paulnjs commentedon Nov 22, 2025
@trjExpensify I accepted the offer. Thank you!
trjExpensify commentedon Nov 24, 2025
Paid, closing!