Skip to content

[Due for payment 2025-10-31] Desktop - No STG label on application's icon #72418

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.29-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #70984
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open Desktop application
  2. Notice STG label on splash screen

Expected Result:

STG label is on splash screen and on application's icon

Actual Result:

STG label is on splash screen, but no on application's icon

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6972941_1760289184949.Screen_Recording_2025-10-12_at_20.07.12.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 12, 2025
  2. melvin-bot commented on Oct 12, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Oct 12, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    STG label is on splash screen, but no on application's icon

    What is the root cause of that problem?

    We don't get the cover the app icon in staging

    const getMacBundleIconName = () => {
    if (process.env.ELECTRON_ENV === 'adhoc') {
    return 'AppIcon-adhoc';
    }
    if (process.env.ELECTRON_ENV === 'development') {
    return 'AppIcon-dev';
    }
    return 'AppIcon';
    };

    const getAssetSourceFilename = () => {
    if (process.env.ELECTRON_ENV === 'adhoc') {
    return 'Assets-adhoc.car';
    }
    if (process.env.ELECTRON_ENV === 'development') {
    return 'Assets-dev.car';
    }
    return 'Assets.car';
    };

    What changes do you think we should make in order to solve the problem?

    const getMacBundleIconName = () => {
        if (process.env.ELECTRON_ENV === 'adhoc') {
            return 'AppIcon-adhoc';
        }
    
        if(process.env.ELECTRON_ENV === 'staging') {
            return 'AppIcon-stg';
        }
    
        if (process.env.ELECTRON_ENV === 'development') {
            return 'AppIcon-dev';
        }
    
        return 'AppIcon';
    };
    

    then update getAssetSourceFilename function and we need to create a new file Assets-stg.car

    const getAssetSourceFilename = () => {
        if (process.env.ELECTRON_ENV === 'adhoc') {
            return 'Assets-adhoc.car';
        }
    
        if (process.env.ELECTRON_ENV === 'development') {
            return 'Assets-dev.car';
        }
    
        if (process.env.ELECTRON_ENV === 'staging') {
            return 'Assets-stg.car';
        }
    
        return 'Assets.car';
    };
    

    We can do the same with other env

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. mjasikowski commented on Oct 13, 2025

    @mjasikowski
    Contributor

    It seems that I've missed that one - I've asked Jon to provide an icon for staging and then I'll implement it ASAP once we get it.

  5. daledah commented on Oct 15, 2025

    @daledah
    Contributor

    @mjasikowski is this issue open for the contributor?

  6. mjasikowski commented on Oct 15, 2025

    @mjasikowski
    Contributor

    @daledah not at the moment, I'll be handling this one along with the other icon issues tomorrow

  7. mjasikowski commented on Oct 16, 2025

    @mjasikowski
    Contributor

    Will be fixed by #72781

  8. mjasikowski commented on Oct 20, 2025

    @mjasikowski
    Contributor

    Still working on it, should be fixed today

  9. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 20, 2025
  10. changed the title [-]Desktop - No STG label on application's icon[/-] [+][Due for payment 2025-10-31] Desktop - No STG label on application's icon[/+] on Oct 24, 2025
  11. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.37-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-31. 🎊

  13. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    @mjasikowski @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. mjasikowski commented on Oct 28, 2025

    @mjasikowski
    Contributor

    No payment or BZ checklists needed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions