Skip to content

[Due for payment 2026-07-08] [$250] Show Submit/Approve/Pay options when all expenses within a report are selected #72502

Closed

Description

@puneetlath

When you are viewing an expense report, there is a primary action at the top (e.g. Submit, Approve, Pay). That action will apply to the whole expense report, including all the expenses that are a part of it.

Image

However, if you select all the expenses on the report, you don't have the option to Submit/Approve/Pay.

Image

We are planning to add the ability to do partial report actions via this select expenses dialog in the future. But that will also require backend changes, since we'll need to move the expenses that weren't included in the action to a separate report.

For now, when all expenses on a report are selected, let's so show the primary action for the whole report as an option here as well. Since they are selecting all the expenses, we can simply use the same API command that is used for the full report, without needing any backend changes.

cc @garrettmknight

Slack convo: https://expensify.slack.com/archives/C07NMDKEFMH/p1759425792934389

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021980654523890058082
  • Upwork Job ID: 1980654523890058082
  • Last Price Increase: 2025-10-21
  • Automatic offers:
    • situchan | Contributor | 109266586
Issue OwnerCurrent Issue Owner: @

EXFY-19660

Issue OwnerCurrent Issue Owner: @puneetlath

Activity

  1. self-assigned this
    on Oct 13, 2025
  2. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO. Remember to draft any necessary HelpDot updates by following the instructions here.

  3. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  5. dylanexpensify commented on Oct 21, 2025

    @dylanexpensify
    Contributor

    @puneetlath will get this put out for contributors once @dubielzyk-expensify can confirm mocks (which I imagine will take two secs)

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 21, 2025
  7. changed the title [-]Show Submit/Approve/Pay options when all expenses within a report are selected[/-] [+][$250] Show Submit/Approve/Pay options when all expenses within a report are selected[/+] on Oct 21, 2025
  8. melvin-bot commented on Oct 21, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 21, 2025
  10. 202 remaining items

  11. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    @mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  12. mallenexpensify commented on Jul 9, 2026

    @mallenexpensify
    Contributor

    @situchan from the C+ doc

    If there are posts on the PR or issue that reference a regression or deploy blocker, C+ posts on the issue and confirms regression (which will reduce pay by 50%) or provides reasoning why they shouldn’t be considered. If the C+ doesn’t update the issue, the contributor manager making the payment will assume any mention of a regression or deploy blockers reduces the issue amount.

  13. situchan commented on Jul 9, 2026

    @situchan
    Contributor

    I'll provide summary shortly

  14. situchan commented on Jul 9, 2026

    @situchan
    Contributor

    Summary:

    1. refactor - function positional params to object params
    1. implement web version
    1. implement mobile version
    1. bug fix happening on production
    1. refactor - extract common logic from MoneyReportHeaderSelectionDropdown, useLifecycleActions, useSelectionModeReportActions* PR: refactor: extract common selection mode logic into shared hooks #92518
    • Suggested price: $250
    • no deploy blockers

    Total: $1375

    This issue ended up involving complex logic (especially for mobile).
    @Krishna2323 and me are aligned with values but we're happy whatever team decides.
    cc: @puneetlath

  15. Krishna2323 commented on Jul 9, 2026

    @Krishna2323
    Contributor

    I consider this a follow-up rather than a regression, since it was a flaky bug caused by stale transaction data from the module-level Onyx connection.

  16. mallenexpensify commented on Jul 9, 2026

    @mallenexpensify
    Contributor

    @puneetlath 👀 above to confirm amount owed. thx

  17. puneetlath commented on Jul 9, 2026

    @puneetlath
    ContributorAuthor

    I would suggest the standard $250 per PR. Some were bigger, some smaller, but it generally evens out. But I'm also fine with what is proposed.

  18. mallenexpensify commented on Jul 9, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @Krishna2323 due $1375 via NewDot
    Contributor+: @situchan due $1375 via NewDot

    @situchan plz complete the BZ checklist and tag me in a post once you have. Thx

  19. situchan commented on Jul 9, 2026

    @situchan
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/659081

    Regression Test Proposal

    Test:

    Submit action via selection mode

    1. Open an expense report with multiple expenses where the primary action is "Submit"
    2. Select all expenses using the checkboxes
    3. Verify the "X selected" dropdown appears
    4. Open the dropdown — verify "Submit" appears at the top
    5. Click "Submit"
    6. Verify the report is submitted, selections are cleared, and no submit animation plays

    Approve action via selection mode

    1. Open a submitted expense report as an approver
    2. Select all expenses
    3. Open the "X selected" dropdown — verify "Approve" appears at the top
    4. Click "Approve"
    5. Verify the report is approved, selections are cleared, and no approve animation plays

    Pay action via selection mode

    1. Open an approved expense report ready to be paid
    2. Select all expenses
    3. Open the "X selected" dropdown — verify "Pay $X.XX" appears at the top with a right arrow
    4. Click "Pay $X.XX" — verify a submenu opens with payment methods
    5. Select "Pay elsewhere"
    6. Verify payment processes, selections are cleared, no paid animation plays, and "You're all set!" RHP does not open
    7. Verify Pay is no longer shown in the dropdown

    Approve with delegate restriction (bug fix verification)

    1. Log in as a delegate with restricted access
    2. Open a submitted expense report
    3. Select all expenses
    4. Open the "X selected" dropdown and click "Approve"
    5. Verify the "no access" modal appears
    6. Dismiss the modal
    7. Verify selections are still active (not cleared)

    Approve with held expenses

    1. Open a submitted expense report where some expenses are on hold
    2. Select all expenses
    3. Open the "X selected" dropdown and click "Approve"
    4. Verify the hold menu appears
    5. Verify selections are cleared

    Pay as business

    1. Open an approved expense report, select all expenses
    2. Open Pay submenu, select "Pay as business" (if available)
    3. Verify payment processes without the "You're all set!" RHP opening
    4. Verify selections are cleared

    Pay with delegate restriction

    1. Log in as a delegate with restricted access
    2. Open an approved expense report, select all expenses
    3. Open Pay submenu, select a payment method
    4. Verify the "no access" modal appears
    5. Verify selections are not cleared

    Partial selection (no report-level actions)

    1. Open an expense report with 3+ expenses
    2. Select only some (not all) expenses
    3. Open the "X selected" dropdown
    4. Verify Submit/Approve/Pay do not appear — only transaction-level actions

    Do we agree 👍 or 👎

    cc: @mallenexpensify

    Zapier Logs Run ID: 00040eee-228e-aea6-a5e0-9d7aa18ef584
  20. laurenreidexpensify commented on Jul 20, 2026

    @laurenreidexpensify
    Contributor

    $1375 approved for @situchan

  21. laurenreidexpensify commented on Jul 24, 2026

    @laurenreidexpensify
    Contributor

    $1375 approved for @Krishna2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions