You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-08] [$250] Show Submit/Approve/Pay options when all expenses within a report are selected #72502
When you are viewing an expense report, there is a primary action at the top (e.g. Submit, Approve, Pay). That action will apply to the whole expense report, including all the expenses that are a part of it.
However, if you select all the expenses on the report, you don't have the option to Submit/Approve/Pay.
We are planning to add the ability to do partial report actions via this select expenses dialog in the future. But that will also require backend changes, since we'll need to move the expenses that weren't included in the action to a separate report.
For now, when all expenses on a report are selected, let's so show the primary action for the whole report as an option here as well. Since they are selecting all the expenses, we can simply use the same API command that is used for the full report, without needing any backend changes.
⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️
changed the title [-]Show Submit/Approve/Pay options when all expenses within a report are selected[/-][+][$250] Show Submit/Approve/Pay options when all expenses within a report are selected[/+]on Oct 21, 2025
If there are posts on the PR or issue that reference a regression or deploy blocker, C+ posts on the issue and confirms regression (which will reduce pay by 50%) or provides reasoning why they shouldn’t be considered. If the C+ doesn’t update the issue, the contributor manager making the payment will assume any mention of a regression or deploy blockers reduces the issue amount.
This issue ended up involving complex logic (especially for mobile). @Krishna2323 and me are aligned with values but we're happy whatever team decides.
cc: @puneetlath
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Oct 13, 2025
Triggered auto assignment to @dylanexpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO. Remember to draft any necessary HelpDot updates by following the instructions here.melvin-bot commentedon Oct 13, 2025
melvin-bot commentedon Oct 13, 2025
Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (
NewFeature)dylanexpensify commentedon Oct 21, 2025
@puneetlath will get this put out for contributors once @dubielzyk-expensify can confirm mocks (which I imagine will take two secs)
[-]Show Submit/Approve/Pay options when all expenses within a report are selected[/-][+][$250] Show Submit/Approve/Pay options when all expenses within a report are selected[/+]melvin-bot commentedon Oct 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021980654523890058082
202 remaining items
melvin-bot commentedon Jul 9, 2026
@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mallenexpensify commentedon Jul 9, 2026
@situchan from the C+ doc
situchan commentedon Jul 9, 2026
I'll provide summary shortly
situchan commentedon Jul 9, 2026
Summary:
Total: $1375
This issue ended up involving complex logic (especially for mobile).
@Krishna2323 and me are aligned with values but we're happy whatever team decides.
cc: @puneetlath
Krishna2323 commentedon Jul 9, 2026
I consider this a follow-up rather than a regression, since it was a flaky bug caused by stale transaction data from the module-level Onyx connection.
mallenexpensify commentedon Jul 9, 2026
@puneetlath 👀 above to confirm amount owed. thx
puneetlath commentedon Jul 9, 2026
I would suggest the standard $250 per PR. Some were bigger, some smaller, but it generally evens out. But I'm also fine with what is proposed.
mallenexpensify commentedon Jul 9, 2026
Payment Summary
Contributor: @Krishna2323 due $1375 via NewDot
Contributor+: @situchan due $1375 via NewDot
@situchan plz complete the BZ checklist and tag me in a post once you have. Thx
situchan commentedon Jul 9, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/659081
Regression Test Proposal
Test:
Submit action via selection mode
Approve action via selection mode
Pay action via selection mode
Approve with delegate restriction (bug fix verification)
Approve with held expenses
Pay as business
Pay with delegate restriction
Partial selection (no report-level actions)
Do we agree 👍 or 👎
cc: @mallenexpensify
Zapier Logs
Run ID: 00040eee-228e-aea6-a5e0-9d7aa18ef584laurenreidexpensify commentedon Jul 20, 2026
$1375 approved for @situchan
laurenreidexpensify commentedon Jul 24, 2026
$1375 approved for @Krishna2323