You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$375] Export option not showing for admins on workspaces who turn off payments #72517
Version Number: 9.2.30-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@ryanldonato Slack conversation (hyperlinked to channel name): #Convert
Action Performed:
Create a workspace as a user
Connect to QBO
Turn off payments in Workflows
Add another user you can log into, make them an admin
Create/Submit/Approve a report and add an expense as the workspace owner
Workspace owner will see an option to Export the report
Observe as other admin
Expected Result:
Other admin also see the export option
Actual Result:
Export option only displayed for workspace owner not admin
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceRecording.1762.mp4
note: we should not update the isPreferredExporter function because it uses in many places in app and can cause regressions
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update the test case of the getReportPrimaryAction function to cover this screnario
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Export option not showing for admins on workspaces who turn off payments[/-][+][$250] Export option not showing for admins on workspaces who turn off payments[/+]on Oct 14, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
User has a workspace connect to QBO with auto-sync is disabled
Test:
Create a workspace as a user
Connect to QBO
Turn off payments in Workflows
Add another user you can log into, make them an admin
Create/Submit/Approve a report and add an expense as the workspace owner
Workspace owner will see an option to Export the report
Observe as other admin
Verify that: Other admin also see the export option
Activity
melvin-bot commentedon Oct 14, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dmkt9 commentedon Oct 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Export option only displayed for workspace owner not admin
What is the root cause of that problem?
We use the
isExportActionhelper to determine whether to show the export action for the primary button.App/src/libs/ReportPrimaryActionUtils.ts
Lines 375 to 377 in 89c45c9
In
isExportAction, the export action is hidden for users who are not preferred exporters.App/src/libs/ReportPrimaryActionUtils.ts
Lines 205 to 208 in 89c45c9
In
isPreferredExporter, even if the current user is an admin, they won’t see the export action if they’re not included in the preferred exporter list.App/src/libs/PolicyUtils.ts
Lines 1522 to 1533 in 89c45c9
What changes do you think we should make in order to solve the problem?
We should allow admins to always see the export action:
App/src/libs/PolicyUtils.ts
Line 1522 in 89c45c9
daledah commentedon Oct 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Export option only displayed for workspace owner not admin
What is the root cause of that problem?
We only show the export option
preferredExporterhereApp/src/libs/ReportPrimaryActionUtils.ts
Lines 205 to 208 in 276a46a
What changes do you think we should make in order to solve the problem?
We should update this condition to allow admin can export or we can update the condition like here
note: we should not update the
isPreferredExporterfunction because it uses in many places in app and can cause regressionsWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update the test case of the
getReportPrimaryActionfunction to cover this screnarioWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Export option not showing for admins on workspaces who turn off payments[/-][+][$250] Export option not showing for admins on workspaces who turn off payments[/+]melvin-bot commentedon Oct 14, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021978202711919656087
JmillsExpensify commentedon Oct 14, 2025
Opening up for proposals.
melvin-bot commentedon Oct 14, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)melvin-bot commentedon Oct 20, 2025
@rushatgabhane Huh... This is 4 days overdue. Who can take care of this?
56 remaining items
mvtglobally commentedon Nov 29, 2025
Issue not reproducible during KI retests. (First week)
danielrvidal commentedon Dec 1, 2025
So I think this one is done then and just waiting to be paid, right?
lakchote commentedon Dec 2, 2025
@danielrvidal yes, this is correct.
melvin-bot commentedon Dec 4, 2025
@Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
trjExpensify commentedon Dec 5, 2025
approved $125 for @rushatgabhane
Krishna2323 commentedon Dec 5, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [No QA] Implement report primary action getter #57475 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Krishna2323 commentedon Dec 5, 2025
The PR was deployed to production on 25 Nov.
@trjExpensify the checklist is completed, please post the payment summary when you get a chance. Thank you!
trjExpensify commentedon Dec 8, 2025
@JmillsExpensify is the BZ on this, not me.
Krishna2323 commentedon Dec 10, 2025
@JmillsExpensify could you please post the payment summary when you get a chance? Thanks!
JmillsExpensify commentedon Dec 12, 2025
Payment summary:
JmillsExpensify commentedon Dec 12, 2025
Contributor paid and regression test created.
Krishna2323 commentedon Dec 29, 2025
Requested in ND.
twisterdotcom commentedon Dec 30, 2025
@Krishna2323 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-00b0-a147-ac01-dae0da3add74