You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Policy room - Able to create room with same name and no error appears #7260
Ah I guess we should be surfacing an error. But actually I don't think this is a bug. A second room doesn't get created right, it just seems like it brings you back to the existing room which seems to be working as intended.
Ahhh I see, the error isn't showing in the create room modal. Thanks for that clarification!
Hmm it is weird that the room is loaded, and you can see it even in the left hand nav, but it seems like the create a room modal is not comparing its title properly to know its a duplicate (only seems to happen right after creation too). Cool I think I have a lead on how to fix this bug, thanks!
Activity
MelvinBot commentedon Jan 15, 2022
Triggered auto assignment to @sketchydroide (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.sketchydroide commentedon Jan 17, 2022
@TomatoToaster it seems you edited this code not that long ago do you know if this has been fixed?
TomatoToaster commentedon Jan 18, 2022
Ah I guess we should be surfacing an error. But actually I don't think this is a bug. A second room doesn't get created right, it just seems like it brings you back to the existing room which seems to be working as intended.
TomatoToaster commentedon Jan 18, 2022
@kavimuru could you verify that when you enter a message into that room and then try to create another room it doesn't try to give you a new one?
TomatoToaster commentedon Jan 18, 2022
Hmm it is weird it didn't show the error text though.
kavimuru commentedon Jan 20, 2022
@TomatoToaster It takes me to the same existing room when I enter a message and create another room. But no error message displayed
Recording.157.mp4
.
TomatoToaster commentedon Jan 21, 2022
Ahhh I see, the error isn't showing in the create room modal. Thanks for that clarification!
Hmm it is weird that the room is loaded, and you can see it even in the left hand nav, but it seems like the create a room modal is not comparing its title properly to know its a duplicate (only seems to happen right after creation too). Cool I think I have a lead on how to fix this bug, thanks!
TomatoToaster commentedon Jan 27, 2022
PR up for this badboy^ just need to test it