Skip to content

Policy room - Able to create room with same name and no error appears #7260

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #7227

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create room e.g. Fish
  3. Create second room with same name Fish

Expected Result:

Error appears if you try to use the same name as an existing policy room in that same workspace.

Actual Result:

Able to create room with same name and no error appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5408669_fish.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Jan 15, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. sketchydroide commented on Jan 17, 2022

    @sketchydroide
    Contributor

    @TomatoToaster it seems you edited this code not that long ago do you know if this has been fixed?

  3. TomatoToaster commented on Jan 18, 2022

    @TomatoToaster
    Contributor

    Ah I guess we should be surfacing an error. But actually I don't think this is a bug. A second room doesn't get created right, it just seems like it brings you back to the existing room which seems to be working as intended.

  4. TomatoToaster commented on Jan 18, 2022

    @TomatoToaster
    Contributor

    @kavimuru could you verify that when you enter a message into that room and then try to create another room it doesn't try to give you a new one?

  5. TomatoToaster commented on Jan 18, 2022

    @TomatoToaster
    Contributor

    Hmm it is weird it didn't show the error text though.

  6. kavimuru commented on Jan 20, 2022

    @kavimuru
    Author

    @TomatoToaster It takes me to the same existing room when I enter a message and create another room. But no error message displayed

    Recording.157.mp4

    .

  7. TomatoToaster commented on Jan 21, 2022

    @TomatoToaster
    Contributor

    Ahhh I see, the error isn't showing in the create room modal. Thanks for that clarification!

    Hmm it is weird that the room is loaded, and you can see it even in the left hand nav, but it seems like the create a room modal is not comparing its title properly to know its a duplicate (only seems to happen right after creation too). Cool I think I have a lead on how to fix this bug, thanks!

  8. TomatoToaster commented on Jan 27, 2022

    @TomatoToaster
    Contributor

    PR up for this badboy^ just need to test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions