Skip to content

[Due for payment 2025-10-27] [Due for payment 2025-10-23] Expense - Manual confirm page is shown when creating Scan expense from shortcut button #72728

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.32-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72714
Email or phone of affected tester (no customers): sdisjnojssidjijjsdoij2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Have a default workspace.
  1. Go to staging.new.expensify.com
  2. Open FAB > Create expense > Manual.
  3. Enter amount > Next.
  4. Close the RHP.
  5. Click expense shortcut option.
  6. On Scan page, upload a receipt.

Expected Result:

The confirmation page should display Scan confirmation page because it is a Scan expense.

Actual Result:

The confirmation page displays Manual confirmation page, with 0.00 on Amount field.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6976177_1760576347273.Screen_Recording_2025-10-16_at_08.55.01.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Oct 16, 2025
  2. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 16, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. ikevin127 commented on Oct 16, 2025

    @ikevin127
    Contributor

    🔄 I ran Vector1 on this deploy blocker issue and here are the top 2 possible offending PRs based on semantic similarity2 and reranking:

    • #72317: fix:72182: correct navigation to confirmation page after Distance upgrade
    • #72714: Add primary receipt scan option on mobile and web - v2

    Please drop a 👍 (correct) or 👎 (incorrect) as feedback regarding the results (will use to fine-tune the reranking model).

    Note

    PR # and name added as text only to avoid triggering regression automation on the issues which the above PRs are addressing in case the finding is incorrect.

    Footnotes

    1. Vector is currently a local-only prototype stage app that uses AI embeddings to find offending PRs for a given deploy blocker issue. Because of the early stage of the app, results must be taken with with a grain of🧂. How it works: grab deploy blocker issue's OP data (title, steps, expected / actual result) and embed -> grab all deploy checklist issue PRs data (title, explanation of change, tests, changed files, AI diff summary) and embed -> calculate cosine similarity of issue embedding to each PRs embedding -> get results -> perform reranking -> get final results. ↩

    2. Semantic similarity, when applied to embeddings, measures the similarity in meaning between different pieces of text by comparing their vector representations in a high-dimensional "semantic space". Texts with similar meanings are mapped to vectors that are close together, and this "closeness" is quantified using metrics like cosine similarity. This technology enables search engines and chatbots to find relevant information even without exact keyword matches, providing more accurate and contextualized results. ↩

  7. 10 remaining items

  8. changed the title [-]Expense - Manual confirm page is shown when creating Scan expense from shortcut button[/-] [+][Due for payment 2025-10-23] Expense - Manual confirm page is shown when creating Scan expense from shortcut button[/+] on Oct 16, 2025
  9. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.32-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-23. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    @ZhenjaHorbach @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. changed the title [-][Due for payment 2025-10-23] Expense - Manual confirm page is shown when creating Scan expense from shortcut button[/-] [+][Due for payment 2025-10-27] [Due for payment 2025-10-23] Expense - Manual confirm page is shown when creating Scan expense from shortcut button[/+] on Oct 20, 2025
  13. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-27. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    @ZhenjaHorbach @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @fabioh8010 is from an agency-contributor and not due payment
    • Contributor: @JKobrynski is from an agency-contributor and not due payment
    • Reviewer: @ZhenjaHorbach owed $250 via NewDot

    BugZero Checklist (@VictoriaExpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. VictoriaExpensify commented on Oct 28, 2025

    @VictoriaExpensify
    Contributor

    Payment Summary:
    Contributor: @fabioh8010 is from an agency-contributor and not due payment
    Contributor: @JKobrynski is from an agency-contributor and not due payment
    C+: @ZhenjaHorbach owed $250 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions