You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Expense - Unable to remove expense from report after changing approver #72731
Version Number: 9.2.32-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#70283 Email or phone of affected tester (no customers):sjidnojoidjiojdsd@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
changed the title [-]Expense - Unable to remove expense from report after changing approver[/-][+][$250] Expense - Unable to remove expense from report after changing approver[/+]on Oct 16, 2025
Please re-state the problem that we are trying to solve in this issue.
The removed expense reappears in the report.
What is the root cause of that problem?
"You cannot move an expense from a report that is already approved."
This is the error comes from backend. The report is marked as approved after changing the approver while in the UI we still allow editing the report field since isReportOutstanding still returns true for this report.
What changes do you think we should make in order to solve the problem?
We can follow the same check hasForwardedAction to check if the report is changed approver or take control and will return false here if it's true. We can follow this approach and improve hasChangeApproverOrTakeControlAction by checking the list sorted report actions in the PR.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Add a new test case to isReportOutstanding function and verify that this function returns false if the report is changed approver
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
This needs to be checked from BE and determined whether it is a bug from BE or we should avoid the action from FE.
Currently the BE ChangeTransactionsReport is returning an error "You cannot move an expense from a report that is already approved." when removing an expense from a report while the report is still outstanding (not approved) but there is a new approver added on the report.
Activity
melvin-bot commentedon Oct 16, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021978659860408853229
[-]Expense - Unable to remove expense from report after changing approver[/-][+][$250] Expense - Unable to remove expense from report after changing approver[/+]melvin-bot commentedon Oct 16, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @FitseTLT (
External)paulnjs commentedon Oct 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The removed expense reappears in the report.
What is the root cause of that problem?
This is the error comes from backend. The report is marked as approved after changing the approver while in the UI we still allow editing the report field since
isReportOutstandingstill returnstruefor this report.App/src/libs/ReportUtils.ts
Lines 4497 to 4499 in e4aabe2
App/src/libs/ReportUtils.ts
Line 10487 in e4aabe2
What changes do you think we should make in order to solve the problem?
We can follow the same check
hasForwardedActionto check if the report is changed approver or take control and will returnfalsehere if it'strue. We can follow this approach and improvehasChangeApproverOrTakeControlActionby checking the list sorted report actions in the PR.App/src/libs/ReportUtils.ts
Lines 10487 to 10510 in e4aabe2
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Add a new test case to
isReportOutstandingfunction and verify that this function returnsfalseif the report is changed approverWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
FitseTLT commentedon Oct 21, 2025
This needs to be checked from BE and determined whether it is a bug from BE or we should avoid the action from FE.
Currently the BE
ChangeTransactionsReportis returning an error"You cannot move an expense from a report that is already approved."when removing an expense from a report while the report is still outstanding (not approved) but there is a new approver added on the report.🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Oct 21, 2025
Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
20 remaining items
m-natarajan commentedon Dec 12, 2025
Reproduced, Windows 11 / Chrome, v9.2.75-9
change.approver.mp4
melvin-bot commentedon Dec 18, 2025
📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
s77rt commentedon Dec 18, 2025
Going to check this one 👀
s77rt commentedon Dec 19, 2025
Update: Raised PR.
s77rt commentedon Dec 31, 2025
PR is deployed already. Can we get a retest on this
jliexpensify commentedon Dec 31, 2025
Requesting with QA
m-natarajan commentedon Dec 31, 2025
Not Reproducible in Windows 11 Chrome - v9.2.89-1
bandicam.2025-12-31.08-43-50-859.mp4
jliexpensify commentedon Dec 31, 2025
Thanks everyone!