Skip to content

[Due for payment 2025-10-27] [Due for payment 2025-10-23] Expense - Approve button reappears when unapproving and approving report offline #72742

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.32-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1305/folder/13176792/41237180/955758429
Email or phone of affected tester (no customers): applausetester+jsdosidjdss@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense in workspace chat.
  4. Open the expense report.
  5. Click Submit, Approve and Mark as paid.
  6. Go offline.
  7. Click More > Cancel payment.
  8. Cancel the payment.
  9. Click More > Unapprove.
  10. Click Approve.

Expected Result:

After unapproving and approving report offline, Approve button will change to Pay button.

Actual Result:

After unapproving and approving report offline, Approve button reappears.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @heyjennahay

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2025
  2. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 16, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. parasharrajat commented on Oct 16, 2025

    @parasharrajat
    Member

    Caused by #70283.... @fahimj Can you please find a solution for this?

  7. mountiny commented on Oct 16, 2025

    @mountiny
    Contributor

    Discussing in Slack

  8. 24 remaining items

  9. changed the title [-][Due for payment 2025-10-23] Expense - Approve button reappears when unapproving and approving report offline[/-] [+][Due for payment 2025-10-27] [Due for payment 2025-10-23] Expense - Approve button reappears when unapproving and approving report offline[/+] on Oct 20, 2025
  10. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-27. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    @parasharrajat @heyjennahay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@heyjennahay)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. parasharrajat commented on Oct 28, 2025

    @parasharrajat
    Member

    We can close this issue.

  15. heyjennahay commented on Oct 30, 2025

    @heyjennahay
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions