Skip to content

[Due for payment 2025-11-11] [$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size #72899

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.33-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237564
Issue reported by: Applause - Internal Team

Action Performed:

  1. Sign in to ND
  2. Navigate to the Concierge chat
  3. Click on the header to open Profile page
  4. Click on the Concierge avatar

Expected Result:

Concierge avatar is opened in full size

Actual Result:

The blank page opens with only "Concierge" title at the top. On Desktop with phone number account the avatar page showed infinite loading

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6978106_1760724669836.Concierge_avatar_2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021981593932150770026
  • Upwork Job ID: 1981593932150770026
  • Last Price Increase: 2025-10-24
  • Automatic offers:
    • situchan | Contributor | 109338459
Issue OwnerCurrent Issue Owner: @greg-schroeder

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 17, 2025
  2. melvin-bot commented on Oct 17, 2025

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. gijoe0295 commented on Oct 17, 2025

    @gijoe0295
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Blank page is displayed when trying to open concierge avatar in full size

    What is the root cause of that problem?

    accountID is supposed to be a number but it's a string when getting from route.params here:

    const {accountID = CONST.DEFAULT_NUMBER_ID} = route.params;

    causing this check to fail (type mismatch):

    App/src/libs/UserUtils.ts

    Lines 137 to 139 in 60eef9a

    if (accountID === CONST.ACCOUNT_ID.CONCIERGE) {
    return ConciergeAvatar;
    }

    And we cannot get the Concierge avatar.

    What changes do you think we should make in order to solve the problem?

    Cast the string type to Number.

    What alternative solutions did you explore? (Optional)

    None

  4. dmkt9 commented on Oct 18, 2025

    @dmkt9
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The blank page opens with only "Concierge" title at the top. On Desktop with phone number account the avatar page showed infinite loading

    What is the root cause of that problem?

    1. The accountID here is typed as a number in TypeScript, but in reality it’s a string.

      const {accountID = CONST.DEFAULT_NUMBER_ID} = route.params;

    2. This causes the condition below to evaluate to false due to a type mismatch, and the avatar fails to load.

      App/src/libs/UserUtils.ts

      Lines 137 to 139 in 98eeb6c

      if (accountID === CONST.ACCOUNT_ID.CONCIERGE) {
      return ConciergeAvatar;
      }

    What changes do you think we should make in order to solve the problem?

    We can verify that accountID in AttachmentModalScreensParamList is always of type number. Therefore, we should cast the type in route.params to ensure this issue doesn’t occur in the future.

    accountID?: number;

    accountID?: number;

    accountID: number;

    Add the following code to cast:

    if (route.params && 'accountID' in route.params) {
        // eslint-disable-next-line react-compiler/react-compiler, no-param-reassign
        route.params.accountID = Number(route.params.accountID);
    }

    at this location:

    }, [attachmentsContext, route]);

    NOTE: we can also apply the same to other params like hashKey

  5. bernhardoj commented on Oct 18, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Concierge avatar isn't shown in preview page.

    What is the root cause of that problem?

    We have already defined the accountID type as a number, but by default, all route params are a string.

    function ProfileAvatarModalContent({navigation, route}: AttachmentModalScreenProps<typeof SCREENS.PROFILE_AVATAR>) {
    const {accountID = CONST.DEFAULT_NUMBER_ID} = route.params;

    So, when checking whether the accountID is a concierge or not, it fails (because we use strict equality, string != number).

    App/src/libs/UserUtils.ts

    Lines 136 to 139 in 7165a14

    function getDefaultAvatar(accountID = -1, avatarURL?: string): IconAsset | undefined {
    if (accountID === CONST.ACCOUNT_ID.CONCIERGE) {
    return ConciergeAvatar;
    }

    What changes do you think we should make in order to solve the problem?

    We need to parse the route params as numbers like we did on some routes, for example:

    [SCREENS.SETTINGS.SUBSCRIPTION.SIZE]: {
    path: ROUTES.SETTINGS_SUBSCRIPTION_SIZE.route,
    parse: {
    canChangeSize: Number,
    },
    },

    [SCREENS.PROFILE_AVATAR]: {
        path: ROUTES.PROFILE_AVATAR.route,
        parse: {
            accountID: Number,
        },
    },
    

    (we can apply the same fix if found another issue on another components)

  6. mkzie2 commented on Oct 18, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The blank page opens with only "Concierge" title at the top. On Desktop with phone number account the avatar page showed infinite loading

    What is the root cause of that problem?

    The account ID has type is number

    accountID: number;

    But the param here is string type

    const {accountID = CONST.DEFAULT_NUMBER_ID} = route.params;

    Therefore, it fails to check here

    if (accountID === CONST.ACCOUNT_ID.CONCIERGE) {

    What changes do you think we should make in order to solve the problem?

    We should update this type to number | string and fix all the type err issues

    accountID: number;

    Note: Can do similar to other cases

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. greg-schroeder commented on Oct 23, 2025

    @greg-schroeder
    Contributor

    @milos213 Do you know where the regression came from?

  8. changed the title [-]Concierge - Blank page is displayed when trying to open concierge avatar in full size[/-] [+][$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/+] on Oct 24, 2025
  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 24, 2025
  10. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  11. melvin-bot commented on Oct 24, 2025

    @melvin-bot
  12. 26 remaining items

  13. changed the title [-][$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/-] [+][Due for payment 2025-11-11] [$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/+] on Nov 4, 2025
  14. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-11. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    @bernhardoj / @situchan @greg-schroeder The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. situchan commented on Nov 10, 2025

    @situchan
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Migrate ProfileAvatar screen to AttachmentModalScreen #72429 (review)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Navigate to the Concierge chat
    2. Press on the header to open the Profile page
    3. Press on the Concierge avatar
    4. Verify that concierge avatar is opened in full size

    Do we agree 👍 or 👎

  18. greg-schroeder commented on Nov 12, 2025

    @greg-schroeder
    Contributor

    Payment summary:

    Author: @bernhardoj - $50 - ND
    Reviewer: @situchan - $50 - Upwork

    Approved for payments as outlined above ☝️

  19. bernhardoj commented on Nov 13, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  20. garrettmknight commented on Nov 21, 2025

    @garrettmknight
    Contributor

    $50 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions