You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-11] [$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size #72899
What changes do you think we should make in order to solve the problem?
We can verify that accountID in AttachmentModalScreensParamList is always of type number. Therefore, we should cast the type in route.params to ensure this issue doesn’t occur in the future.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Concierge - Blank page is displayed when trying to open concierge avatar in full size[/-][+][$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/+]on Oct 24, 2025
changed the title [-][$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/-][+][Due for payment 2025-11-11] [$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/+]on Nov 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@bernhardoj / @situchan@greg-schroeder The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Navigate to the Concierge chat
Press on the header to open the Profile page
Press on the Concierge avatar
Verify that concierge avatar is opened in full size
Activity
melvin-bot commentedon Oct 17, 2025
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.gijoe0295 commentedon Oct 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Blank page is displayed when trying to open concierge avatar in full size
What is the root cause of that problem?
accountIDis supposed to be a number but it's a string when getting fromroute.paramshere:App/src/pages/media/AttachmentModalScreen/routes/ProfileAvatarModalContent.tsx
Line 17 in a50ebc7
causing this check to fail (type mismatch):
App/src/libs/UserUtils.ts
Lines 137 to 139 in 60eef9a
And we cannot get the Concierge avatar.
What changes do you think we should make in order to solve the problem?
Cast the string type to Number.
What alternative solutions did you explore? (Optional)
None
dmkt9 commentedon Oct 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The blank page opens with only "Concierge" title at the top. On Desktop with phone number account the avatar page showed infinite loading
What is the root cause of that problem?
The
accountIDhere is typed as a number in TypeScript, but in reality it’s a string.App/src/pages/media/AttachmentModalScreen/routes/ProfileAvatarModalContent.tsx
Line 17 in 98eeb6c
This causes the condition below to evaluate to false due to a type mismatch, and the avatar fails to load.
App/src/libs/UserUtils.ts
Lines 137 to 139 in 98eeb6c
What changes do you think we should make in order to solve the problem?
We can verify that
accountIDinAttachmentModalScreensParamListis always of type number. Therefore, we should cast the type inroute.paramsto ensure this issue doesn’t occur in the future.App/src/libs/Navigation/types.ts
Line 2183 in 98eeb6c
App/src/libs/Navigation/types.ts
Line 2198 in 98eeb6c
App/src/libs/Navigation/types.ts
Line 2213 in 98eeb6c
Add the following code to cast:
at this location:
App/src/pages/media/AttachmentModalScreen/index.tsx
Line 28 in 98eeb6c
NOTE: we can also apply the same to other params like
hashKeybernhardoj commentedon Oct 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Concierge avatar isn't shown in preview page.
What is the root cause of that problem?
We have already defined the
accountIDtype as a number, but by default, all route params are a string.App/src/pages/media/AttachmentModalScreen/routes/ProfileAvatarModalContent.tsx
Lines 16 to 17 in 7165a14
So, when checking whether the
accountIDis a concierge or not, it fails (because we use strict equality, string != number).App/src/libs/UserUtils.ts
Lines 136 to 139 in 7165a14
What changes do you think we should make in order to solve the problem?
We need to parse the route params as numbers like we did on some routes, for example:
App/src/libs/Navigation/linkingConfig/config.ts
Lines 405 to 410 in 7165a14
(we can apply the same fix if found another issue on another components)
mkzie2 commentedon Oct 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The blank page opens with only "Concierge" title at the top. On Desktop with phone number account the avatar page showed infinite loading
What is the root cause of that problem?
The account ID has type is number
App/src/libs/Navigation/types.ts
Line 2206 in aecce9d
But the param here is string type
App/src/pages/media/AttachmentModalScreen/routes/ProfileAvatarModalContent.tsx
Line 17 in 7165a14
Therefore, it fails to check here
App/src/libs/UserUtils.ts
Line 137 in 7165a14
What changes do you think we should make in order to solve the problem?
We should update this type to number | string and fix all the type err issues
App/src/libs/Navigation/types.ts
Line 2206 in aecce9d
Note: Can do similar to other cases
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
greg-schroeder commentedon Oct 23, 2025
@milos213 Do you know where the regression came from?
[-]Concierge - Blank page is displayed when trying to open concierge avatar in full size[/-][+][$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/+]melvin-bot commentedon Oct 24, 2025
melvin-bot commentedon Oct 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021981593932150770026
26 remaining items
[-][$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/-][+][Due for payment 2025-11-11] [$50] Concierge - Blank page is displayed when trying to open concierge avatar in full size[/+]melvin-bot commentedon Nov 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 4, 2025
@bernhardoj / @situchan @greg-schroeder The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
situchan commentedon Nov 10, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Migrate ProfileAvatar screen to AttachmentModalScreen #72429 (review)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
greg-schroeder commentedon Nov 12, 2025
Payment summary:
Author: @bernhardoj - $50 - ND
Reviewer: @situchan - $50 - Upwork
Approved for payments as outlined above ☝️
bernhardoj commentedon Nov 13, 2025
Requested in ND.
garrettmknight commentedon Nov 21, 2025
$50 approved for @bernhardoj