Skip to content

[Due for payment 2025-12-04] [$250] Investigate incorrect button showing when report is ready to be approved #73098

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


LHN is showing a GBR, and the report preview even shows Outstanding correctly, but the button is View rather than Approve:

Image

Action Performed:

  1. Open New Expensify (staging)
  2. Navigate to the LHN
  3. Locate a workspace expense chat that shows a GBR
  4. Shows “Outstanding” in the preview.
  5. Note that the button incorrectly says “View” (should be “Approve”).

Expected Result:

The button under the expense should say Approve

Actual Result:

The button under the expense says View

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

See Onyx state before clicking into those reports:

And here it is after, note that both turned into Approve buttons, as expected.

Screen.Recording.2025-10-17.at.7.39.17.PM.mov
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021983376400328606187
  • Upwork Job ID: 1983376400328606187
  • Last Price Increase: 2025-11-05
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    Hot PickReady for an engineer to pick up and run with
    on Oct 21, 2025
  2. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. VictoriaExpensify commented on Oct 27, 2025

    @VictoriaExpensify
    Contributor

    Hey @mountiny - can you give a bit more information about what needs to be done with this issue? It looks like we might still need to figure out repro steps, is that right? Do you think you could add more context in the body of the issue, using the standard bug report template?

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 29, 2025
  5. melvin-bot commented on Oct 29, 2025

    @melvin-bot
  6. changed the title [-]Investigate incorrect button showing when report is ready to be approved[/-] [+][$250] Investigate incorrect button showing when report is ready to be approved[/+] on Oct 29, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 29, 2025
  8. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

  9. Krishna2323 commented on Nov 3, 2025

    @Krishna2323
    Contributor

    Waiting for proposals.

  10. 44 remaining items

  11. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@VictoriaExpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1983376400328606187/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. VictoriaExpensify commented on Dec 5, 2025

    @VictoriaExpensify
    Contributor

    Payment summary:
    C: @rayane-d does not require payment (Contractor)
    C+: @Krishna2323 owed $250 via NewDot

  13. Krishna2323 commented on Dec 6, 2025

    @Krishna2323
    Contributor

    Requested in ND.

  14. quinthar commented on Dec 8, 2025

    @quinthar
    Contributor

    Approved $250 to @Krishna2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions