Skip to content

[Due for payment 2025-10-30] Bug: It is possible to get "Add Payment Card" button screen on iOS #73246

Closed

Description

@blimpich

Problem

Apple has reported that it's possible to show a "add payment card" button on our app. This violates app store policies since we should not be showing any ability to add payment cards in our app. We are blocked from shipping our app out to customers while this is an issue.

Screenshots:

Image

Solution:

Figure out how to reproduce this and then make it not possible to get to the Add-Payment-Card screen on iOS (& Android if that is also an issue).

Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 22, 2025
  2. melvin-bot commented on Oct 22, 2025

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 22, 2025

    @melvin-bot

    Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 22, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 22, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. blimpich commented on Oct 22, 2025

    @blimpich
    ContributorAuthor

    reassigning because it's the middle of the night for @mollfpr

  7. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 22, 2025
  8. melvin-bot commented on Oct 22, 2025

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  9. 16 remaining items

  10. abzokhattab commented on Oct 24, 2025

    @abzokhattab
    Contributor

    @OfstadC I helped in the review as C+. Should we reopen it for payment, or how should it work?

  11. blimpich commented on Oct 24, 2025

    @blimpich
    ContributorAuthor

    Yes @abzokhattab is due payment. $250 for normal C+ review. I should've added them to this issue and clarified that, sorry!

  12. OfstadC commented on Oct 24, 2025

    @OfstadC
    Contributor

    No worries! Reviewing and processing now 😃

  13. OfstadC commented on Oct 24, 2025

    @OfstadC
    Contributor
  14. abzokhattab commented on Oct 24, 2025

    @abzokhattab
    Contributor

    Thank you. offer accepted.

  15. OfstadC commented on Oct 30, 2025

    @OfstadC
    Contributor

    Payment Summary

  16. melvin-bot commented on Sep 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions