Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.2.37-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237589
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11, Chrome | iPhone SE 3rd generation, Tahoe 26.0.1
App Component: Other
Action Performed:
- Go to https://staging.new.expensify.com.
- Sign up with a Gmail address (without a +).
- Select Manage my team's expenses > choose 1–10 employees > select QBO. Skip the remaining onboarding steps.
- Navigate to Workspaces and delete the current workspace.
- In the top right corner, click the magnifying glass icon.
- Search for the #admins room and click on it.
- In the task Invite your team, click the hyperlink labeled your .
- Click Go back to home page.
Expected Result:
The “Invite your team” deeplink should redirect the user to the Home screen, as the button states.
Actual Result:
The deeplink currently redirects to the Workspaces screen instead of Home.
This is inconsistent with other Concierge tasks: performing the same steps in similar tasks (e.g., “Connect to QuickBooks online”, “Connect to your corporate card”) correctly redirects the user to Home.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
bug.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021983655206553715252
- Upwork Job ID: 1983655206553715252
- Last Price Increase: 2025-11-05
- Automatic offers:
- linhvovan29546 | Reviewer | 109470547
- FitseTLT | Contributor | 109470549
Issue Owner
Current Issue Owner: @heyjennahayMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Oct 23, 2025
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.abbasifaizan70 commentedon Oct 23, 2025
Proposal: "Go back to home page" button redirects to Workspaces instead of Home
Please re-state the problem that we are trying to solve in this issue.
When a user follows the "Invite your team" Concierge task deeplink after deleting their workspace, and then clicks the "Go back to home page" button on the resulting "Not Found" page, they are incorrectly redirected to the Workspaces screen instead of the Home screen.
What is the root cause of that problem?
The root cause is in the
goBackFromInvalidPolicy()function insrc/libs/PolicyUtils.ts(line 658-660).When a workspace-related page (like the workspace members page) cannot be accessed because the workspace doesn't exist or the user doesn't have permission, a "Not Found" view is displayed via the
FullPageNotFoundViewcomponent inWorkspacePageWithSections.tsx(line 200-206). This view shows a button with the text "Go back to home page" (notFound.goBackHometranslation key).The button's
onLinkPresshandler is set togoBackFromInvalidPolicy(), which currently navigates to the Workspaces list instead of Home:This creates a mismatch between:
/workspaces)The
goBackFromInvalidPolicy()function is used in 47 locations across the codebase for all workspace "not found" scenarios, including:WorkspacePageWithSections.tsx(used by all workspace pages)WorkspaceInvitePage.tsxWorkspaceOverviewPage.tsxWorkspaceWorkflowsApprovalsEditPage.tsxWhat changes do you think we should make in order to solve the problem?
Update the
goBackFromInvalidPolicy()function insrc/libs/PolicyUtils.tsto navigate toROUTES.HOMEinstead ofROUTES.WORKSPACES_LIST.route.Proposed Code Change:
File:
src/libs/PolicyUtils.tsfunction goBackFromInvalidPolicy() { - Navigation.goBack(ROUTES.WORKSPACES_LIST.route); + Navigation.goBack(ROUTES.HOME); }What alternative solutions did you explore?
Alternative 1: Add a
backToparameter to WORKSPACE_MEMBERS routeInstead of changing the global
goBackFromInvalidPolicy()behavior, we could modify theworkspaceMembersLinkgeneration insrc/libs/ReportUtils.ts(line 10827) to include abackToparameter pointing to HOME:Why this was rejected:
Demo After Fix
https://www.loom.com/share/6493eb1ccf02404ab36dbdd0e710e344?sid=242ad2d9-4369-49ba-81cc-6ec77fc3490a
FitseTLT commentedon Oct 23, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-08 14:42:21 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
#admins - “Invite your team” deeplink redirects to Workspaces instead of Home
What is the root cause of that problem?
When the workspace page uses AccessOrNotFoundWrapper it is redirected to the more features for a deleted workspace
App/src/pages/workspace/AccessOrNotFoundWrapper.tsx
Line 201 in b3fc242
and the More Features page will show not found page via AccessOrNotFoundWrapper whose
onLinkPressnavigates it to homeApp/src/components/BlockingViews/FullPageNotFoundView.tsx
Line 78 in b3fc242
but for invite your team we are navigated to members page and the
FullPageNotFoundViewof WorkspacePageWithSectionsonLinkPressgoes back toWORKSPACES_LISTpageApp/src/pages/workspace/WorkspacePageWithSections.tsx
Line 202 in b3fc242
What changes do you think we should make in order to solve the problem?
The expected behavior should be confirmed but to make the behavior consistent we have three options
AccessOrNotFoundWrapperfor workspace pages we haven't implemented such as the WorkspaceMembersPage so that we will have a consistent behavior of redirecting to more features and also the back navigation.onLinkPressbehavior consistent between the not found of WorkspacePageWithSections with AccessOrNotFoundWrapper to whichever of the two mechanisms that is acceptable.linkTranslationKeyin WorkspacePageWithSections to align with the navigation to workspce list page.In addition to that, to make the go back consistent between the pages we can re-implement the logic here
App/src/pages/workspace/AccessOrNotFoundWrapper.tsx
Lines 123 to 127 in 0be1450
on
App/src/pages/workspace/WorkspacePageWithSections.tsx
Line 201 in 0be1450
so that the user is navigated back to previous page if they come from report page
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Oct 28, 2025
@heyjennahay Huh... This is 4 days overdue. Who can take care of this?
[-]#admins - “Invite your team” deeplink redirects to Workspaces instead of Home[/-][+][$250] #admins - “Invite your team” deeplink redirects to Workspaces instead of Home[/+]melvin-bot commentedon Oct 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021983655206553715252
melvin-bot commentedon Oct 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (
External)42 remaining items
FitseTLT commentedon Nov 18, 2025
PR will be ready tomorrow. Sorry for the delay.
linhvovan29546 commentedon Dec 1, 2025
The PR has been deployed to production, the payment due date should be
2025-12-04#75732 (comment)
cristipaval commentedon Dec 1, 2025
Not overdue
[-][$250] #admins - “Invite your team” deeplink redirects to Workspaces instead of Home[/-][+][Due for payment 2025-12-04] [$250] #admins - “Invite your team” deeplink redirects to Workspaces instead of Home[/+]linhvovan29546 commentedon Dec 3, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/62849/files#r2584245571
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Looks like we already have a regression test for this here: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237589, so I think we don’t need to create an additional one
Do we agree 👍 or 👎
heyjennahay commentedon Dec 5, 2025
Payment summary:
Both contracts and the job posting have been closed.
Thanks everyone for your work ❤️