You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-02][$250] Tags - Missing tag violation doesn't show tag name in error #73417
Version Number: V9.2.37-8 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#40741 Email or phone of affected tester (no customers): Slottwo1 fgg55@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Workspace Settings
Action Performed:
Launch app
Go to workspace settings
Enable tags
Set tag a custom name
Enable members must tag all expenses
Go to workspace chat
Create a manual expense without tag
Expected Result:
Missing tag violation must show tag name in error.
Actual Result:
Missing tag violation doesn't show tag name in error.
Please re-state the problem that we are trying to solve in this issue.
Missing tag violation doesn't show tag name in error.
What is the root cause of that problem?
The bug is in the getTagViolationsForSingleLevelTags function.
When creating a missing tag violation for single-level tags, the code doesn't include the tagName in the violation's data object:
What changes do you think we should make in order to solve the problem?
Add the tagName to the violation data when creating missing tag violations for single-level tags, matching the pattern used for multi-level tags. We should fix all places where we need to pass tagName, like:
What changes do you think we should make in order to solve the problem?
We should add tagName as policyTagListName
// Add 'missingTag violation' if tag is required and not set
if (!hasMissingTagViolation && !updatedTransaction.tag && policyRequiresTags) {
newTransactionViolations.push({name: CONST.VIOLATIONS.MISSING_TAG, type: CONST.VIOLATION_TYPES.VIOLATION, data: {tagName: policyTagListName}});
}
Then we also need to update the Back End UpdateMoneyRequestTag API to return Tag name in data in transaction violations
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Tags - Missing tag violation doesn't show tag name in error[/-][+][$250] Tags - Missing tag violation doesn't show tag name in error[/+]on Oct 24, 2025
Activity
melvin-bot commentedon Oct 24, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mohammadjafarinejad commentedon Oct 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Missing tag violation doesn't show tag name in error.
What is the root cause of that problem?
The bug is in the
getTagViolationsForSingleLevelTagsfunction.When creating a missing tag violation for single-level tags, the code doesn't include the
tagNamein the violation'sdataobject:App/src/libs/Violations/ViolationsUtils.ts
Lines 52 to 55 in e27727e
The violation is created without the
data: {tagName: ...}field, which causes the translation function to fall back to the generic "tag" text.For comparison, the code correctly handles this for dependent tags (multi-level):
App/src/libs/Violations/ViolationsUtils.ts
Lines 62 to 71 in e27727e
The translation function expects a
tagNameparameter. WhentagNameis undefined, it falls back to the generic "Missing tag".App/src/languages/en.ts
Line 6667 in 8e8adfe
What changes do you think we should make in order to solve the problem?
Add the
tagNameto the violation data when creating missing tag violations for single-level tags, matching the pattern used for multi-level tags. We should fix all places where we need to passtagName, like:App/src/libs/Violations/ViolationsUtils.ts
Lines 52 to 55 in e27727e
App/src/libs/Violations/ViolationsUtils.ts
Lines 37 to 40 in e27727e
Example:
What alternative solutions did you explore? (Optional)
None
daledah commentedon Oct 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Missing tag violation doesn't show tag name in error.
What is the root cause of that problem?
We don't add the tagName data here
App/src/libs/Violations/ViolationsUtils.ts
Lines 52 to 55 in a77718d
What changes do you think we should make in order to solve the problem?
tagNameaspolicyTagListNameUpdateMoneyRequestTagAPI to return Tag name in data in transaction violationsWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Oct 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021981723294903105744
[-]Tags - Missing tag violation doesn't show tag name in error[/-][+][$250] Tags - Missing tag violation doesn't show tag name in error[/+]melvin-bot commentedon Oct 24, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)eVoloshchak commentedon Oct 27, 2025
@mohammadjafarinejad's proposal looks good to me!
🎀👀🎀 C+ reviewed!
melvin-bot commentedon Oct 27, 2025
Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
49 remaining items
stephanieelliott commentedon Dec 17, 2025
Payment Summary
mohammadjafarinejad commentedon Dec 18, 2025
@stephanieelliott Accepted. Thanks!
stephanieelliott commentedon Dec 18, 2025
All paid up, thanks!
eVoloshchak commentedon Dec 18, 2025
@stephanieelliott, I'm also owed payment for review of #74152
melvin-bot commentedon Dec 26, 2025
@amyevans, @eVoloshchak, @rushatgabhane, @stephanieelliott, @mohammadjafarinejad Whoops! This issue is 2 days overdue. Let's get this updated quick!
stephanieelliott commentedon Dec 31, 2025
Oops, sorry @eVoloshchak! Updated the payment summary to show your're owed $250 via NewDot
trjExpensify commentedon Jan 13, 2026
$250 approved for @eVoloshchak.