You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-19] [Due for payment 2025-11-13] [$250] Make More Features animation more obvious and add tap target #73508
We've seen user confusion when users go to add more features in the workspace editor not understanding what happens next.
Solution
Make feature tapable when enabled. When a feature is enabled, we should make the left side of the container tapable to navigate to the feature while retaining the switch toggle to enable/disabled the feature
Increase the timing of the animation to 10 seconds and change color to highlight color. This'll ensure the highlight stays on the screen for longer increasing users visibility into the newly added feature. Current behavior:
CleanShot.2025-10-27.at.12.01.37.mp4
In addition to making the fade-out delay animation 10 seconds, let's make a color change to our highlight color, that way we standardize to other patterns we have.
Let's leave the rest of the animation alone as it's working well, only the fade-out delay time and the color should be tweaked on this element.
changed the title [-]Make More Features animation more obvious and add tap target[/-][+][$250] Make More Features animation more obvious and add tap target[/+]on Oct 27, 2025
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
Please re-state the problem that we are trying to solve in this issue.
Users are confused when they add features in the workspace editor ("More Features" page) because:
After enabling a feature, users don't understand what happens next or where to find the newly enabled feature
The highlight animation that appears when a feature is enabled is too subtle (wrong color and fades too quickly)
There's no way to navigate to an enabled feature's settings page directly from the More Features page
What is the root cause of that problem?
Root Cause 1 - Animation visibility:
The current highlight animation uses theme.border color (gray) and fades out after only 800ms, making it barely noticeable to users.
Root Cause 2 - Missing navigation:
The ToggleSettingOptionRow component only supports toggling the switch, but doesn't provide a way to tap the feature item itself to navigate to its settings when enabled.
Change the default highlight color from theme.border (gray) to theme.highlightBG (yellow) to make it more visible and consistent with other highlight patterns in the app.
/** The base highlightColor used for the highlight animation, defaults to theme.border
* @default theme.border
*/
highlightColor?: string;
// Current/** The base highlightColor used for the highlight animation, defaults to theme.border * @default theme.border */
highlightColor?: string;// Change to/** The base highlightColor used for the highlight animation, defaults to theme.highlightBG * @default theme.highlightBG */
highlightColor?: string;
/** subtitle should show below switch and title */
shouldPlaceSubtitleBelowSwitch?: boolean;
/** Whether or not the text should be escaped */
shouldEscapeText?: boolean;
/** Whether should render subtitle as HTML or as Text */
shouldParseSubtitle?: boolean;
/** Used to apply styles to the outermost container */
wrapperStyle?: StyleProp<ViewStyle>;
/** Used to apply styles to the Title */
titleStyle?: StyleProp<TextStyle>;
/** Used to apply styles to the Subtitle */
subtitleStyle?: StyleProp<TextStyle>;
/** Used to apply styles to the Accordion */
accordionStyle?: StyleProp<ViewStyle>;
/** Whether the option is enabled or not */
isActive: boolean;
/** Callback to be called when the switch is toggled */
onToggle: (isEnabled: boolean)=>void;
/** SubMenuItems will be shown when the option is enabled */
subMenuItems?: React.ReactNode;
/** If there is a pending action, we will grey out the option */
pendingAction?: PendingAction;
/** Any error message to show */
errors?: Errors;
/** Callback to close the error messages */
onCloseError?: ()=>void;
/** Whether the toggle should be disabled */
disabled?: boolean;
/** Whether to show the lock icon even if the switch is enabled */
showLockIcon?: boolean;
/** Callback to fire when the switch is toggled in disabled state */
disabledAction?: ()=>void;
};
Add new prop to the type definition:
typeToggleSettingOptionRowProps={// ... existing props .../** Callback to fire when the left content is pressed (only when enabled) */onPressWhenEnabled?: ()=>void;};
Update the renderItem function to pass onPressWhenEnabled:
constrenderItem=useCallback((item: Item)=>(<Viewkey={item.titleTranslationKey}style={[styles.workspaceSectionMoreFeaturesItem,shouldUseNarrowLayout&&styles.flexBasis100,shouldUseNarrowLayout&&StyleUtils.getMinimumWidth(0)]}><ToggleSettingOptionRowicon={item.icon}disabled={item.disabled}disabledAction={item.disabledAction}title={translate(item.titleTranslationKey)}titleStyle={styles.textStrong}subtitle={translate(item.subtitleTranslationKey)}switchAccessibilityLabel={translate(item.subtitleTranslationKey)}isActive={item.isActive}pendingAction={item.pendingAction}onToggle={item.action}showLockIcon={item.disabled}errors={item.errors}onCloseError={item.onCloseError}onPressWhenEnabled={item.onPressWhenEnabled}// Add this new prop/></View>),[styles,StyleUtils,shouldUseNarrowLayout,translate],);
⚠️@TaduJR Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
When linkToOpenWhenClickOnContent is not undefined and isActive === true, we wrap the content with PressableWithoutFeedback here and use Navigation.navigate to handle the navigation.
The highlight duration and color for the item can be adjusted here. You can choose suitable values for highlightStartDuration, highlightColor, and backgroundColor:
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.54-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
[-]Make More Features animation more obvious and add tap target[/-][+][$250] Make More Features animation more obvious and add tap target[/+]melvin-bot commentedon Oct 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021982630516513187248
melvin-bot commentedon Oct 27, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (
External)nkdengineer commentedon Oct 27, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Improvement
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
Create a new prop in
ToggleSettingOptionRowcomponent likeonPressThen add
contentAreatoToggleSettingOptionRowonPressfor the item inWorkspaceMoreFeaturesPageexampleApp/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Lines 135 to 148 in 5b2116f
onPresshereApp/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Lines 398 to 413 in 5b2116f
App/src/CONST/index.ts
Lines 207 to 208 in 9c3ecb2
then we need to pass
highlightColortoanimatedHighlightStylehereApp/src/components/HighlightableMenuItem.tsx
Lines 19 to 23 in 9c3ecb2
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Oct 27, 2025
mohammadjafarinejad commentedon Oct 27, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users are confused when adding more features in the workspace editor and do not understand what happens next.
What is the root cause of that problem?
New feature request
What changes do you think we should make in order to solve the problem?
1. Update Animation Timing (
src/CONST/index.ts)Change
ANIMATED_HIGHLIGHT_END_DURATIONfrom2000to10000:App/src/CONST/index.ts
Line 208 in b138080
2. Update Highlight Color (
src/hooks/useAnimatedHighlightStyle/index.ts)Change default from
theme.bordertotheme.highlightBG:3. Add Tap Target (
src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx)Add
onNavigateprop and conditionally render pressable area:4. Add Navigation Routes (
src/pages/workspace/WorkspaceMoreFeaturesPage.tsx)Add
routeproperty toItemtype and pass to each feature:What alternative solutions did you explore? (Optional)
None
TaduJR commentedon Oct 27, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users are confused when they add features in the workspace editor ("More Features" page) because:
What is the root cause of that problem?
Root Cause 1 - Animation visibility:
The current highlight animation uses
theme.bordercolor (gray) and fades out after only 800ms, making it barely noticeable to users.App/src/CONST/index.ts
Line 207 in bceff96
App/src/hooks/useAnimatedHighlightStyle/index.ts
Line 74 in bceff96
Root Cause 2 - Missing navigation:
The
ToggleSettingOptionRowcomponent only supports toggling the switch, but doesn't provide a way to tap the feature item itself to navigate to its settings when enabled.App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Lines 156 to 204 in bceff96
The component renders the icon, title, and subtitle alongside the switch, but the entire left section is not interactive when the feature is enabled.
What changes do you think we should make in order to solve the problem?
Change 1: Update Animation Constants
Update the fade-out delay from 800ms to 10 seconds (10000ms) to give users more time to notice the highlight.
File:
src/CONST/index.tsApp/src/CONST/index.ts
Line 207 in bceff96
Change 2: Update Highlight Color
Change the default highlight color from
theme.border(gray) totheme.highlightBG(yellow) to make it more visible and consistent with other highlight patterns in the app.File:
src/hooks/useAnimatedHighlightStyle/index.tsApp/src/hooks/useAnimatedHighlightStyle/index.ts
Lines 39 to 42 in bceff96
App/src/hooks/useAnimatedHighlightStyle/index.ts
Line 74 in bceff96
Change 3: Add Tap Target to ToggleSettingOptionRow
Add a new optional prop
onPressWhenEnabledto make the left content area (icon + title + subtitle) tappable when the feature is enabled.File:
src/pages/workspace/workflows/ToggleSettingsOptionRow.tsxApp/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Lines 1 to 16 in bceff96
Add import for PressableWithFeedback:
App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Lines 17 to 80 in bceff96
Add new prop to the type definition:
App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Lines 83 to 105 in bceff96
Add the new prop to the component parameters:
App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Lines 156 to 159 in bceff96
After the
subTitleViewuseMemo, add a new variable for the content area:App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Lines 164 to 194 in bceff96
Replace the existing render logic with conditional rendering:
Change 4: Add Navigation to WorkspaceMoreFeaturesPage
Add navigation routes and handlers for each feature when they are enabled.
File:
src/pages/workspace/WorkspaceMoreFeaturesPage.tsxApp/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Lines 59 to 70 in bceff96
Update the
Itemtype to include navigation route:Add navigation routes for each item. For example, for the categories item:
App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Lines 256 to 271 in bceff96
Apply similar pattern for all features:
ROUTES.WORKSPACE_TAGS.getRoute(policyID)ROUTES.WORKSPACE_TAXES.getRoute(policyID)ROUTES.WORKSPACE_DISTANCE_RATES.getRoute(policyID)ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policyID)ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID)ROUTES.WORKSPACE_PER_DIEM.getRoute(policyID)ROUTES.WORKSPACE_WORKFLOWS.getRoute(policyID)ROUTES.WORKSPACE_RULES.getRoute(policyID)ROUTES.WORKSPACE_INVOICES.getRoute(policyID)ROUTES.POLICY_ACCOUNTING.getRoute(policyID)App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Lines 392 to 416 in bceff96
Update the
renderItemfunction to passonPressWhenEnabled:github-actions commentedon Oct 27, 2025
dmkt9 commentedon Oct 27, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
We've seen user confusion when users go to add more features in the workspace editor not understanding what happens next.
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
In
ToggleSettingOptionRow, we add a new prop calledlinkToOpenWhenClickOnContent.App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Line 83 in bceff96
When
linkToOpenWhenClickOnContentis notundefinedandisActive === true, we wrap the content withPressableWithoutFeedbackhere and useNavigation.navigateto handle the navigation.App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
Lines 165 to 166 in bceff96
The highlight duration and color for the item can be adjusted here. You can choose suitable values for
highlightStartDuration,highlightColor, andbackgroundColor:App/src/components/HighlightableMenuItem.tsx
Lines 19 to 23 in bceff96
What alternative solutions did you explore? (Optional)
N/A
nkdengineer commentedon Oct 27, 2025
To make this easier to test, this is test brach. And this is the result
Screen.Recording.2025-10-27.at.09.30.01.mov
37 remaining items
melvin-bot commentedon Nov 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.54-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 19, 2025
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.cead22 commentedon Nov 19, 2025
@VictoriaExpensify can you handle the payments please? @dubielzyk-expensify I'm assuming this is done
dubielzyk-expensify commentedon Nov 19, 2025
Yeah this is fixed 👍
VictoriaExpensify commentedon Nov 25, 2025
Payment Summary:
C: @nkdengineer owed $250 via ND
C+: @abzokhattab paid $250 via UW
twisterdotcom commentedon Mar 11, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-2c01-a03a-97ce-9df7a19e0f54