You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-03] [$250] Expense - Delete option is missing in More menu after bypassing approver #73554
Version Number: 9.2.38-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#72682 Email or phone of affected tester (no customers):dsniojosinjdoisj@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Admin invites member to the workspace.
The invited member is the approver.
Perform the following steps as admin:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense in the workspace chat.
Open the expense report.
Click Submit.
Click More > Change approver.
Click Bypass approvers.
Click Change approver.
Click More.
BUG: Delete option is missing.
Go back to main workspace chat.
Right click on the expense preview.
→ Delete option is present - Expected.
Expected Result:
In Step 10, after bypassing approver, Delete option will be present in More menu because the report is not approved yet.
Actual Result:
In Step 10, after bypassing approver, Delete option is missing in More menu.
🚨 Edited by proposal-police: This proposal was edited at 2025-10-29 20:11:56 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
After bypassing approvers on an expense report, the Delete option is missing from the More menu even though the report has not been approved yet. The Delete option should be present because the report is still in a deletable state.
What is the root cause of that problem?
The issue occurs in the canDeleteMoneyRequestReport function in src/libs/ReportUtils.ts. The delete permission for expense reports is gated by a forwarding check instead of the report lifecycle. Concretely, the existing logic returns:
This makes the Delete option depend on whether the report has been forwarded, which is unnecessary for the intended behavior. What we expect is that the submitter should be able to delete any outstanding report (Open or Submitted) until it is approved/finished, regardless of whether it was forwarded or bypassed.
What changes do you think we should make in order to solve the problem?
Remove the forwarding-based gate entirely and base deletion solely on submitter + lifecycle (Open or Submitted).
Update the expense-report branch in canDeleteMoneyRequestReport:
I confirmed that a user should be able to delete an outstanding report as long as it has not been approved by anyone yet. So the expected behavior described above is correct.
changed the title [-]Expense - Delete option is missing in More menu after bypassing approver[/-][+][$250] Expense - Delete option is missing in More menu after bypassing approver[/+]on Oct 29, 2025
@ZhenjaHorbach@sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Admin invites a member to the workspace
The invited member is set as the approver
Test:
Open a workspace chat
Create an expense in the workspace chat
Open the expense report
Click Submit
Click More > Change approver
Add approver
Click change approver
Click more
Verify the Delete option is now present in the More menu
Click More > Change approver
Click Bypass approvers
Click Change approver
Click More
Verify the Delete option is now present in the More menu
Activity
melvin-bot commentedon Oct 27, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.coderyak commentedon Oct 27, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-10-29 20:11:56 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
After bypassing approvers on an expense report, the Delete option is missing from the More menu even though the report has not been approved yet. The Delete option should be present because the report is still in a deletable state.
What is the root cause of that problem?
The issue occurs in the
canDeleteMoneyRequestReportfunction insrc/libs/ReportUtils.ts. The delete permission for expense reports is gated by a forwarding check instead of the report lifecycle. Concretely, the existing logic returns:This makes the Delete option depend on whether the report has been forwarded, which is unnecessary for the intended behavior. What we expect is that the submitter should be able to delete any outstanding report (Open or Submitted) until it is approved/finished, regardless of whether it was forwarded or bypassed.
What changes do you think we should make in order to solve the problem?
Remove the forwarding-based gate entirely and base deletion solely on submitter + lifecycle (Open or Submitted).
Update the expense-report branch in
canDeleteMoneyRequestReport:From:
To:
What alternative solutions did you explore? (Optional)
None
sakluger commentedon Oct 27, 2025
I'm not sure if an admin should be able to delete an Outstanding report. Checking in Slack: https://expensify.slack.com/archives/C03U7DCU4/p1761577613486879
sakluger commentedon Oct 29, 2025
I confirmed that a user should be able to delete an outstanding report as long as it has not been approved by anyone yet. So the expected behavior described above is correct.
Adding the external label.
[-]Expense - Delete option is missing in More menu after bypassing approver[/-][+][$250] Expense - Delete option is missing in More menu after bypassing approver[/+]melvin-bot commentedon Oct 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021983556846733895088
melvin-bot commentedon Oct 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)coderyak commentedon Oct 29, 2025
Proposal
Updated based on @sakluger's input.
melvin-bot commentedon Nov 4, 2025
@ZhenjaHorbach Eep! 4 days overdue now. Issues have feelings too...
28 remaining items
melvin-bot commentedon Nov 26, 2025
@ZhenjaHorbach @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ZhenjaHorbach commentedon Dec 2, 2025
BugZero Checklist:
https://github.com/Expensify/App/pull/70349/files#r2582171149
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
sakluger commentedon Dec 3, 2025
Hi @coderyak could you please post your Upwork profile here so I can send you an offer?
sakluger commentedon Dec 3, 2025
Payment Summary
Contributor: @coderyak due $250 via Upwork: Paid
Contributor+: @ZhenjaHorbach due $250 via Newdot
melvin-bot commentedon Dec 3, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sakluger)
coderyak commentedon Dec 4, 2025
@sakluger sure, here
sakluger commentedon Dec 4, 2025
Thanks @coderyak! I've sent you an offer here. Please let me know once you've accepted it.
ZhenjaHorbach commentedon Dec 4, 2025
Requested in ND!
coderyak commentedon Dec 5, 2025
@sakluger thanks for the offer, I've accepted it!!
JmillsExpensify commentedon Dec 5, 2025
$250 approved for @ZhenjaHorbach
sakluger commentedon Dec 5, 2025
I completed the Upwork payment, all done here!