You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Expense - Report field opens not here page when workspace has outstanding report and no draft #73609
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - Report field opens not here page when workspace has outstanding report and no draft[/-][+][$250] Expense - Report field opens not here page when workspace has outstanding report and no draft[/+]on Nov 4, 2025
📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Hi 👋 @JmillsExpensify, This one's ready for payment, it's already been a week since the production deploy, the automation seems failed, please when you get a chance. Many thanks
Activity
melvin-bot commentedon Oct 28, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Oct 28, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report field opens not here page when workspace has at least two outstanding report and there is no draft report.
What is the root cause of that problem?
with
isFromGlobalCreateis true we only checkallOutstandingReportshere even though we don't have anyavailable Outstanding ReportsApp/src/components/MoneyRequestConfirmationListFooter.tsx
Line 337 in 805a21f
then
expenseReportshere is [] => we returnshouldShowNotFoundPageas true hereApp/src/pages/iou/request/step/IOURequestEditReportCommon.tsx
Lines 218 to 220 in 805a21f
What changes do you think we should make in order to solve the problem?
We will only allow users to edit reports when
availableOutstandingReports.length > 1. So update this condition toApp/src/components/MoneyRequestConfirmationListFooter.tsx
Line 337 in 805a21f
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Oct 31, 2025
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Expense - Report field opens not here page when workspace has outstanding report and no draft[/-][+][$250] Expense - Report field opens not here page when workspace has outstanding report and no draft[/+]melvin-bot commentedon Nov 4, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021985848249714523186
melvin-bot commentedon Nov 4, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)7 remaining items
melvin-bot commentedon Nov 9, 2025
Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
melvin-bot commentedon Nov 10, 2025
📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Nov 10, 2025
📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
NJ-2020 commentedon Nov 12, 2025
PR is ready
cc: @aimane-chnaif
NJ-2020 commentedon Dec 2, 2025
Hi 👋 @JmillsExpensify, This one's ready for payment, it's already been a week since the production deploy, the automation seems failed, please when you get a chance. Many thanks
JmillsExpensify commentedon Dec 3, 2025
Payment summary:
JmillsExpensify commentedon Dec 3, 2025
All contributors paid out. Closing.