Skip to content

[$250] Expense - Report field opens not here page when workspace has outstanding report and no draft #73609

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.39-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-1524/folder/13177049/42645090/976865720
Email or phone of affected tester (no customers): sdjnsoidjosidjs1@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with new account.
  3. Create a workspace.
  4. Go to workspace chat.
  5. Create an expense.
  6. Click Submit on the report preview.
  7. Repeat Step 5 and 6 so there are two outstanding reports.
  8. Open FAB > Create expense > Manual.
  9. Enter amount > Next.
  10. On confirm page, click Report field.

Expected Result:

Report field will open list of reports.

Actual Result:

Report field opens not here page when workspace has at least two outstanding report and there is no draft report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6986320_1761610719107.5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021985848249714523186
  • Upwork Job ID: 1985848249714523186
  • Last Price Increase: 2025-11-04
  • Automatic offers:
    • aimane-chnaif | Reviewer | 109430641
    • NJ-2020 | Contributor | 109430643
Issue OwnerCurrent Issue Owner: @stitesExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2025
  2. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Oct 28, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Report field opens not here page when workspace has at least two outstanding report and there is no draft report.

    What is the root cause of that problem?

    with isFromGlobalCreate is true we only check allOutstandingReports here even though we don't have any available Outstanding Reports

    const shouldReportBeEditable = (isFromGlobalCreate ? allOutstandingReports.length > 1 : availableOutstandingReports.length > 1) && !isMoneyRequestReport(reportID, allReports);

    then expenseReports here is [] => we return shouldShowNotFoundPage as true here

    if (expenseReports.length === 0 || shouldShowNotFoundPageFromProps) {
    return true;
    }

    What changes do you think we should make in order to solve the problem?

    We will only allow users to edit reports when availableOutstandingReports.length > 1. So update this condition to

        const shouldReportBeEditable = availableOutstandingReports.length > 1 && !isMoneyRequestReport(reportID, allReports);
    

    const shouldReportBeEditable = (isFromGlobalCreate ? allOutstandingReports.length > 1 : availableOutstandingReports.length > 1) && !isMoneyRequestReport(reportID, allReports);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Oct 31, 2025

    @melvin-bot

    @JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 4, 2025
  6. changed the title [-]Expense - Report field opens not here page when workspace has outstanding report and no draft[/-] [+][$250] Expense - Report field opens not here page when workspace has outstanding report and no draft[/+] on Nov 4, 2025
  7. melvin-bot commented on Nov 4, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 4, 2025
  9. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  10. 7 remaining items

  11. melvin-bot commented on Nov 9, 2025

    @melvin-bot

    Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 10, 2025
  13. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  14. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  15. NJ-2020 commented on Nov 12, 2025

    @NJ-2020
    Contributor

    PR is ready

    cc: @aimane-chnaif

  16. NJ-2020 commented on Dec 2, 2025

    @NJ-2020
    Contributor

    Hi 👋 @JmillsExpensify, This one's ready for payment, it's already been a week since the production deploy, the automation seems failed, please when you get a chance. Many thanks

  17. JmillsExpensify commented on Dec 3, 2025

    @JmillsExpensify
    Contributor

    Payment summary:

  18. JmillsExpensify commented on Dec 3, 2025

    @JmillsExpensify
    Contributor

    All contributors paid out. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions