Skip to content

[Due for payment 2025-12-17] Remove Onyx.connect() for the key: ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE in src/libs/actions/Report.ts #73650

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/actions/Report.ts
  • Onyx Key: ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE
  • Reference: Line 303: ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @greg-schroeder

Activity

  1. self-assigned this
    on Oct 28, 2025
  2. tgolen commented on Oct 28, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2025
  4. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added
    ReviewingHas a PR in review
    and removed on Oct 28, 2025
  6. 29 remaining items

  7. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE` in `src/libs/actions/Report.ts`[/-] [+][Due for payment 2025-12-17] Remove `Onyx.connect()` for the key: `ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE` in `src/libs/actions/Report.ts`[/+] on Dec 10, 2025
  8. melvin-bot commented on Dec 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Dec 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.74-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-17. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Dec 10, 2025

    @melvin-bot

    @parasharrajat / @shubham1206agra @greg-schroeder The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@greg-schroeder)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. greg-schroeder commented on Dec 22, 2025

    @greg-schroeder
    Contributor

    Closing and verified this payment summary above

  13. parasharrajat commented on Mar 19, 2026

    @parasharrajat
    Member

    Payment requested as per #73650 (comment)

  14. twisterdotcom commented on Mar 23, 2026

    @twisterdotcom
    Contributor

    Confirming Payment Summary. @parasharrajat paid via New Expensify

  15. garrettmknight commented on Apr 2, 2026

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions