Skip to content

[$250] [Due for payment 2025-12-19] [Splits in NewDot] Add Split to the select menu when 1 expense is selected, editable and not the child of an existing Split expense #73669

Closed

Description

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason / @trjExpensify
Slack conversation (hyperlinked to channel name): migrate

Action Performed:

  1. Create an expense
  2. Select the checkbox next to the expense (this should work the same in the report view and the Reports page view)
  3. Click 1 selected

Expected Result:

Since you can split in the More menu of an editable, non-split transaction, you should see it in the 1 selected menu as well. There are a few additional pieces of context here:

  • Submitters and assigned approvers can split expenses that they can edit.
  • Admins can split expenses on Draft and Processing reports.
  • Non-editable expenses include pending Expensify Card expenses and Expensiworks expenses for all users.
  • Users should not see the Split option in the 1 selected menu for portions of expenses that have already been split.

Actual Result:

Split isn't an option in the 1 selected menu.

Workaround:

Users can still open the expense via RHP and split.

Platforms:

Select the officially supported platforms where the issue was reproduced:
ALL

Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022003945749544060829
  • Upwork Job ID: 2003945749544060829
  • Last Price Increase: 2025-12-31
Issue OwnerCurrent Issue Owner: @eh2077

Activity

  1. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO. Remember to draft any necessary HelpDot updates by following the instructions here.

  2. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  4. garrettmknight commented on Oct 28, 2025

    @garrettmknight
    ContributorAuthor

    @dubielzyk-expensify I think this one is pretty simple. Fig here, but:
    Reports page:

    Image

    Report view:

    Image
  5. dubielzyk-expensify commented on Oct 29, 2025

    @dubielzyk-expensify
    Contributor

    What do you need here sorry? 😅

    The green button should say 1 selected btw

  6. ZhenjaHorbach commented on Oct 30, 2025

    @ZhenjaHorbach
    Contributor

    @garrettmknight
    About Reports page
    Do we really need to add Split here?
    Since we don't have Merge in this menu also

    2025-10-30.14.38.40.mov
  7. 40 remaining items

  8. Corfliss commented on Dec 25, 2025

    @Corfliss

    Contributor details
    Your Expensify account email: work@corfliss.io
    Upwork Profile Link: https://www.upwork.com/freelancers/~0195762c2c093ab931

  9. melvin-bot commented on Dec 25, 2025

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  10. ZhenjaHorbach commented on Dec 25, 2025

    @ZhenjaHorbach
    Contributor

    Hello everyone, I got the issue from Upwork, checked the repo and the NewDot build, and concluded it can come from the usage of ReportSecondaryActionUtils that has isSplitAction() function

    Unless I am wrong, this is where I believed to be the starting problem to trace the issue. As there are some if checks to be done there, I suspect to check it first there

    So, if you don't mind:

    • I can check all of those if checks to make sure everything is working as intended
    • If that is not the real problem, I can trace to the usage of where isSplitAction() is used in the regarded context and implement fix
    • If everything that uses isSplitAction() traced and still has the same issue, I may discuss some potential solutions with the core team if needed

    This feature was already implemented a few weeks ago 😅
    And it will be closed soon

  11. Corfliss commented on Dec 25, 2025

    @Corfliss

    Ah, I see. No worries. Probably I have to ask if the issue is already implemented next time, as I have no clue except a few, but those still need clarification 😁

  12. melvin-bot commented on Dec 31, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  13. melvin-bot commented on Jan 1, 2026

    @melvin-bot

    @eh2077 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  14. eh2077 commented on Jan 5, 2026

    @eh2077
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA. This is new feature.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Na

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/584454

    Regression Test Proposal

    Precondition:

    • NA

    Test:

    1. Open App
    2. Create an expense in any Workspace
    3. Open Reports screen and select the checkbox next to the expense (this should work the same in the report view and the Reports page view)
    4. Click 1 selected
    5. Verify that:
    • Submitters and assigned approvers can split expenses that they can edit.
    • Admins can split expenses on Draft and Processing reports.
    • Non-editable expenses include pending Expensify Card expenses and Expensiworks expenses for all users.
    • Users should not see the Split option in the 1 selected menu for portions of expenses that have already been split.
    • Users should not see the Split option in the 2 or more selected menu

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-c22f-a6ac-49cc-2dee94021ea4
  15. eh2077 commented on Jan 5, 2026

    @eh2077
    Contributor

    @mallenexpensify Checklist done, thanks 🙇

  16. lydiabarclay commented on Jan 5, 2026

    @lydiabarclay
    Contributor

    Payment Summary

    Contributor: @ZhenjaHorbach due $250 via NewDot
    Contributor+: @eh2077 due $250 via NewDot

    ✅ Regression test filed

  17. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Jan 5, 2026
  18. JmillsExpensify commented on Jan 8, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @eh2077

  19. garrettmknight commented on Jan 14, 2026

    @garrettmknight
    ContributorAuthor

    $250 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions