Repository navigation
Description
Note
This is currently on hold for #72230
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: V9.2.39-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: retesting https://github.com/Expensify/Expensify/issues/528139
https://test-management.browserstack.com/projects/2219752/folder/13176670/test-cases/41237109
Email or phone of affected tester (no customers): Slottwo1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests
Action Performed:
1.Open the Expensify app.
2.Open any workspace chat.
3.Submit two expenses to it. (One of them, has to be distance expense)
4.Open the report of the just created expenses.
5.Tap on "More"
6.Delete the report
7.Return to LHN.
8.Note that the preview of the distance expense report, it now shows correctly.
9.Open Self DM.
10.Note that expenses are now displayed on that chat
11. Note distance receipt is displayed with empty space
12. Open the distance expense
Note that "Distance" field is displayed correctly,
Expected Result:
In "Rate" field, "Rate out of policy" error must be shown.
Actual Result:
In "Rate" field, "Rate out of policy" error is not shown.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6986635_1761640622926.Screenrecorder-2025-10-28-13-57-36-673.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021983335586114224619
- Upwork Job ID: 1983335586114224619
- Last Price Increase: 2025-10-29
- Automatic offers:
- FitseTLT | Contributor | 109291007
- truph01 | Reviewer | 109369818
- daledah | Contributor | 109369820
Issue Owner
Current Issue Owner: @francoisl
Activity
melvin-bot commentedon Oct 28, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Oct 28, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
In "Rate" field, "Rate out of policy" error is not shown.
What is the root cause of that problem?
We are just checking the workspace conditions here.
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 410 to 412 in 3c5bc03
What changes do you think we should make in order to solve the problem?
We should update the logic to use utils function
isUnreportedAndHasInvalidDistanceRateTransactionlike we did in transaction preview hereApp/src/libs/TransactionPreviewUtils.ts
Lines 260 to 262 in 3c5bc03
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 410 to 412 in 3c5bc03
Note: we can update the
isCustomUnitOutOfPolicyvariable hereApp/src/components/ReportActionItem/MoneyRequestView.tsx
Line 306 in 3c5bc03
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
hasib711 commentedon Oct 28, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
In "Rate" field, "Rate out of policy" error is not shown.
What is the root cause of that problem?
In the report list view, the rate error message appears below the code.
App/src/libs/TransactionPreviewUtils.ts
And on the detail page, the rate error message appears below the code.
[App/src/components/ReportActionItem/MoneyRequestView.tsx]
(
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 306 to 412 in 3c5bc03
But when we delete a report, we update the transaction’s violation.
What changes do you think we should make in order to solve the problem?
We can fix the problem of updating a transaction’s violation when deleting a report.
App/blob/main/src/libs/actions/Report.ts
What alternative solutions did you explore? (Optional)
FitseTLT commentedon Oct 28, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - In "Rate" field, "Rate out of policy" error is not shown.
What is the root cause of that problem?
We already implemented showing rate out of policy for unreported expenses here and we implemented it for MoneyRequestView too
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 306 in a60b73b
and the
ratewas calculated with theexpensePolicybut we updated the policy to usepolicyForMovingExpenseswhenisExpenseUnreportedin #72102App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 157 in a60b73b
so we are getting the
ratefrom the moved policy so the rate will still exist so the error will not showWhat changes do you think we should make in order to solve the problem?
We should get the rate without using
policyForMovingExpensesfor the case of isCustomUnitOutOfPolicyWhat alternative solutions did you explore? (Optional)
[-]Expense - In "Rate" field, "Rate out of policy" error is not shown.[/-][+][$250] Expense - In "Rate" field, "Rate out of policy" error is not shown.[/+]melvin-bot commentedon Oct 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021983335586114224619
melvin-bot commentedon Oct 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (
External)truph01 commentedon Oct 29, 2025
@hasib711 Your proposal would require backend changes to address the issue. However, we already have frontend logic in place to display the error, so your approach doesn't seem viable at this time.
@daledah @FitseTLT Both of your proposals follow a similar general approach: displaying an "out of policy" message below the rate field when the selected rate isn't defined in the expense policy. That said, there are some differences in the implementation details:
I'd like to ask @Expensify/design team to determine which behavior is more appropriate in this case. Once we get their input, we can proceed with the preferred approach.
FYI: The behavior in @FitseTLT’s proposal aligns with the expected outcome described in the test steps.
FitseTLT commentedon Oct 29, 2025
@truph01 I don't think we will need design input here this is a direct regression of test case linked to #65301 (comment) and the expected result clearly is depicted in the test steps
53 remaining items
[-][Hold #72230] [$250] Expense - In "Rate" field, "Rate out of policy" error is not shown.[/-][+][Due for payment 2026-08-14] [Hold #72230] [$250] Expense - In "Rate" field, "Rate out of policy" error is not shown.[/+]melvin-bot commentedon Aug 14, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)cristipaval commentedon Aug 14, 2026
Defering this to @mallenexpensify
melvin-bot commentedon Aug 14, 2026
Payment Summary
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 18, 2026
@MelvinBot who is due how much here? Link to PRs that were worked on and if mention if they were merged. @truph01 and @daledah, plz chime in with specifics too. I want to avoid going down an 🐰🕳
MelvinBot commentedon Aug 18, 2026
🤖 Short answer: No PR was ever merged for this issue. The bug was fixed as a side-effect of
FitseTLT's work on the separate (and separately-paid) hold issue #72230. So the auto-generated Payment Summary above (which liststruph01anddaledaheach at $250, both mislabeled "Reviewer") doesn't line up with what actually shipped here — I'd treat it as suspect before paying.PRs that touched this bug
FitseTLTFitseTLTFitseTLTdaledahdid not open a PR for this issue — the only recent action was verifying the bug is gone via video. The fix landed entirely throughFitseTLT's two merged PRs on #72230.What happened, briefly
truph01(C+) initially selectedFitseTLT's proposal, andFitseTLTopened fix - Expense - In "Rate" field, "Rate out of policy" error is not shown. #73890 to fix it.daledah's UI, and it was found to overlap with the Unreported-expenses project ([Due for payment 2026-04-14] [$250] [Unreported] Add distance rate to the distance expenses tracked in selfDM #72230). The issue was put on hold and fix - Expense - In "Rate" field, "Rate out of policy" error is not shown. #73890 was closed unmerged.FitseTLTfixes [Due for payment 2026-04-14] [$250] [Unreported] Add distance rate to the distance expenses tracked in selfDM #72230, thendaledahhandles any remaining UI here. But [Due for payment 2026-04-14] [$250] [Unreported] Add distance rate to the distance expenses tracked in selfDM #72230's fix (FitseTLT's Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM #74967 + Feat - [Unreported] Add distance rate to the distance expenses tracked in selfDM #84136) resolved this bug too, so no further code was needed here anddaledahnever had to open a PR.My read on who's due what (please sanity-check)
[$250]and its own payment flow —FitseTLTshould be paid there, not here.daledah— chosen proposal + verification, but no merged PR and no code on this issue.truph01— C+ reviewed proposals here, but never reviewed a merged PR for this issue.So this looks like a candidate to close with no payment on #73680 (fix + comp handled under #72230), unless BZ policy compensates the accepted proposal / C+ review time even when the fix ships via a linked issue. That's the judgment call — flagging it rather than asserting it.
truph01/daledah— please confirm: did either of you do billable work that landed outside whatFitseTLTmerged in #72230?mallenexpensify commentedon Aug 18, 2026
@daledah @truph01 can you help with $$$ stuff based on the above? Thx
daledah commentedon Aug 24, 2026
@mallenexpensify, since my proposal was accepted and I was assigned to this issue, but the bug can no longer be reproduced, I think i and @truph01 should receive 50% compensation here according to this rule.
mallenexpensify commentedon Aug 24, 2026
Payment Summary
Contributor: @daledah due $125 via NewDot
Contributor+: @truph01 due $125 via NewDot
From internal docs
quinthar commentedon Sep 2, 2026
Approved @daledah for $125
garrettmknight commentedon Sep 7, 2026
$125 approved for @truph01