Skip to content

[hold for payment 2026-01-28] [$250] Manual US personal bank account in NewDot #73693

Closed

Description

@joekaufmanexpensify

Coming from here, we need to add support for manual US personal bank accounts in NewDot. We support both Plaid and manual US personal bank accounts in OldDot. We support Plaid and manual for US business bank accounts in NewDot, but only Plaid for US personal bank accounts in NewDot now. We also need to begin collecting name, address, and phone number associated with the bank account in situations where it's not already on file. Final mocks:

Updated Plaid US personal bank account flow

Image Image

New manual US personal bank account flow

Image Image

Notes on changes

  • We'll add the "Streamline payments" page to the personal bank account flow when you select United States in the country selector. This is an existing page we use with business bank accounts. We'll change the copy on it to fit personal bank accounts.
  • Selecting "Login to your bank" will open the existing Plaid flow.
  • Selecting "Connect manually" will open a new page to collect account and routing for a personal bank account. This is the same as the page where we collect these for a manually connected business bank account. Some details:
    • I believe we do a backend verification of the account and routing submitted here in Expensify Classic. We should do the same here.
    • Both fields will be required.
  • After the new "What are your bank account details?" page in the manual flow OR the existing "Choose your bank account" page in the Plaid flow, we will ask for name, address, and phone number because we need to collect them to process certain payments. We already do this in Expensify Classic. Some details:
    • This applies to both the Plaid and manual flows.
    • These will be our standard name, address, and phone number components. All will be required
    • We'll fill Profile > Private with the name, address, phone number collected here, similar to how we do with other forms in the product.
    • We'll also store these details in the same place we do as the name, address, phone number collected when setting up a US personal bank account in Expensify Classic.
  • The user will then land on our standard confirmation page. Proceeding on the confirmation page will add the bank account and land the user on the existing success page.
  • If we already have the user's name, address, or phone number from Profile > Private on file, we'll skip the page(s) for whichever we already have, since the user can still edit them on the confirmation page, should they so choose.
  • If they edit their name, address, or phone number that's already on file in this flow, we'll update them in Profile > Private with the new details.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021986159927248666358
  • Upwork Job ID: 1986159927248666358
  • Last Price Increase: 2025-11-05
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Current assignee @joekaufmanexpensify is eligible for the NewFeature assigner, not assigning anyone new.

  2. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  4. joekaufmanexpensify commented on Oct 28, 2025

    @joekaufmanexpensify
    ContributorAuthor

    Marked as planning while we put some mocks together. Interested in your thoughts @dubielzyk-expensify

  5. dubielzyk-expensify commented on Oct 29, 2025

    @dubielzyk-expensify
    Contributor

    Thanks Joe! I'll try and get some mocks together tomorrow 👍

  6. joekaufmanexpensify commented on Oct 29, 2025

    @joekaufmanexpensify
    ContributorAuthor

    Thanks!

  7. dubielzyk-expensify commented on Oct 30, 2025

    @dubielzyk-expensify
    Contributor

    Didn't get to it today, but will try again tomorrow 👍

  8. dubielzyk-expensify commented on Oct 30, 2025

    @dubielzyk-expensify
    Contributor

    I found time in the evening under the couch. However, I don't understand much from the description, but I put together a few screens that maybe you can start with and tag me in some comments of what you need?

    Here's the Figma. If not, I'm online early tomorrow (your end of day) and can jump on to chat it out 👍 https://www.figma.com/design/vBXCQWjQExxcmZjFxbME4C/Add-Bank-Account-Flows--VBA--Wallet--Onfido-?node-id=3849-504

  9. 61 remaining items

  10. joekaufmanexpensify commented on Jan 22, 2026

    @joekaufmanexpensify
    ContributorAuthor

    Last PR went out to prod yesterday!

  11. joekaufmanexpensify commented on Jan 26, 2026

    @joekaufmanexpensify
    ContributorAuthor

    Only remaining steps are regression tests and then payment to @suneox

  12. suneox commented on Jan 28, 2026

    @suneox
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: New feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test: Manual US Personal Bank Account Flow

    • Test case 1: WITHOUT name/address/phone in Profile > Private
    • Test case 2: WITH existing name/address/phone in Profile > Private

    Test Case 1: WITHOUT existing personal info

    1. Navigate to Wallet page
    2. Click "Add new bank account"
    3. Select "United States" as country
    4. Click "Connect manually"
    5. Enter valid account number and routing number
    6. Enter "What are your bank account details?" input page
    7. Enter "Legal Name" input page
    8. Enter "Address" input page
    9. Enter "Phone Number" input page
    10. Confirm bank account details
    11. Verify: Bank account is added successfully
    12. Navigate to Profile > Private
    13. Verify: Name, address, and phone number are saved and match entered values

    Test Case 2: WITH existing personal info

    1. Navigate to Wallet page
    2. Click "Add new bank account"
    3. Select "United States" as country
    4. Click "Connect manually"
    5. Enter valid account number and routing number
    6. Click "Continue"
    7. Verify: Legal Name, Address, and Phone Number steps are SKIPPED
    8. Verify: User goes directly to confirmation page
    9. Verify: Confirmation page shows existing personal info from Profile > Private
    10. Click "Confirm" to add bank account
    11. Verify: Bank account is added successfully
    12. Navigate to Profile > Private
    13. Verify: Personal info in Profile > Private remains unchanged

    Do we agree 👍 or 👎

  13. joekaufmanexpensify commented on Jan 29, 2026

    @joekaufmanexpensify
    ContributorAuthor
  14. joekaufmanexpensify commented on Jan 29, 2026

    @joekaufmanexpensify
    ContributorAuthor

    Payment Summary

    • Contributor+: @suneox due $250 via NewDot
  15. joekaufmanexpensify commented on Jan 29, 2026

    @joekaufmanexpensify
    ContributorAuthor

    @suneox Please request payment at your earliest convenience. Closing as this is otherwise all set!

  16. trjExpensify commented on Feb 3, 2026

    @trjExpensify
    Contributor

    approved $250 for @suneox.

  17. nyomanjyotisa commented on Oct 29, 2026

    @nyomanjyotisa
    Member

    #104165 affected the personal-bank setup flow added in #75179: both address lines were joined with a newline. Fixed by #104823, which sends them separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions