You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-03-02] FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat #7382
Sure. But I would like to change this proposal a bit. I think we want to keep the variable dimensions thumbnail for attachments. But we should set a maximum value both for width and height.
For example, the screenshot on the issue shows a very long image which is disturbing in the middle of the chat. It is occupying a lot of space and does not look good.
I would like to highlight few issues. Please, correct me if I am wrong.
newMaxheight = this.props.windowHeight * {percentage we want}.
@parasharrajat When we use windowHeight for the calculation of thumbnail height. We also have to handle the case when user resize the window it should update it.
When we use very wide image. You are not constraining it's height while maintaining its aspect ratio. As a result, height is very small. It also produces another issue you can now see border. Same is the case where height >>> width.
Mine implementation is little complex but covers all edge cases and we can select the width and height range. I checked whatsapp and slack. They kind of doing the same thing. What do you think @rushatgabhane?
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat[/-][+][HOLD for payment 2022-03-02] FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat[/+]on Feb 23, 2022
Activity
MelvinBot commentedon Jan 25, 2022
Triggered auto assignment to @CortneyOfstad (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Jan 26, 2022
Triggered auto assignment to @puneetlath (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.puneetlath commentedon Jan 27, 2022
Hm, I'm not sure I agree with this proposal of fixed-size thumbnails. @parasharrajat can we take this to Slack and get some #design input?
parasharrajat commentedon Jan 27, 2022
Sure. But I would like to change this proposal a bit. I think we want to keep the variable dimensions thumbnail for attachments. But we should set a maximum value both for width and height.
For example, the screenshot on the issue shows a very long image which is disturbing in the middle of the chat. It is occupying a lot of space and does not look good.
17 remaining items
mdneyazahmad commentedon Jan 29, 2022
I would like to highlight few issues. Please, correct me if I am wrong.
@parasharrajat When we use windowHeight for the calculation of thumbnail height. We also have to handle the case when user resize the window it should update it.
My.Movie1.mp4
When we use very wide image. You are not constraining it's height while maintaining its aspect ratio. As a result, height is very small. It also produces another issue you can now see border. Same is the case where height >>> width.
Mine implementation is little complex but covers all edge cases and we can select the width and height range. I checked whatsapp and slack. They kind of doing the same thing. What do you think @rushatgabhane?
NikkiWines commentedon Jan 31, 2022
👍 for @parasharrajat's proposal - I think it fixes what we want without being too heavy of an implementation
parasharrajat commentedon Feb 4, 2022
cc: @jboniface
jboniface commentedon Feb 4, 2022
@parasharrajat hired for $500 since you also proposed it, will help me not forget!
parasharrajat commentedon Feb 9, 2022
PR is up, attaching screenshots and making it ready for review asap.
botify commentedon Feb 23, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-03-02. 🎊
[-]FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat[/-][+][HOLD for payment 2022-03-02] FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat[/+]jboniface commentedon Mar 2, 2022
paid