Skip to content

[HOLD for payment 2022-03-02] FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat #7382

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app
  2. Navigate to chat and send long attachment
  3. Preview thumbnails

Expected Result:

Show fixed-size thumbnails in the chat

Actual Result:

Variable dimensions thumbnails displayed

Context: Proposed #5162 (comment) , got confirmation here.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-01-24T233502 988
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642264358490100

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Jan 25, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jan 25, 2022
  3. MelvinBot commented on Jan 26, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  4. removed their assignment
    on Jan 26, 2022
  5. puneetlath commented on Jan 27, 2022

    @puneetlath
    Contributor

    Hm, I'm not sure I agree with this proposal of fixed-size thumbnails. @parasharrajat can we take this to Slack and get some #design input?

  6. parasharrajat commented on Jan 27, 2022

    @parasharrajat
    Member

    Sure. But I would like to change this proposal a bit. I think we want to keep the variable dimensions thumbnail for attachments. But we should set a maximum value both for width and height.

    For example, the screenshot on the issue shows a very long image which is disturbing in the middle of the chat. It is occupying a lot of space and does not look good.

  7. removed their assignment
    on Jan 27, 2022
  8. 17 remaining items

  9. removed their assignment
    on Jan 29, 2022
  10. mdneyazahmad commented on Jan 29, 2022

    @mdneyazahmad
    Contributor

    I would like to highlight few issues. Please, correct me if I am wrong.

    newMaxheight = this.props.windowHeight * {percentage we want}.

    @parasharrajat When we use windowHeight for the calculation of thumbnail height. We also have to handle the case when user resize the window it should update it.

    My.Movie1.mp4
    const aspectRatio = (height / width);
            if (thumbnailScreenHeight > thumbnailScreenWidth) {
                thumbnailScreenWidth = Math.round(thumbnailScreenHeight * (1 / aspectRatio));
            } else {
                thumbnailScreenHeight = Math.round(thumbnailScreenWidth * aspectRatio);
            }
    

    When we use very wide image. You are not constraining it's height while maintaining its aspect ratio. As a result, height is very small. It also produces another issue you can now see border. Same is the case where height >>> width.

    Screenshot 2022-01-29 at 10 58 34 PM

    Screenshot 2022-01-29 at 10 58 40 PM

    Mine implementation is little complex but covers all edge cases and we can select the width and height range. I checked whatsapp and slack. They kind of doing the same thing. What do you think @rushatgabhane?

  11. NikkiWines commented on Jan 31, 2022

    @NikkiWines
    Contributor

    👍 for @parasharrajat's proposal - I think it fixes what we want without being too heavy of an implementation

  12. parasharrajat commented on Feb 4, 2022

    @parasharrajat
    Member
  13. jboniface commented on Feb 4, 2022

    @jboniface

    @parasharrajat hired for $500 since you also proposed it, will help me not forget!

  14. parasharrajat commented on Feb 9, 2022

    @parasharrajat
    Member

    PR is up, attaching screenshots and making it ready for review asap.

  15. added
    ReviewingHas a PR in review
    and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 10, 2022
  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 23, 2022
  17. botify commented on Feb 23, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-03-02. 🎊

  18. changed the title [-]FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat[/-] [+][HOLD for payment 2022-03-02] FEATURE REQUEST: Show fixed-size thumbnails in the chat instead of variable dimensions - reported by @parasharrajat[/+] on Feb 23, 2022
  19. jboniface commented on Mar 2, 2022

    @jboniface

    paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions