You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-26] [$125] Travel - Icon on Book travel upgrade page is black #73865
Please re-state the problem that we are trying to solve in this issue.
Icon on Book travel upgrade page is black
What is the root cause of that problem?
Luggage is being loaded from Expensicons (regular icons) instead of Illustrations. It's currently loaded via useMemoizedLazyExpensifyIcons (which imports from the regularExpensicons icon set at assets/images/luggage.svg), but it should be loaded via useMemoizedLazyIllustrations (which imports from the simple illustrations at assets/images/simple-illustrations/simple-illustration__luggage.svg).
What changes do you think we should make in order to solve the problem?
We should move the Luggage to illustrations. Moving 'Luggage' from the useMemoizedLazyExpensifyIcons array to the useMemoizedLazyIllustrations will fix the issue.
📣 @samarroy84! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Oct 30, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Nodebrute commentedon Oct 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Icon on Book travel upgrade page is black
What is the root cause of that problem?
Luggage is being loaded from Expensicons (regular icons) instead of Illustrations. It's currently loaded via
useMemoizedLazyExpensifyIcons(which imports from the regularExpensicons icon set at assets/images/luggage.svg), but it should be loaded viauseMemoizedLazyIllustrations(which imports from the simple illustrations at assets/images/simple-illustrations/simple-illustration__luggage.svg).App/src/pages/workspace/upgrade/UpgradeIntro.tsx
Line 61 in d3a1ef2
What changes do you think we should make in order to solve the problem?
We should move the
Luggagetoillustrations. Moving 'Luggage' from theuseMemoizedLazyExpensifyIconsarray to theuseMemoizedLazyIllustrationswill fix the issue.App/src/pages/workspace/upgrade/UpgradeIntro.tsx
Line 60 in d3a1ef2
What alternative solutions did you explore? (Optional)
samarroy84 commentedon Oct 30, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-04 06:18:04 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Travel - Icon on Book travel upgrade page is black
What is the root cause of that problem?
Luggage is loaded from ExpensIcons, not Illustrations
App/src/pages/workspace/upgrade/UpgradeIntro.tsx
Lines 60 to 61 in d3a1ef2
What changes do you think we should make in order to solve the problem?
App/src/components/Icon/chunks/illustrations.chunk.ts
Line 81 in d3a1ef2
(We recently fixed similar bug in #72576)
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Oct 30, 2025
📣 @samarroy84! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
mkzie2 commentedon Oct 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Icon on Book travel upgrade page is black
What is the root cause of that problem?
In here
App/src/pages/workspace/upgrade/UpgradeIntro.tsx
Line 61 in 3ee4041
App/src/components/Icon/chunks/expensify-icons.chunk.ts
Line 135 in 3ee4041
We use simple, black-filled luggage icon.
And since the
typeused isavatarApp/src/pages/workspace/upgrade/UpgradeIntro.tsx
Line 114 in 3ee4041
The fill style will be undefined
App/src/components/Avatar.tsx
Line 131 in 3ee4041
What changes do you think we should make in order to solve the problem?
We have two options:
iconSuccessFillfor the iconApp/src/pages/workspace/upgrade/UpgradeIntro.tsx
Lines 112 to 115 in 3ee4041
This change will not affect other Illustrations, such as QBD, Netsuite, etc.
simple-illustration__luggageillustration, add it toIllustratuionsand include hereApp/src/pages/workspace/upgrade/UpgradeIntro.tsx
Lines 60 to 61 in 3ee4041
Result with two options:
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Nov 3, 2025
Triggered auto assignment to @dubielzyk-expensify (
Design), see these Stack Overflow questions for more details.RachCHopkins commentedon Nov 3, 2025
Hey @Expensify/design just getting a little input here - what should this look like?
dubielzyk-expensify commentedon Nov 3, 2025
It should look like option 2 above
33 remaining items
melvin-bot commentedon Nov 19, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 19, 2025
@dukenv0307 @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
RachCHopkins commentedon Nov 26, 2025
@dukenv0307 can you do the checklist please?
dukenv0307 commentedon Nov 27, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/72367/files#r2566977995
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/572512
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
dukenv0307 commentedon Nov 27, 2025
@RachCHopkins I completed! Thank you
RachCHopkins commentedon Nov 27, 2025
Payment Summary:
Upwork job here
🟢 to request payment
RachCHopkins commentedon Nov 27, 2025
Upwork job closed.
quinthar commentedon Dec 19, 2025
Approved $125 to @dukenv0307
trjExpensify commentedon Jan 5, 2026
Approved $125 for @Nodebrute