Skip to content

[Due for payment 2025-11-26] [$125] Travel - Icon on Book travel upgrade page is black #73865

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1592/folder/13177079/41237920/983216729?sort=%2Bidentifier
Email or phone of affected tester (no customers): applausetester+301001kh@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Log in with Expensifail account
  • Account has no workspace
  1. Go to staging.new.expensify.com
  2. Open FAB > Book travel
  3. Click Book travel

Expected Result:

Icon on Book travel upgrade page will show the original icon

Actual Result:

Icon on Book travel upgrade page is black

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6989262_1761836275329.16.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021985541997042353008
  • Upwork Job ID: 1985541997042353008
  • Last Price Increase: 2025-11-06
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 30, 2025
  2. melvin-bot commented on Oct 30, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Nodebrute commented on Oct 30, 2025

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Icon on Book travel upgrade page is black

    What is the root cause of that problem?

    Luggage is being loaded from Expensicons (regular icons) instead of Illustrations. It's currently loaded via useMemoizedLazyExpensifyIcons (which imports from the regularExpensicons icon set at assets/images/luggage.svg), but it should be loaded via useMemoizedLazyIllustrations (which imports from the simple illustrations at assets/images/simple-illustrations/simple-illustration__luggage.svg).

    const illustrationIcons = useMemoizedLazyExpensifyIcons(['IntacctSquare', 'NetSuiteSquare', 'QBDSquare', 'AdvancedApprovalsSquare', 'Luggage', 'Unlock']);

    What changes do you think we should make in order to solve the problem?

    We should move the Luggage to illustrations. Moving 'Luggage' from the useMemoizedLazyExpensifyIcons array to the useMemoizedLazyIllustrations will fix the issue.

    const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Tag', 'Coins', 'Rules', 'CompanyCard', 'PerDiem', 'ReportReceipt', 'CarIce', 'Pencil']);

    What alternative solutions did you explore? (Optional)

  4. samarroy84 commented on Oct 30, 2025

    @samarroy84
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-11-04 06:18:04 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Travel - Icon on Book travel upgrade page is black

    What is the root cause of that problem?

    Luggage is loaded from ExpensIcons, not Illustrations

    const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Tag', 'Coins', 'Rules', 'CompanyCard', 'PerDiem', 'ReportReceipt', 'CarIce', 'Pencil']);
    const illustrationIcons = useMemoizedLazyExpensifyIcons(['IntacctSquare', 'NetSuiteSquare', 'QBDSquare', 'AdvancedApprovalsSquare', 'Luggage', 'Unlock']);

    What changes do you think we should make in order to solve the problem?

    (We recently fixed similar bug in #72576)

    What alternative solutions did you explore? (Optional)

  5. melvin-bot commented on Oct 30, 2025

    @melvin-bot

    📣 @samarroy84! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  6. mkzie2 commented on Oct 30, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Icon on Book travel upgrade page is black

    What is the root cause of that problem?

    In here

    const illustrationIcons = useMemoizedLazyExpensifyIcons(['IntacctSquare', 'NetSuiteSquare', 'QBDSquare', 'AdvancedApprovalsSquare', 'Luggage', 'Unlock']);

    import Luggage from '@assets/images/luggage.svg';

    We use simple, black-filled luggage icon.

    And since the type used is avatar

    type={CONST.ICON_TYPE_AVATAR}

    The fill style will be undefined

    fill={imageError ? (iconColors?.fill ?? theme.offline) : (iconColors?.fill ?? fill)}

    What changes do you think we should make in order to solve the problem?

    We have two options:

    1. Use iconSuccessFill for the icon
    fill={theme.iconSuccessFill}

    <Avatar
    source={iconSrc}
    type={CONST.ICON_TYPE_AVATAR}
    />

    This change will not affect other Illustrations, such as QBD, Netsuite, etc.

    1. Use simple-illustration__luggage illustration, add it to Illustratuions and include here
    const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Tag', 'Coins', 'Rules', 'CompanyCard', 'PerDiem', 'ReportReceipt', 'CarIce', 'Pencil', 'Luggage']); // add 'Luggage'
    const illustrationIcons = useMemoizedLazyExpensifyIcons(['IntacctSquare', 'NetSuiteSquare', 'QBDSquare', 'AdvancedApprovalsSquare', 'Unlock']); // remove 'Luggage'

    const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Tag', 'Coins', 'Rules', 'CompanyCard', 'PerDiem', 'ReportReceipt', 'CarIce', 'Pencil']);
    const illustrationIcons = useMemoizedLazyExpensifyIcons(['IntacctSquare', 'NetSuiteSquare', 'QBDSquare', 'AdvancedApprovalsSquare', 'Luggage', 'Unlock']);

    Result with two options:

    Option 1 Option 2
    Image Image

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

  8. RachCHopkins commented on Nov 3, 2025

    @RachCHopkins
    Contributor

    Hey @Expensify/design just getting a little input here - what should this look like?

  9. dubielzyk-expensify commented on Nov 3, 2025

    @dubielzyk-expensify
    Contributor

    It should look like option 2 above

  10. 33 remaining items

  11. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Nodebrute requires payment through NewDot Manual Requests
    • @dukenv0307 requires payment through NewDot Manual Requests
  12. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    @dukenv0307 @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. RachCHopkins commented on Nov 26, 2025

    @RachCHopkins
    Contributor

    @dukenv0307 can you do the checklist please?

  14. dukenv0307 commented on Nov 27, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/72367/files#r2566977995

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    • Account has no workspace

    Test:

    1. Open FAB > Book travel
    2. Click Book travel
    3. Verify the Luggage is shown correctly

    Do we agree 👍 or 👎

  15. dukenv0307 commented on Nov 27, 2025

    @dukenv0307
    Contributor

    @RachCHopkins I completed! Thank you

  16. RachCHopkins commented on Nov 27, 2025

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @Nodebrute to be paid $125 via Newdot
    • Contributor+: @dukenv0307 to be paid $125 via Newdot

    Upwork job here

    🟢 to request payment

  17. RachCHopkins commented on Nov 27, 2025

    @RachCHopkins
    Contributor

    Upwork job closed.

  18. quinthar commented on Dec 19, 2025

    @quinthar
    Contributor

    Approved $125 to @dukenv0307

  19. trjExpensify commented on Jan 5, 2026

    @trjExpensify
    Contributor

    Approved $125 for @Nodebrute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions