Skip to content

[Due for payment 2025-12-12] [$125] [To-do counters] Deprecate SearchReport #73955

Closed

Description

@luacmartins

Release 1: Align Snapshot and Live Onyx data types
We'll begin by aligning the snapshot and live Onyx data types. Each of the keys below will be addressed in individual issues that will be worked on in parallel by external contributors. Here's the plan to deprecate each key in Search* types in favor of those in onyx/types/

Deprecate SearchReport

  1. [Note] This issue is held on all the SearchReport issues above
  2. In App, remove SearchReport
  3. Update all broken references to the Report type

Parent Issue: https://github.com/Expensify/Expensify/issues/563552

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021991637179832771198
  • Upwork Job ID: 1991637179832771198
  • Last Price Increase: 2025-11-20
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. self-assigned this
    on Oct 31, 2025
  2. PiyushChandra17 commented on Nov 4, 2025

    @PiyushChandra17
    Contributor

    I would like to work on this, the solution is already detailed in OP

  3. samranahm commented on Nov 5, 2025

    @samranahm
    Contributor

    Deprecated SearchReport here #74144

    @luacmartins Should I open a follow-up to change SearchReport with Report, since we are getting the lint failure #74121

  4. luacmartins commented on Nov 5, 2025

    @luacmartins
    ContributorAuthor

    @samranahm we're deprecating the SearchReport across many issues since there are several mismatched keys between those types. We already have engineers assigned to this, so please don't create any follow-ups.

  5. s77rt commented on Nov 5, 2025

    @s77rt
    Member

    Note: Make sure all relevant eslint-disable-next-line @typescript-eslint/no-deprecated comments are removed too. I have added a bunch of theses ignore comments.

  6. 27 remaining items

  7. melvin-bot commented on Dec 5, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Dec 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.72-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-12. 🎊

    For reference, here are some details about the assignees on this issue:

  9. ZhenjaHorbach commented on Dec 11, 2025

    @ZhenjaHorbach
    Contributor

    @luacmartins
    Could you please assign someone from the BZ team?
    And we can close this issue after payment!

  10. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 11, 2025
  11. melvin-bot commented on Dec 11, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  12. trjExpensify commented on Dec 12, 2025

    @trjExpensify
    Contributor

    Part of a project, so tests and such will be added centrally.

    Payment summary as follows:

    Go ahead and request!

  13. ZhenjaHorbach commented on Dec 12, 2025

    @ZhenjaHorbach
    Contributor

    Requested in ND!

  14. JmillsExpensify commented on Dec 15, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions