Skip to content

[Due for payment 2026-01-15] [To-do counters] Deprecate SearchTransaction & Cleanup #73974

Closed

Description

@luacmartins

Release 1: Align Snapshot and Live Onyx data types
We'll begin by aligning the snapshot and live Onyx data types. Each of the keys below will be addressed in individual issues that will be worked on in parallel by external contributors. Here's the plan to deprecate each key in Search* types in favor of those in onyx/types/

Deprecate SearchTransaction & Cleanup

  1. In App, remove SearchTransaction
  2. Bump the minimum App version to the version of the last SearchTransaction deprecation PR
  3. In Auth, remove the following instances:
    1. accountID in buildTransactionResponse and from the query
    2. managerID in buildTransactionResponse and from the query
    3. reportType from the response in buildTransactionResponse
    4. policyID from the response in buildTransactionResponse
    5. hasViolation from the response in buildTransactionResponse
    6. transactionThreadReportID from the response in buildTransactionResponse
    7. transactionThreadReportID from the response in buildTransactionResponse
    8. transactionThreadReportID from the response in buildTransactionResponse
    9. canHold from the response in buildTransactionResponse
    10. canUnhold from the response in buildTransactionResponse
    11. canDelete from the response in buildTransactionResponse
    12. isFromOneTransactionReport from the response in buildTransactionResponse

Parent Issue: https://github.com/Expensify/Expensify/issues/563552

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. self-assigned this
    on Oct 31, 2025
  2. hasib711 commented on Nov 4, 2025

    @hasib711

    I would like to work on this issue, if it is open for external contributors.

  3. PiyushChandra17 commented on Nov 4, 2025

    @PiyushChandra17
    Contributor

    I would like to work on this, the solution is already detailed in OP

  4. luacmartins commented on Nov 14, 2025

    @luacmartins
    ContributorAuthor

    Future release

  5. luacmartins commented on Dec 2, 2025

    @luacmartins
    ContributorAuthor

    Future release

  6. 16 remaining items

  7. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.95-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-15. 🎊

    For reference, here are some details about the assignees on this issue:

    • @DylanDylann requires payment through NewDot Manual Requests
  9. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 15, 2026
  10. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  11. luacmartins commented on Jan 15, 2026

    @luacmartins
    ContributorAuthor

    Pending payment to @shubham1206agra for PR review. @DylanDylann will be paid separately for the project.

  12. CortneyOfstad commented on Jan 16, 2026

    @CortneyOfstad
    Contributor

    Payment Summary

    @shubham1206agra – to be paid $250 via NewDot
    @DylanDylann — to be paid separately as part of the on-going project

  13. garrettmknight commented on Apr 2, 2026

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions