Skip to content

[Due for payment 2025-11-11] Expense - Report list is empty when account has no default workspace and no open report #73989

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): ndjnosidjoijsdj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has two non-default workspaces.
  • Account has no expense report (new account).
  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense.
  4. Open the expense thread.
  5. Click Report.

Expected Result:

Create report button will show up.

Actual Result:

Report list is empty.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 31, 2025
  2. melvin-bot commented on Oct 31, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 31, 2025

    @melvin-bot

    Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 31, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 31, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Nodebrute commented on Oct 31, 2025

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Report list is empty when account has no default workspace and no open report

    What is the root cause of that problem?

    In BaseSelectionList.tsx, we have a function renderListEmptyContent() that checks if (showListEmptyContent) before rendering the empty content.

    const renderListEmptyContent = () => {
    if (showLoadingPlaceholder) {
    return <OptionsListSkeletonView shouldStyleAsTable={shouldUseUserSkeletonView} />;
    }
    if (showListEmptyContent) {
    return listEmptyContent;
    }
    };

    If we don't pass this prop, it's undefined. Here we have listEmptyContent that is supposed to be rendered when the list is empty but we also need to pass showListEmptyContent to true when the list is empty.
    listEmptyContent={createReportOption}

    What changes do you think we should make in order to solve the problem?

    We should pass another prop here showListEmptyContent={!!createReportOption}

    listEmptyContent={createReportOption}

    What alternative solutions did you explore? (Optional)

    Alternatively, we can also pass it as showListEmptyContent={true}

    Alternate solution 2
    Or we can set showListEmptyContent=true and test all instances of it

  7. parasharrajat commented on Oct 31, 2025

    @parasharrajat
    Member

    Probably caused by this #73433

  8. mountiny commented on Oct 31, 2025

    @mountiny
    Contributor

    @GCyganek @zfurtak @dukenv0307 can you please take a look?

  9. 1 remaining item

  10. mountiny commented on Nov 2, 2025

    @mountiny
    Contributor

    Created a revert here #74058

  11. GCyganek commented on Nov 3, 2025

    @GCyganek
    Contributor

    @mountiny created a fix here in case we want to skip reverting the PR with the migration to the new SelectionList

  12. luacmartins commented on Nov 3, 2025

    @luacmartins
    Contributor

    This is fixed on staging.

    Screen.Recording.2025-11-03.at.9.49.35.AM.mov
  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 4, 2025
  14. changed the title [-]Expense - Report list is empty when account has no default workspace and no open report[/-] [+][Due for payment 2025-11-11] Expense - Report list is empty when account has no default workspace and no open report[/+] on Nov 4, 2025
  15. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @GCyganek does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  17. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    @dukenv0307 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions