You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-11] Expense - Report list is empty when account has no default workspace and no open report #73989
Version Number: 9.2.42-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory Email or phone of affected tester (no customers):ndjnosidjoijsdj@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
If we don't pass this prop, it's undefined. Here we have listEmptyContent that is supposed to be rendered when the list is empty but we also need to pass showListEmptyContent to true when the list is empty.
changed the title [-]Expense - Report list is empty when account has no default workspace and no open report[/-][+][Due for payment 2025-11-11] Expense - Report list is empty when account has no default workspace and no open report[/+]on Nov 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Oct 31, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 31, 2025
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 31, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 31, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Nodebrute commentedon Oct 31, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report list is empty when account has no default workspace and no open report
What is the root cause of that problem?
In
BaseSelectionList.tsx,we have a functionrenderListEmptyContent()that checks if (showListEmptyContent) before rendering the empty content.App/src/components/SelectionList/BaseSelectionList.tsx
Lines 332 to 339 in 1e140e5
If we don't pass this prop, it's undefined. Here we have
listEmptyContentthat is supposed to be rendered when the list is empty but we also need to passshowListEmptyContentto true when the list is empty.App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx
Line 273 in 1e140e5
What changes do you think we should make in order to solve the problem?
We should pass another prop here
showListEmptyContent={!!createReportOption}App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx
Line 273 in 1e140e5
What alternative solutions did you explore? (Optional)
Alternatively, we can also pass it as
showListEmptyContent={true}Alternate solution 2
Or we can set
showListEmptyContent=trueand test all instances of itApp/src/components/SelectionList/BaseSelectionList.tsx
Line 64 in 1e140e5
parasharrajat commentedon Oct 31, 2025
Probably caused by this #73433
mountiny commentedon Oct 31, 2025
@GCyganek @zfurtak @dukenv0307 can you please take a look?
1 remaining item
mountiny commentedon Nov 2, 2025
Created a revert here #74058
GCyganek commentedon Nov 3, 2025
@mountiny created a fix here in case we want to skip reverting the PR with the migration to the new SelectionList
luacmartins commentedon Nov 3, 2025
This is fixed on staging.
Screen.Recording.2025-11-03.at.9.49.35.AM.mov
[-]Expense - Report list is empty when account has no default workspace and no open report[/-][+][Due for payment 2025-11-11] Expense - Report list is empty when account has no default workspace and no open report[/+]melvin-bot commentedon Nov 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
showListEmptyContenttotrueby default #74078If no regressions arise, payment will be issued on 2025-11-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 4, 2025
@dukenv0307 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]