You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-17] [$250] Report status badge translation is not changing until page refresh #74054
Version Number: 9.2.42-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@mukhrr Slack conversation (hyperlinked to channel name): #Open Source
Action Performed:
[user A] Go to IOU chat
[user A] Create an expense
[user B] Mark as Paid that expense
[user B] Go to Preference and change language
[user B] Back to paid expense chat
Expected Result:
You see Paid status badge in latest changed language
Actual Result:
You see Paid status in preview in previous language
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceREC-20251102070510.mp4Recording.1855.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Report status badge translation is not changing until page refresh
What is the root cause of that problem?
We get the badge text from getReportStatusTranslation and color from getReportStatusColorStyle and use useMemo to memorize it, but as soon we change the local the reportStatus does not update leading with local leading to this bug
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Report status badge translation is not changing until page refresh[/-][+][Due for payment 2025-11-17] [$250] Report status badge translation is not changing until page refresh[/+]on Nov 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.47-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193@trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
[user A] Go to IOU chat
[user A] Create an expense
[user B] Mark as Paid that expense
[user B] Go to Preference and change language
[user B] Back to paid expense chat
[user B] Verify that the status badge is translated to the selected language
Activity
melvin-bot commentedon Nov 2, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 2, 2025
Triggered auto assignment to @mollfpr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 2, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 2, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samarroy84 commentedon Nov 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report status badge translation is not changing until page refresh
What is the root cause of that problem?
We’re memoizing reportStatus and reportStatusColorStyle here:
App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 343 to 351 in 515655a
But
translateis not added to dependencies listWhat changes do you think we should make in order to solve the problem?
translatetogetReportStatusTranslationas parametertranslateLocalwithtranslateApp/src/libs/ReportUtils.ts
Lines 12251 to 12263 in 515655a
What alternative solutions did you explore? (Optional)
samranahm commentedon Nov 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report status badge translation is not changing until page refresh
What is the root cause of that problem?
We get the badge text from
getReportStatusTranslationand color fromgetReportStatusColorStyleand useuseMemoto memorize it, but as soon we change the local thereportStatusdoes not update leading with local leading to this bugApp/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 343 to 346 in 515655a
What changes do you think we should make in order to solve the problem?
We should add the
translatedep in deps array ofreportStatusonly and it's not required forreportStatusColorStylesince it will remain same.Like we have through out in our App
App/src/components/DatePicker/CalendarPicker/YearPickerModal.tsx
Line 40 in 515655a
App/src/components/QRShare/QRShareWithDownload/index.native.tsx
Line 22 in 515655a
App/src/components/SubStepForms/DateOfBirthStep.tsx
Line 75 in 515655a
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
24 remaining items
[-][$250] Report status badge translation is not changing until page refresh[/-][+][Due for payment 2025-11-17] [$250] Report status badge translation is not changing until page refresh[/+]melvin-bot commentedon Nov 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.47-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 10, 2025
@hungvu193 @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
hungvu193 commentedon Nov 14, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/66260/files#r2526919788
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
trjExpensify commentedon Nov 17, 2025
I don't think we need a standalone regression test for this one, so I'll forgo adding it.
Payment summary as follows:
All done, closing. Thanks!
garrettmknight commentedon Nov 21, 2025
$250 approved for @hungvu193