You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-12] [$125] Fix flakey test for timezone #74065
🐛 Error Message:
failure: Process completed with exit code 1.
⚠️Action Required⚠️:
🛠️ A recent merge appears to have caused a failure in the job named test / test (job 4).
This issue has been automatically created and labeled with Workflow Failure for investigation.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.44-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jjcoffee@twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A since it's a test itself!
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
@trjExpensify - as I, @twisterdotcom am already assigned to this issue as BZ, could you also check this box to confirm the Payment Summary above. Note that no single individual can both confirm the payment amounts and approve the payment itself due to SOX.
Activity
nkdengineer commentedon Nov 3, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
isSameDaywill convert the date to the local system timezone or UTC timezone before comparing. With GH action, the timezone is UTCApp/tests/unit/DateUtilsTest.ts
Line 178 in 441be87
App/src/libs/DateUtils.ts
Line 112 in 441be87
While our test timezone is
America/Los_Angeles. Then the test is flaky ifdateandcurrentDateInTimeZoneare not the same day in the UTC timezone.App/tests/unit/DateUtilsTest.ts
Line 52 in 441be87
What changes do you think we should make in order to solve the problem?
Change the test timezone to any UTC timezone
Atlantic/ReykjavikApp/tests/unit/DateUtilsTest.ts
Line 52 in 441be87
What alternative solutions did you explore? (Optional)
Install
@date-fns/tz. Ref: https://github.com/date-fns/tz?tab=readme-ov-file#tzAdd
inoption as the timezone parameter. Fix the same forisYesterday/isTomorrowfunctionApp/src/libs/DateUtils.ts
Line 112 in 441be87
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Investigate workflow job failing on main: test / test (job 4)[/-][+][$125] Fix flakey test for timezone[/+]melvin-bot commentedon Nov 3, 2025
melvin-bot commentedon Nov 3, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lakchote commentedon Nov 3, 2025
Test is flakey and passed on the 2nd try.
Assigning you @nkdengineer, your proposal LGTM.
nkdengineer commentedon Nov 3, 2025
@lakchote What solution do you like?
8 remaining items
[-][$125] Fix flakey test for timezone[/-][+][Due for payment 2025-11-12] [$125] Fix flakey test for timezone[/+]melvin-bot commentedon Nov 5, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.44-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 5, 2025
@jjcoffee @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jjcoffee commentedon Nov 11, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/27838/files#r2513273058
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A since it's a test itself!
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
twisterdotcom commentedon Nov 12, 2025
Payment Summary:
trjExpensify commentedon Nov 13, 2025
approved $125 for @jjcoffee.
nkdengineer commentedon Dec 29, 2025
@twisterdotcom I get paid via NewDot now, please update the payment summary. Thanks!
twisterdotcom commentedon Jan 12, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-0e8c-a716-81c2-1a44418fc794trjExpensify commentedon Jan 19, 2026
Confirming payment summary here is correct.