Skip to content

Workflow - The pop-up display the wrong sentence and button when approver leave WS #74072

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.42-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #58345
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Pixel 7 Pro /Android 16
App Component: Workspace Settings

Action Performed:

Preconditions:
Member A is an Admin and invites Member B to the workspace.
Member B is an approver in the workflow.
Member A creates an expense and submits it to Member B.
Steps:

  1. Log in as Member B and go to Settings > Workspaces.
  2. Click the three-dot menu next to the workspace.
  3. Select "Leave".

Expected Result:

Verify that a modal is displayed with the following template:
Leave workspace
Please approve any outstanding expense reports submitted to you before leaving the workspace.

[Got it] <--- Green button

Actual Result:

The modal is displayed:
Leave workspace
If you leave this workspace, you'll be replaced in the approval workflow by [workspaceOwner], the workspace owner.

[Leave workspace] <--- red button
[Cancel]

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 3, 2025
  2. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 3, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. shubham1206agra commented on Nov 3, 2025

    @shubham1206agra
    Contributor

    @jponikarchuk This is working as expected. We don't show any specific modal for processing report case.

  7. MonilBhavsar commented on Nov 3, 2025

    @MonilBhavsar
    Contributor

    Right, we agreed to allow user to leave and not check for outstanding reports on frontend, as we won't have all reports in Onyx DB cc @trjExpensify

  8. 6 remaining items

  9. MonilBhavsar commented on Nov 3, 2025

    @MonilBhavsar
    Contributor

    Good point. Not sure if the user is preferred exporter. Will ask QA to confirm

  10. MonilBhavsar commented on Nov 3, 2025

    @MonilBhavsar
    Contributor
  11. IuliiaHerets commented on Nov 3, 2025

    @IuliiaHerets

    @MonilBhavsar The pop-up displays the wrong message and button when an approver (member) attempts to leave the Workspace with submitted expense.

    Image
    reproduce.mp4
  12. trjExpensify commented on Nov 3, 2025

    @trjExpensify
    Contributor

    What happens next? I take it this is where we display the RBR in-line about not being allowed to leave with outstanding processing reports thereafter, right?

  13. IuliiaHerets commented on Nov 3, 2025

    @IuliiaHerets

    @trjExpensify, when the red button was clicked, an error was displayed, like in this KI

    Video_2025-11-03_204829.1.mp4
  14. huult commented on Nov 3, 2025

    @huult
    Contributor

    @IuliiaHerets Could you share the request ID for the leaveWorkspace API so @MonilBhavsar can debug this from the backend side?”

  15. IuliiaHerets commented on Nov 3, 2025

    @IuliiaHerets

    @huult F3345F1B5F40F600

  16. MonilBhavsar commented on Nov 3, 2025

    @MonilBhavsar
    Contributor

    Oh right, this then is equivalent to #74003 where we don't automatically update approver
    So not a blocker as it needs to be fixed from backend.

  17. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 3, 2025
  18. trjExpensify commented on Nov 4, 2025

    @trjExpensify
    Contributor

    Shall we close it then, as it's effectively a dupe?

  19. MonilBhavsar commented on Nov 4, 2025

    @MonilBhavsar
    Contributor

    yep 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions