You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workflow - The pop-up display the wrong sentence and button when approver leave WS #74072
Version Number: v9.2.42-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#58345 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Pixel 7 Pro /Android 16 App Component: Workspace Settings
Action Performed:
Preconditions:
Member A is an Admin and invites Member B to the workspace.
Member B is an approver in the workflow.
Member A creates an expense and submits it to Member B.
Steps:
Log in as Member B and go to Settings > Workspaces.
Click the three-dot menu next to the workspace.
Select "Leave".
Expected Result:
Verify that a modal is displayed with the following template:
Leave workspace
Please approve any outstanding expense reports submitted to you before leaving the workspace.
[Got it] <--- Green button
Actual Result:
The modal is displayed:
Leave workspace
If you leave this workspace, you'll be replaced in the approval workflow by [workspaceOwner], the workspace owner.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What happens next? I take it this is where we display the RBR in-line about not being allowed to leave with outstanding processing reports thereafter, right?
Activity
melvin-bot commentedon Nov 3, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 3, 2025
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 3, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 3, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
shubham1206agra commentedon Nov 3, 2025
@jponikarchuk This is working as expected. We don't show any specific modal for processing report case.
MonilBhavsar commentedon Nov 3, 2025
Right, we agreed to allow user to leave and not check for outstanding reports on frontend, as we won't have all reports in Onyx DB cc @trjExpensify
6 remaining items
MonilBhavsar commentedon Nov 3, 2025
Good point. Not sure if the user is preferred exporter. Will ask QA to confirm
MonilBhavsar commentedon Nov 3, 2025
Asked here https://expensify.slack.com/archives/C9YU7BX5M/p1762169620736719
IuliiaHerets commentedon Nov 3, 2025
@MonilBhavsar The pop-up displays the wrong message and button when an approver (member) attempts to leave the Workspace with submitted expense.
reproduce.mp4
trjExpensify commentedon Nov 3, 2025
What happens next? I take it this is where we display the RBR in-line about not being allowed to leave with outstanding processing reports thereafter, right?
IuliiaHerets commentedon Nov 3, 2025
@trjExpensify, when the red button was clicked, an error was displayed, like in this KI
Video_2025-11-03_204829.1.mp4
huult commentedon Nov 3, 2025
@IuliiaHerets Could you share the request ID for the leaveWorkspace API so @MonilBhavsar can debug this from the backend side?”
IuliiaHerets commentedon Nov 3, 2025
@huult F3345F1B5F40F600
MonilBhavsar commentedon Nov 3, 2025
Oh right, this then is equivalent to #74003 where we don't automatically update approver
So not a blocker as it needs to be fixed from backend.
trjExpensify commentedon Nov 4, 2025
Shall we close it then, as it's effectively a dupe?
MonilBhavsar commentedon Nov 4, 2025
yep 👍