Skip to content

[Due for payment 2025-12-03] [$250] LHN - The last author doesn't display in the comment #74080

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #73500
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10/Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:
Invite a member to the workspace

  1. As a member, open/draft an expense to the workspace chat
  2. Member opens expense chat and verifies the LHN text is "This chat is with Admin," no last actor
  3. Admin comments on the expense

Expected Result:

Submitter verifies that the alternate text in LHN has the Admin name as the last author "Admin: comment"

Actual Result:

LHN only displays the message doesn't display the Admin author

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021992994573540172414
  • Upwork Job ID: 1992994573540172414
  • Last Price Increase: 2025-11-24
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 3, 2025
  2. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Nov 3, 2025

    @samranahm
    Contributor

    It's already been discussed with the internal engineering team, this is expected behavior.

    cc: @dangrous

  4. dangrous commented on Nov 3, 2025

    @dangrous
    Contributor

    Although now I'm overthinking it. @sonialiap this was previously reported as a bug specific to Concierge taking actions, so we fixed it only in that situation. I feel like maybe we DO want it to show in all cases? What do you think?

  5. sonialiap commented on Nov 7, 2025

    @sonialiap
    Contributor

    @dangrous I think it makes sense to have a behavior be the same across all parts of the product. If we show in LHN that Concierge did/said something then I think it makes sense to likewise show when any user does/says something. Do you think we can expand the scope of #73084 to include it for users in addition to concierge?

  6. samranahm commented on Nov 8, 2025

    @samranahm
    Contributor

    Yes, that actually makes sense. We should have the same behavior for all users, including admins and approvers. Can you please assign me and @Ollyws here?
    cc: @dangrous

  7. 22 remaining items

  8. melvin-bot commented on Nov 26, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Nov 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.63-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-03. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @samranahm requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Nov 26, 2025

    @melvin-bot

    @Ollyws @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. sonialiap commented on Dec 3, 2025

    @sonialiap
    Contributor

    Payment summary:
    @Ollyws $250 please request through NewDot - please complete the checklist
    @samranahm $250 I've sent an offer in upwork - paid ✔️

  12. samranahm commented on Dec 3, 2025

    @samranahm
    Contributor

    @sonialiap I've accepted the offer, Thank you!

  13. melvin-bot commented on Dec 3, 2025

    @melvin-bot
  14. sonialiap commented on Dec 8, 2025

    @sonialiap
    Contributor

    @Ollyws bump for the checklist :)

  15. Ollyws commented on Dec 8, 2025

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    1. Member draft expense in workspace chat (Do not submit)
    2. As Admin open the draft expense report and send message
    3. Verify Admin name is included in LHN alternate text
    4. Trigger Concierge with Change category to "Car"
    5. Verify Concierge name is included in LHN message when it reposed
    

    Do we agree 👍 or 👎

  16. Ollyws commented on Dec 8, 2025

    @Ollyws
    Contributor

    Requested in ND.

  17. twisterdotcom commented on Dec 9, 2025

    @twisterdotcom
    Contributor

    @Ollyws has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-3139-a8eb-eb86-c0c75dd07c54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions