Skip to content

[WAITING ON CHECKLIST] [$250] Android - Reports - Initial values overlap navigation bar #74155

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.43-0-staging
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod, Initial value is not a interactive button in Prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #73899
Email or phone of affected tester (no customers): applausetester+qbo@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung A15, Android 15.
App Component: Other

Action Performed:

Precondition:
User has a workspace connected to QBO with report fields imported.
Test account: applausetester+qbo@applause.expensifail.com

  1. Open Android app.
  2. Navigate to the connected workspace.
  3. Go to Reports
  4. Under Report fields, tap Customers/Projects
  5. Tap Initial Value

Expected Result:

Users should be able to view and interact with the values without obstruction.

Actual Result:

Navigation bar overlaps initial values

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021985726321360727768
  • Upwork Job ID: 1985726321360727768
  • Last Price Increase: 2025-11-04
  • Automatic offers:
    • aimane-chnaif | Reviewer | 109368509
Issue OwnerCurrent Issue Owner: @jliexpensify / @stephanieelliott

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 4, 2025
  2. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 4, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. ChavdaSachin commented on Nov 4, 2025

    @ChavdaSachin
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    A case was missing during refactoring of selection list
    This PR introduced new optimized selection list component which has a missing case for including bottom safe area padding when footer content is empty. And this PR migrated the ReportFieldsInitialListValuePicker.tsx to use new optimized selection list.

    Previously there was a logic to add bottom safe area padding to when footer content was missing

    const shouldHideContentBottomSafeAreaPadding = showConfirmButton || !!footerContent;

    addBottomSafeAreaPadding={!shouldHideContentBottomSafeAreaPadding && addBottomSafeAreaPadding}

    But current implementation does not include this padding here

    <FlashList
    data={data}
    renderItem={renderItem}
    ref={listRef}
    keyExtractor={(item) => item.keyForList}
    ListFooterComponent={listFooterContent}
    scrollEnabled={scrollEnabled}
    indicatorStyle="white"
    keyboardShouldPersistTaps="always"
    showsVerticalScrollIndicator={showScrollIndicator}
    onEndReached={onEndReached}
    onEndReachedThreshold={onEndReachedThreshold}
    style={listStyle as ViewStyle}
    initialScrollIndex={initialFocusedIndex}
    onScrollBeginDrag={onScrollBeginDrag}
    ListHeaderComponent={
    <>
    {customListHeaderContent}
    {textInputComponent({shouldBeInsideList: true})}
    </>
    }
    />

    What changes do you think we should make in order to solve the problem?

    Include safeAreaPadding here.

    <FlashList
    data={data}
    renderItem={renderItem}
    ref={listRef}
    keyExtractor={(item) => item.keyForList}
    ListFooterComponent={listFooterContent}
    scrollEnabled={scrollEnabled}
    indicatorStyle="white"
    keyboardShouldPersistTaps="always"
    showsVerticalScrollIndicator={showScrollIndicator}
    onEndReached={onEndReached}
    onEndReachedThreshold={onEndReachedThreshold}
    style={listStyle as ViewStyle}
    initialScrollIndex={initialFocusedIndex}
    onScrollBeginDrag={onScrollBeginDrag}
    ListHeaderComponent={
    <>
    {customListHeaderContent}
    {textInputComponent({shouldBeInsideList: true})}
    </>
    }
    />

                            contentContainerStyle={!footerContent && addBottomSafeAreaPadding && paddingBottomStyle}

    I could notice the new selectionList component also lacks addOfflineIndicatorBottomSafeAreaPadding so we should check and add this as well if needed

    Small style changes could be fixed during PR phase if needed

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. ChavdaSachin commented on Nov 4, 2025

    @ChavdaSachin
    Contributor

    Not a blocker, I could repro this on prod

    Also the same issue could be observed on some other pages..
    eg. workspace > categories > more > settings.

    Notice listItem - 15 is overlaping

    WhatsApp.Video.2025-11-04.at.14.52.12.mp4

    cc. @srikarparsi

  8. srikarparsi commented on Nov 4, 2025

    @srikarparsi
    Contributor

    Removing the deploy blocker as it is a minor UI bug that looks like it also occurs in prod.

  9. 47 remaining items

  10. jliexpensify commented on Nov 20, 2025

    @jliexpensify
    Contributor

    Payment Summary

    Upwork job

  11. aimane-chnaif commented on Nov 20, 2025

    @aimane-chnaif
    Contributor

    @jliexpensify I get paid via upwork

  12. jliexpensify commented on Nov 20, 2025

    @jliexpensify
    Contributor

    Ah sorry! Thanks for catching that, I'll fix it up.

  13. jliexpensify commented on Nov 20, 2025

    @jliexpensify
    Contributor

    Paid and job closed!

  14. jliexpensify commented on Nov 20, 2025

    @jliexpensify
    Contributor

    Oh wait...is a checklist needed @aimane-chnaif? I don't think that was done before Steph left.

  15. changed the title [-][Due for payment 2025-11-19] [$250] Android - Reports - Initial values overlap navigation bar[/-] [+][WAITING ON CHECKLIST] [$250] Android - Reports - Initial values overlap navigation bar[/+] on Nov 20, 2025
  16. aimane-chnaif commented on Nov 20, 2025

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Create new SelectionList component for usages without sections #66803 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Go to Workspaces
    2. Choose your workspace
    3. Go to Reports -> and Add field
    4. Create one with list type
    5. Add many values to the list so it's scrollable
    6. Click Initial value
    7. Verify that list items doesn't appear behind navigation buttons.

    Do we agree 👍 or 👎

  17. jliexpensify commented on Nov 20, 2025

    @jliexpensify
    Contributor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions