You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WAITING ON CHECKLIST] [$250] Android - Reports - Initial values overlap navigation bar #74155
Version Number: 9.2.43-0-staging Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod, Initial value is not a interactive button in Prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#73899 Email or phone of affected tester (no customers):applausetester+qbo@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Samsung A15, Android 15. App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
A case was missing during refactoring of selection list
This PR introduced new optimized selection list component which has a missing case for including bottom safe area padding when footer content is empty. And this PR migrated the ReportFieldsInitialListValuePicker.tsx to use new optimized selection list.
Previously there was a logic to add bottom safe area padding to when footer content was missing
I could notice the new selectionList component also lacks addOfflineIndicatorBottomSafeAreaPadding so we should check and add this as well if needed
Small style changes could be fixed during PR phase if needed
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Go to Workspaces
Choose your workspace
Go to Reports -> and Add field
Create one with list type
Add many values to the list so it's scrollable
Click Initial value
Verify that list items doesn't appear behind navigation buttons.
Activity
melvin-bot commentedon Nov 4, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 4, 2025
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 4, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 4, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
ChavdaSachin commentedon Nov 4, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
A case was missing during refactoring of selection list
This PR introduced new optimized selection list component which has a missing case for including bottom safe area padding when footer content is empty. And this PR migrated the
ReportFieldsInitialListValuePicker.tsxto use new optimized selection list.Previously there was a logic to add bottom safe area padding to when footer content was missing
App/src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx
Line 981 in 995eec3
App/src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx
Line 1053 in 995eec3
But current implementation does not include this padding here
App/src/components/SelectionList/BaseSelectionList.tsx
Lines 382 to 403 in 59123b4
What changes do you think we should make in order to solve the problem?
Include safeAreaPadding here.
App/src/components/SelectionList/BaseSelectionList.tsx
Lines 382 to 403 in 59123b4
I could notice the new selectionList component also lacks
addOfflineIndicatorBottomSafeAreaPaddingso we should check and add this as well if neededSmall style changes could be fixed during PR phase if needed
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
ChavdaSachin commentedon Nov 4, 2025
Not a blocker, I could repro this on prod
Also the same issue could be observed on some other pages..
eg. workspace > categories > more > settings.
Notice listItem - 15 is overlaping
WhatsApp.Video.2025-11-04.at.14.52.12.mp4
cc. @srikarparsi
srikarparsi commentedon Nov 4, 2025
Removing the deploy blocker as it is a minor UI bug that looks like it also occurs in prod.
47 remaining items
jliexpensify commentedon Nov 20, 2025
Payment Summary
Upwork job
aimane-chnaif commentedon Nov 20, 2025
@jliexpensify I get paid via upwork
jliexpensify commentedon Nov 20, 2025
Ah sorry! Thanks for catching that, I'll fix it up.
jliexpensify commentedon Nov 20, 2025
Paid and job closed!
jliexpensify commentedon Nov 20, 2025
Oh wait...is a checklist needed @aimane-chnaif? I don't think that was done before Steph left.
[-][Due for payment 2025-11-19] [$250] Android - Reports - Initial values overlap navigation bar[/-][+][WAITING ON CHECKLIST] [$250] Android - Reports - Initial values overlap navigation bar[/+]aimane-chnaif commentedon Nov 20, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Create new
SelectionListcomponent for usages without sections #66803 (comment)[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
jliexpensify commentedon Nov 20, 2025
Thanks!