You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-02][$100] Reports - Android - Misaligned spacing between “report” text and toggle #74167
Version Number: 9.2.43-0-staging Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Samsung A15, Android 15. App Component: Other
Action Performed:
Open Android app.
Navigate to workspaces
Create a workspace
Go to Reports
Expected Result:
The “report” text should be positioned with consistent spacing relative to the toggle, following the same layout as on iOS, Web, and mWeb.
Actual Result:
On Android, the “Report” text appears too close to the toggle button, with insufficient spacing.
What changes do you think we should make in order to solve the problem?
We should add margin right or padding right styles.pr5 like we did here for the titleStyle
titleStyle={[styles.pv2, styles.pr5]}
Note: some minor changes UI can be discuss in PR phase
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
On Android, the "Report" text appears too close to the toggle switch in the ToggleSettingOptionRow component. The spacing should match iOS, Web, and mWeb.
What is the root cause of that problem?
The issue occurs in ToggleSettingsOptionRow.tsx at line 165, where the container uses justifyContentBetween with a flex1 text container. On Android, justifyContentBetween with flex1 can render differently than iOS/Web, causing the text container to expand and reducing the visual gap between the text and the Switch.
The layout relies on justifyContentBetween without explicit spacing, which can be inconsistent across platforms, especially on Android.
What changes do you think we should make in order to solve the problem?
Add explicit spacing between the text container and the Switch by adding marginRight to the text container. This ensures consistent spacing across platforms without changing the layout behavior.
Changes:
Add styles.mr3 (12px right margin) to the text container View on line 166
This matches spacing patterns used elsewhere in the codebase (e.g., OptionRow uses mr3 for content containers)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
I don't think we need a regression test for this minor UI issue.
changed the title [-][Due for payment 2025-12-02][$250] Reports - Android - Misaligned spacing between “report” text and toggle[/-][+][Due for payment 2025-12-02][$100] Reports - Android - Misaligned spacing between “report” text and toggle[/+]on Dec 5, 2025
Activity
melvin-bot commentedon Nov 4, 2025
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Nov 4, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
On Android, the “Report” text appears too close to the toggle button, with insufficient spacing.
What is the root cause of that problem?
We are missing margin right here
App/src/pages/workspace/reports/WorkspaceReportsPage.tsx
Lines 222 to 230 in 995eec3
What changes do you think we should make in order to solve the problem?
We should add margin right or padding right
styles.pr5like we did here for thetitleStyleNote: some minor changes UI can be discuss in PR phase
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
abbasifaizan70 commentedon Nov 4, 2025
Please re-state the problem that we are trying to solve in this issue.
On Android, the "Report" text appears too close to the toggle switch in the
ToggleSettingOptionRowcomponent. The spacing should match iOS, Web, and mWeb.What is the root cause of that problem?
The issue occurs in
ToggleSettingsOptionRow.tsxat line 165, where the container usesjustifyContentBetweenwith aflex1text container. On Android,justifyContentBetweenwithflex1can render differently than iOS/Web, causing the text container to expand and reducing the visual gap between the text and the Switch.The layout relies on
justifyContentBetweenwithout explicit spacing, which can be inconsistent across platforms, especially on Android.What changes do you think we should make in order to solve the problem?
Add explicit spacing between the text container and the Switch by adding
marginRightto the text container. This ensures consistent spacing across platforms without changing the layout behavior.Changes:
styles.mr3(12px right margin) to the text container View on line 166OptionRowusesmr3for content containers)What alternative solutions did you explore? (Optional)
N/A
VictoriaExpensify commentedon Nov 4, 2025
This is so minor, but I guess we should fix it. I'm dropping the bounty right down because, from what I can tell, this is a very simple fix
[-]Reports - Android - Misaligned spacing between “report” textand toggle[/-][+][$50] Reports - Android - Misaligned spacing between “report” textand toggle[/+]melvin-bot commentedon Nov 4, 2025
melvin-bot commentedon Nov 4, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021985668641506029272
melvin-bot commentedon Nov 4, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)34 remaining items
VictoriaExpensify commentedon Dec 2, 2025
Hey @daledah please accept the Upwork offer so I can process payment http://upwork.com/nx/wm/offer/109424697
daledah commentedon Dec 2, 2025
@VictoriaExpensify The offer amount is incorrect ($50). It should be $100.
I've accepted the offer but please help to payout the correct amount, thank you!
implement moving report fields into reports feature
mananjadhav commentedon Dec 2, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: 34d77b7#r171831521
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
I don't think we need a regression test for this minor UI issue.
mananjadhav commentedon Dec 2, 2025
@VictoriaExpensify I've completed the checklist, can you please post the payout summary?
mallenexpensify commentedon Dec 5, 2025
Payment Summary
Contributor: @daledah paid $100 via Upwork
Contributor+: @mananjadhav due $100 via NewDot
Should be all set! Comment/reopen if not.
[-][Due for payment 2025-12-02][$250] Reports - Android - Misaligned spacing between “report” text and toggle[/-][+][Due for payment 2025-12-02][$100] Reports - Android - Misaligned spacing between “report” text and toggle[/+]melvin-bot commentedon Dec 5, 2025
Upwork job price has been updated to $100
quinthar commentedon Dec 8, 2025
Approved $100 to @mananjadhav