Skip to content

[Due for payment 2026-01-27] Check for logs and remove legacy transaction thread code if no logs in 30 days #74343

Closed

Description

@tgolen

In this PR there was a log line added for some legacy fallback code.

After that PR has been deployed for a month, we should check to see how often it was logged. If it was not logged in 30 days, we will remove the fallback code.

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 5, 2025
  2. tgolen commented on Dec 8, 2025

    @tgolen
    ContributorAuthor

    The last logs for this were on Nov 27, so let's wait one more month to check this again.

  3. tgolen commented on Jan 12, 2026

    @tgolen
    ContributorAuthor

    Still no more logs, so I think it's safe to remove this fallback code @ikevin127 https://github.com/Expensify/App/pull/74261/changes#r2682944015

  4. ikevin127 commented on Jan 12, 2026

    @ikevin127
    Contributor

    @tgolen 🟢 PR #79388 opened as follow-up to remove the logic.

  5. 7 remaining items

  6. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-27. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment through NewDot Manual Requests
  7. tgolen commented on Jan 20, 2026

    @tgolen
    ContributorAuthor

    @mollfpr OK, thanks for that context. I did not know about that. You can revert the code in #79388 and please put a more comprehensive code comment along with it that explains why that logic remains and when it will be removed. Ideally, there should be a GH open to track it's removal.

  8. mountiny commented on Jan 20, 2026

    @mountiny
    Contributor

    I was wondering, yeah it is good that not many users run into this case but i still think that some users could potentially end up in this case if they wander into newDot. Lets bring it back with better comments!

  9. mollfpr commented on Jan 21, 2026

    @mollfpr
    Contributor

    Got it! Thanks @tgolen @mountiny

  10. self-assigned this
    on Jan 21, 2026
  11. ikevin127 commented on Jan 27, 2026

    @ikevin127
    Contributor

    No payment required for me here for this follow-up PR as we agreed beforehand that I'll follow-up as part of the initial task ✅

  12. melvin-bot commented on Jan 27, 2026

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @johncschuster you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  13. johncschuster commented on Jan 29, 2026

    @johncschuster
    Contributor

    Payment Summary

    Contributor: @ikevin127 No payment required (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions