You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-27] Check for logs and remove legacy transaction thread code if no logs in 30 days #74343
In this PR there was a log line added for some legacy fallback code.
After that PR has been deployed for a month, we should check to see how often it was logged. If it was not logged in 30 days, we will remove the fallback code.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mollfpr OK, thanks for that context. I did not know about that. You can revert the code in #79388 and please put a more comprehensive code comment along with it that explains why that logic remains and when it will be removed. Ideally, there should be a GH open to track it's removal.
I was wondering, yeah it is good that not many users run into this case but i still think that some users could potentially end up in this case if they wander into newDot. Lets bring it back with better comments!
Issue is ready for payment but no BZ is assigned. @johncschuster you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
tgolen commentedon Dec 8, 2025
The last logs for this were on Nov 27, so let's wait one more month to check this again.
tgolen commentedon Jan 12, 2026
Still no more logs, so I think it's safe to remove this fallback code @ikevin127 https://github.com/Expensify/App/pull/74261/changes#r2682944015
ikevin127 commentedon Jan 12, 2026
@tgolen 🟢 PR #79388 opened as follow-up to remove the logic.
7 remaining items
melvin-bot commentedon Jan 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
openReportlegacy transaction logic (follow-up) #79388If no regressions arise, payment will be issued on 2026-01-27. 🎊
For reference, here are some details about the assignees on this issue:
tgolen commentedon Jan 20, 2026
@mollfpr OK, thanks for that context. I did not know about that. You can revert the code in #79388 and please put a more comprehensive code comment along with it that explains why that logic remains and when it will be removed. Ideally, there should be a GH open to track it's removal.
mountiny commentedon Jan 20, 2026
I was wondering, yeah it is good that not many users run into this case but i still think that some users could potentially end up in this case if they wander into newDot. Lets bring it back with better comments!
mollfpr commentedon Jan 21, 2026
Got it! Thanks @tgolen @mountiny
ikevin127 commentedon Jan 27, 2026
No payment required for me here for this follow-up PR as we agreed beforehand that I'll follow-up as part of the initial task ✅
melvin-bot commentedon Jan 27, 2026
Issue is ready for payment but no BZ is assigned. @johncschuster you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
johncschuster commentedon Jan 29, 2026
Payment Summary
Contributor: @ikevin127 No payment required (comment)