Skip to content

Negative amount report shows Pay instead of Mark as Paid #74411

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.45-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72936
Email or phone of affected tester (no customers): applausetester+dp339@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac / Safari
App Component: Other

Action Performed:

  1. Create an expense with a negative amount.
  2. Submit and approve the expense
  3. Open the report preview and verify the available actions.
  4. Enter the report and check the top right primary action buttons.
  5. Go to Reports → Pay tab.
  6. Locate the report with the negative amount and verify the button label.

Expected Result:

The button should display Mark as Paid for reports with negative amounts.

Actual Result:

The button displays Pay instead of Mark as Paid for reports with negative amounts.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6995533_1762387988590.4_12_PM_2025-11-05.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Nov 6, 2025
  2. melvin-bot commented on Nov 6, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 6, 2025

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 6, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 6, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mitarachim commented on Nov 6, 2025

    @mitarachim
    Author

    Issue was found while executing QA for PR #72936

  7. amyevans commented on Nov 6, 2025

    @amyevans
    Contributor

    @mukhrr @FitseTLT could you take a look please, as your PR is linked? Thanks! 🙇

  8. 5 remaining items

  9. mukhrr commented on Nov 6, 2025

    @mukhrr
    Contributor

    @amyevans issue is coming from #74181, I think

    @FitseTLT let me know if I am wrong

  10. situchan commented on Nov 6, 2025

    @situchan
    Contributor

    @mukhrr how is it related? It's already in production.

  11. mukhrr commented on Nov 6, 2025

    @mukhrr
    Contributor

    @situchan it's explicitly set to show Pay button

  12. situchan commented on Nov 6, 2025

    @situchan
    Contributor

    Still reproducible after reverting #74181 locally. So it's not offending PR.
    @mukhrr in the future, please link the exact offending PR after testing the revert locally.

  13. situchan commented on Nov 6, 2025

    @situchan
    Contributor

    This came from #72998 which is being reverted in #74396.

  14. mukhrr commented on Nov 6, 2025

    @mukhrr
    Contributor

    Still reproducible after reverting #74181 locally. So it's not offending PR. @mukhrr in the future, please link the exact offending PR after testing the revert locally.

    oh sorry, I seem to have consfused PR

  15. mukhrr commented on Nov 6, 2025

    @mukhrr
    Contributor

    This came from #72998 which is being reverted in #74396.

    I also still reproduce issue after reverting #72998.
    I think this is coming from my PR. Here is fix for this issue #74427

  16. FitseTLT commented on Nov 6, 2025

    @FitseTLT
    Contributor

    I do not agree this is a bug in the first place. @luacmartins Don't we need to show Pay button in Reports page even if the button is technically Mark as Paid one. I assume that we are using short form intentionally here

  17. luacmartins commented on Nov 6, 2025

    @luacmartins
    Contributor

    hmm yea, I think this is expected. @trjExpensify @JmillsExpensify can you confirm please?

  18. JmillsExpensify commented on Nov 6, 2025

    @JmillsExpensify
    Contributor

    Agree that's expected.

  19. luacmartins commented on Nov 6, 2025

    @luacmartins
    Contributor

    Cool, I'm gonna close this. @mitarachim please update any tests if needed.

  20. FitseTLT commented on Nov 6, 2025

    @FitseTLT
    Contributor

    @mukhrr please update the test steps in the OP #72936 (comment) accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions