You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Negative amount report shows Pay instead of Mark as Paid #74411
Version Number: v9.2.45-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#72936 Email or phone of affected tester (no customers):applausetester+dp339@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac / Safari App Component: Other
Action Performed:
Create an expense with a negative amount.
Submit and approve the expense
Open the report preview and verify the available actions.
Enter the report and check the top right primary action buttons.
Go to Reports → Pay tab.
Locate the report with the negative amount and verify the button label.
Expected Result:
The button should display Mark as Paid for reports with negative amounts.
Actual Result:
The button displays Pay instead of Mark as Paid for reports with negative amounts.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Still reproducible after reverting #74181 locally. So it's not offending PR. @mukhrr in the future, please link the exact offending PR after testing the revert locally.
Still reproducible after reverting #74181 locally. So it's not offending PR. @mukhrr in the future, please link the exact offending PR after testing the revert locally.
I do not agree this is a bug in the first place. @luacmartins Don't we need to show Pay button in Reports page even if the button is technically Mark as Paid one. I assume that we are using short form intentionally here
Activity
melvin-bot commentedon Nov 6, 2025
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 6, 2025
Triggered auto assignment to @amyevans (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 6, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 6, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mitarachim commentedon Nov 6, 2025
Issue was found while executing QA for PR #72936
amyevans commentedon Nov 6, 2025
@mukhrr @FitseTLT could you take a look please, as your PR is linked? Thanks! 🙇
5 remaining items
mukhrr commentedon Nov 6, 2025
@amyevans issue is coming from #74181, I think
App/src/components/SelectionListWithSections/Search/ActionCell.tsx
Line 152 in 127f8cc
@FitseTLT let me know if I am wrong
situchan commentedon Nov 6, 2025
@mukhrr how is it related? It's already in production.
mukhrr commentedon Nov 6, 2025
@situchan it's explicitly set to show Pay button
situchan commentedon Nov 6, 2025
Still reproducible after reverting #74181 locally. So it's not offending PR.
@mukhrr in the future, please link the exact offending PR after testing the revert locally.
situchan commentedon Nov 6, 2025
This came from #72998 which is being reverted in #74396.
mukhrr commentedon Nov 6, 2025
oh sorry, I seem to have consfused PR
mukhrr commentedon Nov 6, 2025
I also still reproduce issue after reverting #72998.
I think this is coming from my PR. Here is fix for this issue #74427
FitseTLT commentedon Nov 6, 2025
I do not agree this is a bug in the first place. @luacmartins Don't we need to show
Paybutton in Reports page even if the button is technicallyMark as Paidone. I assume that we are using short form intentionally hereApp/src/components/SelectionListWithSections/Search/ActionCell.tsx
Line 152 in 127f8cc
luacmartins commentedon Nov 6, 2025
hmm yea, I think this is expected. @trjExpensify @JmillsExpensify can you confirm please?
JmillsExpensify commentedon Nov 6, 2025
Agree that's expected.
luacmartins commentedon Nov 6, 2025
Cool, I'm gonna close this. @mitarachim please update any tests if needed.
FitseTLT commentedon Nov 6, 2025
@mukhrr please update the test steps in the OP #72936 (comment) accordingly