Skip to content

[Due for payment 2026-01-15] [$250] Workspaces - Currency un duplicate workspace unchanged after unselecting overview box #74650

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.47-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1858/folder/13177080/44743831/999691560?sort=-status_id
Email or phone of affected tester (no customers): negasofonias+neg@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to workspaces and click on 3 dots for a workspace that has a different currency from you default currency
  2. Click on duplicate
  3. Enter name and click next
  4. From the list of features to copy unselect the first box (overview with subheader of the currency in the work space u r copying)
  5. Create continue
  6. Open the new duplicated workspace and open overview and see currency is still duplicated

Expected Result:

Currency should not be duplicated and the copied workspace's currency should be the default currency of user

Actual Result:

Currency is also duplicated

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6997712_1762577628967.Recording_20251108_073624.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021989057280765730561
  • Upwork Job ID: 1989057280765730561
  • Last Price Increase: 2025-11-20
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @lydiabarclay

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 8, 2025
  2. melvin-bot commented on Nov 8, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Nov 8, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Currency is also duplicated

    What is the root cause of that problem?

    We always keep the curreny as the previous currency

    What changes do you think we should make in order to solve the problem?

    If we unselected the overview option, we should update the currency of the duplicate currency to the user's default currency

    1. Pass overview part here and define localCurrency in the options parameter
    overview: selectedItems.includes('overview'),
    localCurrency: currentUserPersonalDetails?.localCurrencyCode,
    

    people: selectedItems.includes('members'),

    1. Update outputCurrency to localCurrency if the overview options is unselected. We also need the backend change for this.
    outputCurrency: parts?.overview ? policy?.outputCurrency : localCurrency ?? policy?.outputCurrency,
    

    "Overview - Checks for any workspace description, default currency, and company address, e.g., “Sales team policy, USD currency, 2120 Hyde St, SF, 94109”"

    Based on the doc, we should also clear the policy description, company address when the Overview isn't selected.

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. Krishna2323 commented on Nov 8, 2025

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspaces - Currency un duplicate workspace unchanged after unselecting overview box

    What is the root cause of that problem?

    • The parts object is missing overview: selectedItems.includes('overview').
      parts: {
      people: selectedItems.includes('members'),
      reports: selectedItems.includes('reports'),
      connections: selectedItems.includes('accounting'),
      categories: selectedItems.includes('categories'),
      tags: selectedItems.includes('tags'),
      taxes: selectedItems.includes('taxes'),
      perDiem: selectedItems.includes('perDiem'),
      reimbursements: selectedItems.includes('invoices'),
      expenses: selectedItems.includes('rules'),
      customUnits: selectedItems.includes('distanceRates'),
      invoices: selectedItems.includes('invoices'),
      exportLayouts: selectedItems.includes('workflows'),
      },
    • And the DuplicateWorkspace api doesn't accept the currency param and return according to that.

    What changes do you think we should make in order to solve the problem?

    • We should add overview: selectedItems.includes('overview') here.
    • Then update the line below and pass isOverviewOptionSelected ? policy?.outputCurrency : undefined
      const {customUnitID, customUnitRateID} = buildOptimisticDistanceRateCustomUnits(policy?.outputCurrency);
    • Add outputCurrency: outputCurrencyForDuplicate here.
    • We should also update the successData and failureData if needed.
    • Lastly update the BE to also accept currency and pass the outputCurrencyForDuplicate as outputCurrency/currency in the param.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Result

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 13, 2025
  6. changed the title [-]Workspaces - Currency un duplicate workspace unchanged after unselecting overview box[/-] [+][$250] Workspaces - Currency un duplicate workspace unchanged after unselecting overview box[/+] on Nov 13, 2025
  7. melvin-bot commented on Nov 13, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 13, 2025
  9. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

  10. 39 remaining items

  11. changed the title [-][$250] Workspaces - Currency un duplicate workspace unchanged after unselecting overview box[/-] [+][Due for payment 2026-01-15] [$250] Workspaces - Currency un duplicate workspace unchanged after unselecting overview box[/+] on Jan 8, 2026
  12. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.95-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-15. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment through NewDot Manual Requests
    • @s77rt does not require payment (Contractor)
    • @nkdengineer requires payment through NewDot Manual Requests
  14. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    @Pujan92 @lydiabarclay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. lydiabarclay commented on Jan 13, 2026

    @lydiabarclay
    Contributor

    @Pujan92 can you please fill out the bz checklist ahead of the payment date?

  16. Pujan92 commented on Jan 16, 2026

    @Pujan92
    Contributor

    No checklist as it seems to be a new change.

    Regression Test Proposal

    1. Go to workspaces and click on 3 dots for a workspace that has a different currency from your default currency
    2. Click on duplicate
    3. Enter name and click next
    4. From the list of features to copy, unselect the first box (overview with subheader of the currency in the workspace you're copying)
    5. Create continue
    6. Open the newly duplicated workspace
    7. Verify that the currency is the default currency
  17. lydiabarclay commented on Jan 16, 2026

    @lydiabarclay
    Contributor

    Payment Summary

    Contributor: @nkdengineer due $250 via NewDot
    Contributor: @s77rt does not require payment (Contractor)
    Contributor+: @Pujan92 due $250 via NewDot

    ✅ Regression test filed

  18. twisterdotcom commented on Jan 19, 2026

    @twisterdotcom
    Contributor

    @Pujan92 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-9014-ac40-ba74-527bf7d3d9a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions