Skip to content

[Due for payment 2025-12-19] [$250] Add BA - When accept terms offline and go online, "You must accept terms" error shown #74732

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.48-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176691/test-cases/41236745
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 26.0.1
App Component: Other

Action Performed:

  1. Sign up to ND with a new gmail account, verify it
  2. Create a workspace, open Workflows, tap "Add bank account"
  3. Select "Log into your bank", Wells Fargo 1111 bank account
  4. Proceed with the flow until final confirmation page "Please confirm the agreements below"
  5. Go offline and accept all the terms
  6. Go back online - the checkmarks are presented, tap "Save&Continue" button

Expected Result:

The successful modal is displayed after accepting all the terms

Actual Result:

"You must accept the terms" error is shown online when the terms were accepted offline and the checkmarks are presented

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021991092758012921430
  • Upwork Job ID: 1991092758012921430
  • Last Price Increase: 2025-11-19
  • Automatic offers:
    • samranahm | Contributor | 109593799
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2025
  2. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Nov 10, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add BA - When accept terms offline and go online, "You must accept terms" error shown

    What is the root cause of that problem?

    The form reading default values from reimbursementAccount?.achData instead of checking draft values first.

    • User goes offline > checks boxes > saved to draft
    • User goes online > form reads from reimbursementAccount?.achData (still false) instead of draft (now true)
    • Validation fails > "You must accept terms" error

    What changes do you think we should make in order to solve the problem?

    We should changed to use getSubStepValues() which checks draft values first, then falls back to reimbursementAccount?.achData.
    here

    const defaultValues = {
    isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
    certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
    acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
    };

    const [reimbursementAccountDraft] = useOnyx(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {canBeMissing: true});
    const values = useMemo(() => getSubStepValues(COMPLETE_VERIFICATION_KEYS, reimbursementAccountDraft, reimbursementAccount), [reimbursementAccount, reimbursementAccountDraft]);
    const defaultValues = {
        isAuthorizedToUseBankAccount: values.isAuthorizedToUseBankAccount ?? false,
        certifyTrueInformation: values.certifyTrueInformation ?? false,
        acceptTermsAndConditions: values.acceptTermsAndConditions ?? false,
    };

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. daledah commented on Nov 10, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "You must accept the terms" error is shown online when the terms were accepted offline and the checkmarks are presented

    What is the root cause of that problem?

    We only save the check box state in reimbursementAccountDraft => when ther user go online again => all default values will be false

    const defaultValues = {
    isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
    certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
    acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
    };

    What changes do you think we should make in order to solve the problem?

    We should update it to use reimbursementAccountDraft instead of reimbursementAccount (or we can add reimbursementAccountDraft data as the fallback of reimbursementAccount data) like we did in confirmationBusiness step here

    const defaultCheckboxState = reimbursementAccountDraft?.[BUSINESS_INFO_STEP_KEYS.HAS_NO_CONNECTION_TO_CANNABIS] ?? false;

        const [reimbursementAccountDraft] = useOnyx(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {canBeMissing: true});
        ...
        const defaultValues = {
            isAuthorizedToUseBankAccount: reimbursementAccountDraft?.[COMPLETE_VERIFICATION_KEYS.IS_AUTHORIZED_TO_USE_BANK_ACCOUNT] ?? false,
            certifyTrueInformation: reimbursementAccountDraft?.[COMPLETE_VERIFICATION_KEYS.CERTIFY_TRUE_INFORMATION] ?? false,
            acceptTermsAndConditions: reimbursementAccountDraft?.[COMPLETE_VERIFICATION_KEYS.ACCEPT_TERMS_AND_CONDITIONS] ?? false,
        };
    

    const defaultValues = {
    isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
    certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
    acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
    };

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. dylanexpensify commented on Nov 11, 2025

    @dylanexpensify
    Contributor

    @joekaufmanexpensify this sounds like a bug, but wanted to confirm first if we did indeed design this flow w/the offline consideration at this stage

  6. joekaufmanexpensify commented on Nov 11, 2025

    @joekaufmanexpensify
    Contributor

    I was not involved with the initial design, but agree that this looks like a bug. If you accept the terms offline and then go back online, you shouldn't have to deselect the checkbox and then check it again just to proceed

  7. melvin-bot commented on Nov 15, 2025

    @melvin-bot

    @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 19, 2025
  9. melvin-bot commented on Nov 19, 2025

    @melvin-bot
  10. changed the title [-]Add BA - When accept terms offline and go online, "You must accept terms" error shown[/-] [+][$250] Add BA - When accept terms offline and go online, "You must accept terms" error shown[/+] on Nov 19, 2025
  11. 33 remaining items

  12. dylanexpensify commented on Dec 16, 2025

    @dylanexpensify
    Contributor

    Payment coming up!

  13. melvin-bot commented on Dec 22, 2025

    @melvin-bot

    @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. samranahm commented on Dec 23, 2025

    @samranahm
    Contributor

    @allroundexperts Do we need checklist here?

  15. mallenexpensify commented on Dec 24, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @samranahm paid $250 via Upwork
    Contributor+: @allroundexperts due $250 via NewDot

    @allroundexperts plz complete the BZ checklist.

  16. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

  17. samranahm commented on Dec 25, 2025

    @samranahm
    Contributor

    Not overdue, awaiting check from C+

  18. melvin-bot commented on Dec 27, 2025

    @melvin-bot

    @dylanexpensify Still overdue 6 days?! Let's take care of this!

  19. allroundexperts commented on Dec 27, 2025

    @allroundexperts
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: I wasn't able to point to the exact PR that caused the issue. It seems like the feature was implemented in this way.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • N/A

    Test:

    1. Create workspace and open workflow page to connect bank account
    2. Enter all your data and business information
    3. On confirm agreement page go offline and accept all the terms
    4. Go back online and verify the check marks presented
    5. Tap Save & continue button

    Verify no error appear and you navigate to next page successfully

    Do we agree 👍 or 👎

  20. melvin-bot commented on Jan 1, 2026

    @melvin-bot

    @dylanexpensify 12 days overdue. Walking. Toward. The. Light...

  21. trjExpensify commented on Jan 5, 2026

    @trjExpensify
    Contributor

    approved $250 for @allroundexperts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions