You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-19] [$250] Add BA - When accept terms offline and go online, "You must accept terms" error shown #74732
Version Number: 9.2.48-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176691/test-cases/41236745 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 26.0.1 App Component: Other
Action Performed:
Sign up to ND with a new gmail account, verify it
Create a workspace, open Workflows, tap "Add bank account"
Select "Log into your bank", Wells Fargo 1111 bank account
Proceed with the flow until final confirmation page "Please confirm the agreements below"
Go offline and accept all the terms
Go back online - the checkmarks are presented, tap "Save&Continue" button
Expected Result:
The successful modal is displayed after accepting all the terms
Actual Result:
"You must accept the terms" error is shown online when the terms were accepted offline and the checkmarks are presented
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
What changes do you think we should make in order to solve the problem?
We should update it to use reimbursementAccountDraft instead of reimbursementAccount (or we can add reimbursementAccountDraft data as the fallback of reimbursementAccount data) like we did in confirmationBusiness step here
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
I was not involved with the initial design, but agree that this looks like a bug. If you accept the terms offline and then go back online, you shouldn't have to deselect the checkbox and then check it again just to proceed
changed the title [-]Add BA - When accept terms offline and go online, "You must accept terms" error shown[/-][+][$250] Add BA - When accept terms offline and go online, "You must accept terms" error shown[/+]on Nov 19, 2025
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I wasn't able to point to the exact PR that caused the issue. It seems like the feature was implemented in this way.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
N/A
Test:
Create workspace and open workflow page to connect bank account
Enter all your data and business information
On confirm agreement page go offline and accept all the terms
Go back online and verify the check marks presented
Tap Save & continue button
Verify no error appear and you navigate to next page successfully
Activity
melvin-bot commentedon Nov 10, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Nov 10, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add BA - When accept terms offline and go online, "You must accept terms" error shown
What is the root cause of that problem?
The form reading default values from
reimbursementAccount?.achDatainstead of checking draft values first.reimbursementAccount?.achData(still false) instead of draft (now true)What changes do you think we should make in order to solve the problem?
We should changed to use
getSubStepValues()which checks draft values first, then falls back toreimbursementAccount?.achData.here
App/src/pages/ReimbursementAccount/USD/CompleteVerification/subSteps/ConfirmAgreements.tsx
Lines 44 to 48 in 73a784d
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
daledah commentedon Nov 10, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"You must accept the terms" error is shown online when the terms were accepted offline and the checkmarks are presented
What is the root cause of that problem?
We only save the check box state in
reimbursementAccountDraft=> when ther user go online again => all default values will be falseApp/src/pages/ReimbursementAccount/USD/CompleteVerification/subSteps/ConfirmAgreements.tsx
Lines 44 to 48 in 73a784d
What changes do you think we should make in order to solve the problem?
We should update it to use
reimbursementAccountDraftinstead ofreimbursementAccount(or we can addreimbursementAccountDraftdata as the fallback ofreimbursementAccountdata) like we did inconfirmationBusinessstep hereApp/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/ConfirmationBusiness.tsx
Line 60 in 3cb2fe3
App/src/pages/ReimbursementAccount/USD/CompleteVerification/subSteps/ConfirmAgreements.tsx
Lines 44 to 48 in 73a784d
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
dylanexpensify commentedon Nov 11, 2025
@joekaufmanexpensify this sounds like a bug, but wanted to confirm first if we did indeed design this flow w/the offline consideration at this stage
joekaufmanexpensify commentedon Nov 11, 2025
I was not involved with the initial design, but agree that this looks like a bug. If you accept the terms offline and then go back online, you shouldn't have to deselect the checkbox and then check it again just to proceed
melvin-bot commentedon Nov 15, 2025
@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021991092758012921430
[-]Add BA - When accept terms offline and go online, "You must accept terms" error shown[/-][+][$250] Add BA - When accept terms offline and go online, "You must accept terms" error shown[/+]33 remaining items
dylanexpensify commentedon Dec 16, 2025
Payment coming up!
melvin-bot commentedon Dec 22, 2025
@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
samranahm commentedon Dec 23, 2025
@allroundexperts Do we need checklist here?
mallenexpensify commentedon Dec 24, 2025
Payment Summary
Contributor: @samranahm paid $250 via Upwork
Contributor+: @allroundexperts due $250 via NewDot
@allroundexperts plz complete the BZ checklist.
melvin-bot commentedon Dec 24, 2025
@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?
samranahm commentedon Dec 25, 2025
Not overdue, awaiting check from C+
melvin-bot commentedon Dec 27, 2025
@dylanexpensify Still overdue 6 days?! Let's take care of this!
allroundexperts commentedon Dec 27, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I wasn't able to point to the exact PR that caused the issue. It seems like the feature was implemented in this way.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify no error appear and you navigate to next page successfully
Do we agree 👍 or 👎
melvin-bot commentedon Jan 1, 2026
@dylanexpensify 12 days overdue. Walking. Toward. The. Light...
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.