You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-26] [$250] Wrong swipe behavior in RHN #74735
Version Number: 9.2.48-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@Eskalifer1 at #68983 (comment) Slack conversation (hyperlinked to channel name):
Action Performed:
Open the page where the tabs are present (for example, create expense)
Use a swipe to go to the tab from which you can go to the next page (for example, from scan to manual).
When you switch, click on the link to go to another page (for example, currency selection).
Expected Result:
The page we clicked on will open and remain open.
Actual Result:
After a short period of time, we are taken to the tab we were swiping to.
Screenshots/Videos
Add any screenshot/video evidence2025-10-28.19.00.00.mov
🚨 Edited by proposal-police: This proposal was edited at 2025-11-16 06:51:21 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Interaction with RHN screen is broken, when there is ongoing screen navigation animation.
What is the root cause of that problem?
When we swipe the screen, there is a gesture animation, and this does not complete instantly when we release the gesture. It takes some time to finish it. When we interact quickly with a button, which triggers a navigation animation, it seems broken, as the previous animation is not completed and we are starting a new one.
What changes do you think we should make in order to solve the problem?
When screen transition happens, it's focused state for the screen changes, so we need to track it's focused state.
We are already using useFocusEffect, so create one ref variable to store its state, and cancel the interaction with the screen until the animation completes.
What alternative solutions did you explore? (Optional)
We can also fix this issue by making setting pointerEvents: none to the screen. This will prevent tab screen from interaction until the screen transition completes.
We are already using TabScreenWithFocusTrapWrapper as a wrapper to each OnyxTabNavigator screen except one (ShareRootPage), so we can add pointerEvents here, or we can create a completely new component for that.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.84-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aimane-chnaif@johncschuster The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The root cause seems to be in upstream
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 10, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Wrong swipe behavior in RHN[/-][+][$250] Wrong swipe behavior in RHN[/+]melvin-bot commentedon Nov 10, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021987966998916927793
melvin-bot commentedon Nov 10, 2025
Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.
mdneyazahmad commentedon Nov 13, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-16 06:51:21 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Interaction with RHN screen is broken, when there is ongoing screen navigation animation.
What is the root cause of that problem?
When we swipe the screen, there is a gesture animation, and this does not complete instantly when we release the gesture. It takes some time to finish it. When we interact quickly with a button, which triggers a navigation animation, it seems broken, as the previous animation is not completed and we are starting a new one.
What changes do you think we should make in order to solve the problem?
When screen transition happens, it's focused state for the screen changes, so we need to track it's focused state.
We are already using
useFocusEffect, so create one ref variable to store its state, and cancel the interaction with the screen until the animation completes.App/src/pages/iou/request/step/IOURequestStepAmount.tsx
Lines 124 to 134 in 69d248f
Updated method
What alternative solutions did you explore? (Optional)
We can also fix this issue by making setting
pointerEvents: noneto the screen. This will prevent tab screen from interaction until the screen transition completes.We are already using
TabScreenWithFocusTrapWrapperas a wrapper to eachOnyxTabNavigatorscreen except one (ShareRootPage), so we can add pointerEvents here, or we can create a completely new component for that.App/src/libs/Navigation/OnyxTabNavigator.tsx
Lines 244 to 248 in 5046eb4
Valforte commentedon Nov 13, 2025
@aimane-chnaif can you review the current proposals?
41 remaining items
melvin-bot commentedon Dec 19, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.84-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 19, 2025
@aimane-chnaif @johncschuster The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mdneyazahmad commentedon Dec 31, 2025
Should we continue with payment?
melvin-bot commentedon Jan 2, 2026
@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
johncschuster commentedon Jan 5, 2026
Payment Summary
Contributor: @mdneyazahmad paid $250 via Upwork ✅
Contributor+: @aimane-chnaif paid $250 via Upwork ✅
johncschuster commentedon Jan 5, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
johncschuster commentedon Jan 5, 2026
@aimane-chnaif, can you help me out with the checklist above?
aimane-chnaif commentedon Jan 5, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The root cause seems to be in upstream
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/584787
Regression Test Proposal
Test:
Screens
For the above screens, perform the following steps
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-ca6d-af5c-6ab2-566322f5d594