Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.48-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif at #68983 (comment)
Slack conversation (hyperlinked to channel name):
Action Performed:
- Go to staging.new.expensify.com
- Create a workspace.
- Go to workspace settings > More features.
- Enable Per diem.
- Upgrade workspace when prompted.
- Open FAB > Create expense.
- Use cursor to swipe to Distance tab, then to Per diem tab.
- Click Edit per diem rates.
- Select "Company cards" section
Expected Result:
Company cards page is shown
Actual Result:
Create expense modal shows while loading Company cards page.
Workaround:
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021987968248664688491
- Upwork Job ID: 1987968248664688491
- Last Price Increase: 2025-11-10
- Automatic offers:
- aimane-chnaif | Reviewer | 109536993
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @twisterdotcomMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2

Activity
melvin-bot commentedon Nov 10, 2025
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Create expense modal shows when loading Company cards page[/-][+][$250] Create expense modal shows when loading Company cards page[/+]melvin-bot commentedon Nov 10, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021987968248664688491
melvin-bot commentedon Nov 10, 2025
Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.
Eskalifer1 commentedon Nov 10, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-14 10:11:47 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Closed RHP is visible when you go to the “Company Cards” page.
What is the root cause of that problem?
Some pages is not using ScreenWraper(only AccessOrNotFoundWrapper), so they dont get a background and closed RHP is visible during isLoading state:
App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx
Lines 171 to 175 in 906641b
App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx
Lines 64 to 73 in 906641b
For comparison, here is how it is done on other pages, which is why this bug does not occur here:
App/src/pages/workspace/reports/WorkspaceReportsPage.tsx
Lines 169 to 180 in 906641b
What changes do you think we should make in order to solve the problem?
We should add ScreenWrapper for these pages(Since this component has a background, if it is not on the page, then the page also has no background.)
I think we need to check all pages within Workspace, and add this component to those pages where it is not present at all, and on those pages where it is present (for example, within
WorkspacePageWithSections), make sure that all content is within these pages (including loading state).Or, if for some reason we cannot wrap the pages in ScreenWrapper, as this may break the styles for the entire page, we need to use
FullScreenLoadingIndicatorinstead ofActivityIndicator, as this component is designed to be displayed on the entire page and also has a background, but we will need to additionally pass opacity: 1:App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx
Lines 177 to 182 in 5046eb4
Translated with DeepL.com (free version)
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
mukhrr commentedon Nov 10, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-13 18:31:25 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When there is no per diem rate, we show per diem tab when creating an expense
What is the root cause of that problem?
Currently we don't validate to show per diem tab when createing expense if there is per diem or not
App/src/libs/PolicyUtils.ts
Lines 94 to 96 in a7d994c
What changes do you think we should make in order to solve the problem?
canSubmitPerDiemExpenseFromWorkspaceand filtergetActivePoliciesWithExpenseChatAndPerDiemEnabledwith thatOr just update
getActivePoliciesWithExpenseChatAndPerDiemEnabledto filter out tab if policy doesn't have per diem rates yetWhat alternative solutions did you explore? (Optional)
And ff we concern about filtering
getActivePoliciesWithExpenseChatAndPerDiemEnabledcan affect other places, we can create a new util which filters out like above and use special forIOURequestStartPage.tsxwhere we show per diem tabValforte commentedon Nov 13, 2025
@aimane-chnaif can you review the current proposals?
42 remaining items
melvin-bot commentedon Nov 19, 2025
📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Nov 19, 2025
📣 @mukhrr You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖
mukhrr commentedon Nov 22, 2025
@aimane-chnaif PR is ready
mukhrr commentedon Dec 3, 2025
I think this is due to payment today?! #75807 (comment)
cc @zanyrenney @Valforte
aimane-chnaif commentedon Dec 3, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: kind of new feature as we decided here
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/575986
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-f3d9-a687-a79d-a3f538c81554[-][$250] Create expense modal shows when loading Company cards page[/-][+][Due for payment 2025-12-09] [$250] Create expense modal shows when loading Company cards page[/+]twisterdotcom commentedon Dec 9, 2025
Payment Summary:
fix per diem tab visibility after cache clear on non-default workspace
fix per diem tab visibility after cache clear on non-default workspace