You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-16] [$250] Reports - Selected state remains after the expense disappears from the page #74822
Version Number: 9.2.49-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):biruknew45+66dsswdsdlhhj@gmail.com Issue reported by: Applause - Internal Team
What changes do you think we should make in order to solve the problem?
We should clear selected when there is no item in the search page.
const hasSelectedTransactions = Object.keys(selectedTransactions).length > 0; // or we can use the condition `!data.length` here
...
useEffect(() => {
if (!isSearchResultsEmpty || prevIsSearchResultEmpty || !hasSelectedTransactions) {
return;
}
clearSelectedTransactions();
turnOffMobileSelectionMode();
}, [isSearchResultsEmpty, prevIsSearchResultEmpty, hasSelectedTransactions, clearSelectedTransactions]);
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Reports - Selected state remains after the expense disappears from the page[/-][+][$250] Reports - Selected state remains after the expense disappears from the page[/+]on Nov 18, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.73-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@bernhardoj@JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Have a workspace
Test:
Web only
Open a workspace chat, create an expense (ensure it has no violations so that the Submit button appears in Reports)
Navigate to Reports > Submit
Select the expense that's created in step 1
Press the Submit button from the right side of the report (not from the dropdown menu)
Activity
melvin-bot commentedon Nov 11, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Nov 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The selection state remains active
What is the root cause of that problem?
We are not clear selected when there is no item in the search page
App/src/components/Search/index.tsx
Lines 531 to 536 in af1fa16
What changes do you think we should make in order to solve the problem?
We should clear selected when there is no item in the search page.
App/src/components/Search/index.tsx
Lines 531 to 536 in af1fa16
What alternative solutions did you explore? (Optional)
Or we can create a new
useEffectthat will clear transactions when we don't have any selected transactionsReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Nov 15, 2025
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Reports - Selected state remains after the expense disappears from the page[/-][+][$250] Reports - Selected state remains after the expense disappears from the page[/+]melvin-bot commentedon Nov 18, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021990924724170294870
melvin-bot commentedon Nov 18, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @bernhardoj (
External)JmillsExpensify commentedon Nov 18, 2025
Opening up for proposals.
27 remaining items
melvin-bot commentedon Dec 9, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.73-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-16. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 9, 2025
@bernhardoj @JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
bernhardoj commentedon Dec 10, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/65421/files#r2605656942
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Web only
Do we agree 👍 or 👎
melvin-bot commentedon Dec 16, 2025
Payment Summary
Upwork Job
BugZero Checklist (@JmillsExpensify)
JmillsExpensify commentedon Dec 17, 2025
Payment:
JmillsExpensify commentedon Dec 17, 2025
@paulnjs Did you want to apply for the Upwork job?
paulnjs commentedon Dec 17, 2025
@JmillsExpensify I applied to the job
JmillsExpensify commentedon Dec 17, 2025
Offer sent
bernhardoj commentedon Dec 17, 2025
Requested in ND.
JmillsExpensify commentedon Dec 17, 2025
All set
garrettmknight commentedon Dec 29, 2025
$250 approved for @bernhardoj