You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$125] Report - Word "You" missing on next step on expense created offline with instant submission #74919
Prerequisite: Account has at least one workspace.
Prerequisite 2: Submission frequency set to "Instantly"
Open the Expensify app.
Open any workspace chat.
Turn off internet connection.
Create a manual expense.
Open the report of the just created expense.
Note that next step message displays "Waiting for to approve expense" without "You"
Expected Result:
When creating an expense on a workspace with submission frequency set to "Instantly", next step message should be "Waiting for you to approve expense".
Actual Result:
After creating a manual expense while offline on a workspace with submissions frequency set to "Instantly", next step message is displayed as "Waiting for to approve expense" without the word "You".
In getNextApproverAccountID, we assign the first approver in the approval chain if the current user is not in the approval chain. But in this case, the approver is the submitter and and the only approver on the approver chain. Therefore currentUserIndex is 0. And nextapproveremail will be undefined when we are trying to access approvalChain[1] while approvalChain have only one item
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
After creating a manual expense while offline on a workspace with submissions frequency set to "Instantly", next step message is displayed as "Waiting for to approve expense" without the word "You".
What is the root cause of that problem?
When the last approver is the current user, we ignore this here
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Report - Word "You" missing on next step on expense created offline with instant submission[/-][+][$125] Report - Word "You" missing on next step on expense created offline with instant submission[/+]on Nov 12, 2025
⚠️@wildan-m Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Activity
melvin-bot commentedon Nov 12, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.etCoderDysto commentedon Nov 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report - Word "You" missing on next step on expense created offline with instant submission
What is the root cause of that problem?
We call getNextApproverDisplayName to get the next approver display name. And we call getNextApproverAccountID to get approvers accountID.
App/src/libs/NextStepUtils.ts
Line 201 in 82a45ab
In getNextApproverAccountID, we assign the first approver in the approval chain if the current user is not in the approval chain. But in this case, the approver is the submitter and and the only approver on the approver chain. Therefore currentUserIndex is 0. And nextapproveremail will be undefined when we are trying to access approvalChain[1] while approvalChain have only one item
App/src/libs/ReportUtils.ts
Lines 4481 to 4482 in 82a45ab
What changes do you think we should make in order to solve the problem?
We should return the only approver as the next nextApproverEmail if the report is not approved yet
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nkdengineer commentedon Nov 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
After creating a manual expense while offline on a workspace with submissions frequency set to "Instantly", next step message is displayed as "Waiting for to approve expense" without the word "You".
What is the root cause of that problem?
When the last approver is the current user, we ignore this here
App/src/libs/ReportUtils.ts
Lines 4482 to 4488 in 82a45ab
Which cause
nextApproverDisplayName,approverAccountIDare empty then theYouword is missingApp/src/libs/NextStepUtils.ts
Lines 562 to 563 in 82a45ab
What changes do you think we should make in order to solve the problem?
Define
shouldIgnoreCurrentUserparam ingetNextApproverAccountIDandgetNextApproverDisplayName.Update this condition here to
App/src/libs/ReportUtils.ts
Lines 4482 to 4488 in 82a45ab
Then pass it as
falsehereApp/src/libs/NextStepUtils.ts
Lines 562 to 563 in 82a45ab
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Report - Word "You" missing on next step on expense created offline with instant submission[/-][+][$125] Report - Word "You" missing on next step on expense created offline with instant submission[/+]melvin-bot commentedon Nov 12, 2025
melvin-bot commentedon Nov 12, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021988750606339448220
melvin-bot commentedon Nov 12, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)mallenexpensify commentedon Nov 12, 2025
Think/hope this is a quick fix. Was able to reproduce
melvin-bot commentedon Nov 19, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
58 remaining items
melvin-bot commentedon Mar 16, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
parasharrajat commentedon Mar 16, 2026
Rechecking this tomorrow.
Fall back to currentUserAccountID when getNextApproverAccountID retur…
wildan-m commentedon Mar 19, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Mar 19, 2026
mvtglobally commentedon Mar 21, 2026
Issue not reproducible during KI retests. (Second week)
melvin-bot commentedon Mar 24, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Mar 24, 2026
@parasharrajat Huh... This is 4 days overdue. Who can take care of this?
mallenexpensify commentedon Mar 24, 2026
Closing as not reproducible.