You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Ready for payment 12th Dec][$250] Use correct loading indicators in PDF components #75031
There is a group of PDF components that aren’t necessarily rendered fullscreen, but for loading states they use the FullscreenLoadingIndicator. With our recent changes to FullscreenLoadingIndicator which now renders a back button after 10 seconds to provide a recovery path in case of infinite loading, using this component on non-fullscreen pages could lead to a confusing UI, since those pages either aren’t fullscreen or already have their own navigation options. That’s why the Back Button feature is currently disabled by default.
We should change the component to ActivityIndicator while keeping the current design.
Payment summary: @abzokhattab $250 please request in NewDot and complete the checklist
Click to expand Checklist
# BugZero Checklist:
- [ ] **[Contributor]** The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
- [ ] **[Contributor]** If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in [#expensify-open-source](https://app.slack.com/client/E047TPA624F/C01GTK53T8Q) has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
- [ ] **[Contributor]** If it was decided to create a regression test for the bug, please propose the [regression test](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md) steps using the template below to ensure the same bug will not reach production again.
<details>
<summary>Regression Test Proposal Template</summary>
<!-- AFTER FILLING THIS OUT, be sure to remove the <details> and <summary> tags from this part of the checklist!!!!! -->
- [ ] **[BugZero Assignee]** Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
## Regression Test Proposal
### Precondition:
<!-- List the setup instructions necessary to perform the test -->
-
### Test:
<!-- List the steps that QA should perform -->
1.
Do we agree 👍 or 👎
<!-- AFTER FILLING THIS OUT, be sure to remove the <details> tags!!!!! -->
</details>
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I think regression test is not needed for this issue
Activity
[-]Use correct loading indicators in PDF components[/-][+][$250] Use correct loading indicators in PDF components[/+]melvin-bot commentedon Nov 17, 2025
22 remaining items
melvin-bot commentedon Jan 2, 2026
@Julesssss, @sonialiap, @abzokhattab, @mateuuszzzzz 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Julesssss commentedon Jan 5, 2026
Awaiting payment
melvin-bot commentedon Jan 12, 2026
@Julesssss, @sonialiap, @abzokhattab, @mateuuszzzzz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Julesssss commentedon Jan 13, 2026
Hey @sonialiap, this is ready for payment now: #75031
sonialiap commentedon Jan 13, 2026
Thanks for the ping! Feel free to add the Awaiting Payment label on issues that fail automation
sonialiap commentedon Jan 13, 2026
Payment summary:
@abzokhattab $250 please request in NewDot and complete the checklist
Click to expand Checklist
sonialiap commentedon Jan 16, 2026
I'm going OOO, @Julesssss could you close this issue once the checklist is filled out? Or I'll do it when I'm back :D
Julesssss commentedon Jan 16, 2026
Yes sure, have a great trip!!
abzokhattab commentedon Jan 23, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I think regression test is not needed for this issue
twisterdotcom commentedon Jan 23, 2026
@abzokhattab has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-3a3b-a479-a498-6db186e1c284sonialiap commentedon Feb 2, 2026
Checklist complete, closing out