Skip to content

[Ready for payment 12th Dec][$250] Use correct loading indicators in PDF components #75031

Closed

Description

@mateuuszzzzz

Details

There is a group of PDF components that aren’t necessarily rendered fullscreen, but for loading states they use the FullscreenLoadingIndicator. With our recent changes to FullscreenLoadingIndicator which now renders a back button after 10 seconds to provide a recovery path in case of infinite loading, using this component on non-fullscreen pages could lead to a confusing UI, since those pages either aren’t fullscreen or already have their own navigation options. That’s why the Back Button feature is currently disabled by default.

We should change the component to ActivityIndicator while keeping the current design.

List of components to change:

  • src/components/PDFThumbnail
  • src/components/PDFView

Parent issue: #69850, summary comment

Example of the FullscreenLoadingIndicator component:

Image
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021993085545048897470
  • Upwork Job ID: 1993085545048897470
  • Last Price Increase: 2025-11-24
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @abzokhattab

Activity

  1. self-assigned this
    on Nov 17, 2025
  2. changed the title [-]Use correct loading indicators in PDF components[/-] [+][$250] Use correct loading indicators in PDF components[/+] on Nov 17, 2025
  3. melvin-bot commented on Nov 17, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  4. 22 remaining items

  5. melvin-bot commented on Jan 2, 2026

    @melvin-bot

    @Julesssss, @sonialiap, @abzokhattab, @mateuuszzzzz 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  6. Julesssss commented on Jan 5, 2026

    @Julesssss
    Contributor

    Awaiting payment

  7. melvin-bot commented on Jan 12, 2026

    @melvin-bot

    @Julesssss, @sonialiap, @abzokhattab, @mateuuszzzzz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. Julesssss commented on Jan 13, 2026

    @Julesssss
    Contributor

    Hey @sonialiap, this is ready for payment now: #75031

  9. sonialiap commented on Jan 13, 2026

    @sonialiap
    Contributor

    Thanks for the ping! Feel free to add the Awaiting Payment label on issues that fail automation

  10. sonialiap commented on Jan 13, 2026

    @sonialiap
    Contributor

    Payment summary:
    @abzokhattab $250 please request in NewDot and complete the checklist

    Click to expand Checklist
    # BugZero Checklist:
    
    - [ ] **[Contributor]** The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
    
        Link to comment:
    
    - [ ] **[Contributor]** If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in [#expensify-open-source](https://app.slack.com/client/E047TPA624F/C01GTK53T8Q) has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
    
        Link to discussion:
    
    - [ ] **[Contributor]** If it was decided to create a regression test for the bug, please propose the [regression test](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md) steps using the template below to ensure the same bug will not reach production again.
    
    <details>
    <summary>Regression Test Proposal Template</summary>
    <!-- AFTER FILLING THIS OUT, be sure to remove the <details> and <summary> tags from this part of the checklist!!!!! -->
    
    - [ ] **[BugZero Assignee]** Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
    
        Link to issue:
    
    ## Regression Test Proposal
    ### Precondition:
    <!-- List the setup instructions necessary to perform the test -->
    
    -
    
    ### Test:
    <!-- List the steps that QA should perform -->
    
    1.
    
    Do we agree 👍 or 👎
    
    <!-- AFTER FILLING THIS OUT, be sure to remove the <details> tags!!!!! -->
    </details>
    
  11. sonialiap commented on Jan 16, 2026

    @sonialiap
    Contributor

    I'm going OOO, @Julesssss could you close this issue once the checklist is filled out? Or I'll do it when I'm back :D

  12. Julesssss commented on Jan 16, 2026

    @Julesssss
    Contributor

    Yes sure, have a great trip!!

  13. abzokhattab commented on Jan 23, 2026

    @abzokhattab
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      I think regression test is not needed for this issue

  14. twisterdotcom commented on Jan 23, 2026

    @twisterdotcom
    Contributor

    @abzokhattab has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-3a3b-a479-a498-6db186e1c284
  15. sonialiap commented on Feb 2, 2026

    @sonialiap
    Contributor

    Checklist complete, closing out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions