Skip to content

[Due for payment 2026-01-16] [$250] Expensify card - RHP back button on Success page after deactivating card opens not here page #75178

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.58-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1965/folder/13176890/41237380/1013856009
Email or phone of affected tester (no customers): applausetester+141103kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: User Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • User has assigned themselves a physical card.
  • Private details are filled in on Account > Profile.
  • Date of birth must be older than 18 years old in Private details.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click Add shipping details.
  4. Click Confirm.
  5. Enter magic code.
  6. After Verify button changes from spinner back to Verify, close the RHP.
  7. Go to Account > Wallet.
  8. Click "Expensify Card" card (this is available by default for all Expensifail accounts).
  9. Click Report card loss or damaged.
  10. Select any reason > Next.
  11. Click Deactivate card.
  12. Enter magic code.
  13. After Success page opens, click RHP back button.

Expected Result:

RHP back button on Success page will open card details page.

Actual Result:

RHP back button on Success page after deactivating card opens not here page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7003826_1763123993581.20.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021990787728697448217
  • Upwork Job ID: 1990787728697448217
  • Last Price Increase: 2025-11-18
  • Automatic offers:
    • truph01 | Reviewer | 109554841
    • daledah | Contributor | 109554842
Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 14, 2025
  2. melvin-bot commented on Nov 14, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Nov 14, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    RHP back button on Success page after deactivating card opens not here page.

    What is the root cause of that problem?

    After we deactivate the card success, we are navigating to SETTINGS_WALLET_DOMAIN_CARD again with the old cardID => not found page is shown

    const handleBackButtonPress = () => {
    if (isReasonConfirmed) {
    setIsReasonConfirmed(false);
    return;
    }
    Navigation.goBack(ROUTES.SETTINGS_WALLET_DOMAIN_CARD.getRoute(cardID));
    };

    What changes do you think we should make in order to solve the problem?

    We should navigate to SETTINGS_WALLET_DOMAIN_CARD with newCardID if it exists

        const handleBackButtonPress = () => {
            if (isReasonConfirmed) {
                setIsReasonConfirmed(false);
                return;
            }
    
            Navigation.goBack(ROUTES.SETTINGS_WALLET_DOMAIN_CARD.getRoute(newCardID ?? cardID)); // or we should call navigate with `newCardID`
        };
    

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 18, 2025
  5. melvin-bot commented on Nov 18, 2025

    @melvin-bot
  6. changed the title [-]Expensify card - RHP back button on Success page after deactivating card opens not here page[/-] [+][$250] Expensify card - RHP back button on Success page after deactivating card opens not here page[/+] on Nov 18, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 18, 2025
  8. melvin-bot commented on Nov 18, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

  9. moved this to Bugs and Follow Up Issues in #expensify-bugson Nov 18, 2025
  10. 30 remaining items

  11. melvin-bot commented on Jan 9, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.96-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-16. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 9, 2026

    @melvin-bot

    @truph01 @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. bfitzexpensify commented on Jan 16, 2026

    @bfitzexpensify
    Contributor

    Payment complete to @daledah

    @truph01 please complete the BZ checklist

  14. bfitzexpensify commented on Jan 19, 2026

    @bfitzexpensify
    Contributor
  15. truph01 commented on Jan 19, 2026

    @truph01
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Create an Expensify card in a workspace
    2. Assign a physical card
    3. Go to the Wallet page
    4. Click on the card
    5. Click on the assigned card
    6. Click on the ‘Report physical card loss/damage’
    7. Select any reason > Next.
    8. Click Deactivate card.
    9. Enter magic code.
    10. Verify that: in success page. we have the header back button
    11. Click to the header back button
    12. Verify that: RHP back button on Success page will open card details page.
      Do we agree 👍 or 👎
  16. bfitzexpensify commented on Jan 20, 2026

    @bfitzexpensify
    Contributor

    Payment summary:

    @truph01 due $250 for PR review via NewDot manual request

  17. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Jan 20, 2026
  18. JmillsExpensify commented on Apr 5, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions