Skip to content

[$250] Expense - Unable to merge workspace distance expense with IOU distance expense #75235

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #71675
Email or phone of affected tester (no customers): sdsdjoidnsodjos2@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open 1:1 DM
  3. Create a distance expense
  4. Go to workspace chat
  5. Create a distance expense
  6. Open the expense report
  7. Click More > Merge
  8. Select IOU distance expense > Continue
  9. Select Merchant and Report from the IOU expense
  10. Click Continue
  11. Click Merge expenses
  12. Open workspace chat and 1:1 DM where distance expenses were created

Expected Result:

The distance expenses will be merged successfully

Actual Result:

Workspace distance expense cannot be merged with IOU distance expense
The original distance expenses remain after merging distance expenses

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug7004294_1763153606338.6.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021993765607050190058
  • Upwork Job ID: 1993765607050190058
  • Last Price Increase: 2025-12-24
Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 15, 2025
  2. melvin-bot commented on Nov 15, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mukhrr commented on Nov 16, 2025

    @mukhrr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Unable to merge workspace distance expense with IOU distance expense

    What is the root cause of that problem?

    Here we decide not to merge explicitly IOU transactions

    // Temporary exclude IOU reports from eligible list
    // See: https://github.com/Expensify/App/issues/70329#issuecomment-3277062003
    if (isIOUReport(transaction1.reportID) || isIOUReport(transaction2.reportID)) {
    return false;
    }

    Here is reference for more info why we did it #70329 (comment)

    What changes do you think we should make in order to solve the problem?

    We can exlude distance IOU expenses in this case

        const areBothDistanceRequests = isDistanceRequest(transaction1) && isDistanceRequest(transaction2);
        
        // Temporary exclude IOU reports from eligible list, except for distance requests
        // Distance requests can be merged across IOU and workspace contexts
        // See: https://github.com/Expensify/App/issues/70329#issuecomment-3277062003
        if (!areBothDistanceRequests && (isIOUReport(transaction1.reportID) || isIOUReport(transaction2.reportID))) {
            return false;
        }

    What alternative solutions did you explore? (Optional)

  4. dominictb commented on Nov 19, 2025

    @dominictb
    Contributor

    @hoangzinh I think we should not show the IOU distance expense as an eligible expense.

  5. hoangzinh commented on Nov 21, 2025

    @hoangzinh
    Contributor

    Yes, agreed @dominictb. Btw, is it BE issue?

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 26, 2025
  7. changed the title [-]Expense - Unable to merge workspace distance expense with IOU distance expense[/-] [+][$250] Expense - Unable to merge workspace distance expense with IOU distance expense[/+] on Nov 26, 2025
  8. melvin-bot commented on Nov 26, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 26, 2025
  10. melvin-bot commented on Nov 26, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

  11. 54 remaining items

  12. zanyrenney commented on Feb 6, 2026

    @zanyrenney
    Contributor

    Changing to weekly since we haven't had someone able to pick this up.

  13. zanyrenney commented on Feb 6, 2026

    @zanyrenney
    Contributor

    Also added to high in quality.

  14. zhanglin2603 commented on Feb 12, 2026

    @zhanglin2603

    Generated at: 2026-02-12 10:33 UTC
    Target: [$250] Expense - Unable to merge workspace distance expense with IOU distance expense
    URL: #75235
    Estimated bounty: $250
    Internal score: 39.0

    Draft proposal:
    Bounty Application

    I understand this issue prevents merging a workspace distance expense with an IOU distance expense, leading to duplicate entries instead of a single merged report.

    My delivery plan:

    • Analyze the merge logic for distance expenses across workspace and IOU contexts.
    • Implement fix and test across all supported platforms.

    Please provide acceptance criteria to confirm the fix resolves the merge issue across all platforms.

  15. melvin-bot commented on Feb 12, 2026

    @melvin-bot

    📣 @zhanglin2603! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  16. zhanglin2603 commented on Feb 12, 2026

    @zhanglin2603

    Contributor details
    Your Expensify account email: zhanglin19821012@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01e6a69a37041f29ee

  17. melvin-bot commented on Feb 12, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  18. melvin-bot commented on Mar 5, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @zanyrenney, @Krishna2323 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  19. melvin-bot commented on May 18, 2026

    @melvin-bot

    @zanyrenney, @Krishna2323, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2Not a priority

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions