You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for Payment - Dec 1st] [$250] Reports - App not respond when tap on filter option after delete the saved search #75274
Version Number: v9.2.59-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-1996/folder/13176922/41237510/1016711299 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: iphone 16 pro/18.7.1 App Component: Search
Action Performed:
Open app login with account have some reports
Tap on Reports tab
Tap on "Filters" button
Select any option (can select option with no result)
Tap Save
Tap Save search
Tap on the menu next to search box
Scroll down to Saved section
Tap on three dot of the saved search and delete
Tap on arrow of Type: Expense, Status, Date, From
Expected Result:
App should respond when tap on Type: Expense, Status, Date, From
Actual Result:
App doesn't respond when tap on Type: Expense, Status, Date, From
We already have a logic to call hideModal when the modal is unmounted before calling the onModalHide, but since we don't call willAlertModalBecomeVisible(false) inside hideModal anymore, willAlertModalBecomeVisible value stays true.
What changes do you think we should make in order to solve the problem?
I can't really understand the root cause from the selected proposal of #70209 (comment), but we can add willAlertModalBecomeVisible(false) back to hideModal.
changed the title [-]Reports - App not respond when tap on filter option after delete the saved search[/-][+][$250] Reports - App not respond when tap on filter option after delete the saved search[/+]on Nov 18, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Press on the Reports tab
Press the "Filters" button
Apply any filter and press Save search
Press on the hamburger menu next to the search box
Activity
melvin-bot commentedon Nov 17, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Nov 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Filter popover doesn't show after deleting saved search.
What is the root cause of that problem?
This happens after #71048 which removes the code
willAlertModalBecomeVisible(false)fromhideModaland moves it toonModalWillHide.App/src/components/Modal/BaseModal.tsx
Lines 108 to 115 in 5ddaed5
When we delete the selected saved search, the delete confirm modal is immediately unmounted, leaving no time for the
onModalWillHideto be called.App/src/hooks/useDeleteSavedSearch.tsx
Lines 23 to 32 in 5ddaed5
We already have a logic to call
hideModalwhen the modal is unmounted before calling theonModalHide, but since we don't callwillAlertModalBecomeVisible(false)insidehideModalanymore,willAlertModalBecomeVisiblevalue stays true.App/src/components/Modal/BaseModal.tsx
Lines 148 to 154 in 5ddaed5
App/src/components/Search/FilterDropdowns/DropdownButton.tsx
Lines 62 to 71 in 5ddaed5
What changes do you think we should make in order to solve the problem?
I can't really understand the root cause from the selected proposal of #70209 (comment), but we can add
willAlertModalBecomeVisible(false)back tohideModal.trjExpensify commentedon Nov 18, 2025
I can repro this. 👍
[-]Reports - App not respond when tap on filter option after delete the saved search[/-][+][$250] Reports - App not respond when tap on filter option after delete the saved search[/+]melvin-bot commentedon Nov 18, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021990590934016391139
melvin-bot commentedon Nov 18, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)dukenv0307 commentedon Nov 18, 2025
@bernhardoj Did you test this issue, after bringing back
willAlertModalBecomeVisible?16 remaining items
trjExpensify commentedon Dec 9, 2025
Automation failed. @dukenv0307 checklist time here!
dukenv0307 commentedon Dec 11, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/71048/files#r2609077358
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
dukenv0307 commentedon Dec 11, 2025
@trjExpensify I completed the checklist. Thanks
trjExpensify commentedon Dec 11, 2025
Thanks! Applause caught this in an existing regression test, so I'll forgo a new one.
Payment summary as follows:
Go ahead and request!
bernhardoj commentedon Dec 12, 2025
Requested in ND.
garrettmknight commentedon Dec 18, 2025
$250 approved for @bernhardoj
quinthar commentedon Dec 19, 2025
Approved $250 to @dukenv0307