Skip to content

[Due for payment 2025-12-04] [$250] Upgrade Option Has Incorrect Amount Listed #75340

Closed

Description

@CortneyOfstad

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.2.55-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers): cortney@expensify.com
Issue reported by: @CortneyOfstad
Device used: Web
App Component: Workspace Settings

Action Performed:

  1. Open expense
  2. Click on associated Report
  3. get pop-up message "Upgrade, unlock this feature."

Expected Result:

The text should read $5, not $9 when updating from Free to Collect

Actual Result:

The amount is listed as $9

##Workaround:
Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Videos or Screenshots

Image
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021990498183073560547
  • Upwork Job ID: 1990498183073560547
  • Last Price Increase: 2025-11-17
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. CortneyOfstad commented on Nov 17, 2025

    @CortneyOfstad
    ContributorAuthor

    Originally created under the Expensify/Expensify repo after an SRAM reported the issue. QA was able to recreate here

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 17, 2025
  3. changed the title [-]Upgrade Option Has Incorrect Amount Listed[/-] [+][$250] Upgrade Option Has Incorrect Amount Listed[/+] on Nov 17, 2025
  4. melvin-bot commented on Nov 17, 2025

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 17, 2025
  6. melvin-bot commented on Nov 17, 2025

    @melvin-bot

    Current assignee @CortneyOfstad is eligible for the Bug assigner, not assigning anyone new.

  7. melvin-bot commented on Nov 17, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

  8. ShridharGoel commented on Nov 17, 2025

    @ShridharGoel
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a Free user taps an expense’s associated report, the upgrade modal shows the Collect plan at $9/month instead of the correct $5/month.

    What is the root cause of that problem?

    The upgrade intro view picks the corporate (Control) annual price unless the flow is categorizing or distance-rate related, so the reporting upgrade path falls through to the higher $9 price.

    const formattedPrice = useMemo(() => {
    const upgradeCurrency = Object.hasOwn(CONST.SUBSCRIPTION_PRICES, preferredCurrency) ? preferredCurrency : CONST.PAYMENT_CARD_CURRENCY.USD;
    return `${convertToShortDisplayString(
    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
    CONST.SUBSCRIPTION_PRICES[upgradeCurrency][isCategorizing || isDistanceRateUpgrade ? CONST.POLICY.TYPE.TEAM : CONST.POLICY.TYPE.CORPORATE][CONST.SUBSCRIPTION.TYPE.ANNUAL],
    upgradeCurrency,
    )} `;
    }, [preferredCurrency, isCategorizing, isDistanceRateUpgrade]);

    What changes do you think we should make in order to solve the problem?

    Treat the reporting upgrade path like categorizing/distance upgrades by using the team (Collect) pricing when formatting the upgrade price.

    Updated code snippet:

    const formattedPrice = useMemo(() => {
        const upgradeCurrency = Object.hasOwn(CONST.SUBSCRIPTION_PRICES, preferredCurrency) ? preferredCurrency : CONST.PAYMENT_CARD_CURRENCY.USD;
        const shouldUseTeamPricing = isCategorizing || isDistanceRateUpgrade || isReporting;
        return `${convertToShortDisplayString(
            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
            CONST.SUBSCRIPTION_PRICES[upgradeCurrency][shouldUseTeamPricing ? CONST.POLICY.TYPE.TEAM : CONST.POLICY.TYPE.CORPORATE][CONST.SUBSCRIPTION.TYPE.ANNUAL],
            upgradeCurrency,
        )} `;
    }, [preferredCurrency, isCategorizing, isDistanceRateUpgrade, isReporting]);

    We can check if there are some other scenarios also which should use the Collect pricing.

  9. PiyushChandra17 commented on Nov 17, 2025

    @PiyushChandra17
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-11-17 20:28:19 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Upgrade Option Has Incorrect Amount Listed

    What is the root cause of that problem?

    Subscription Price Update

    What changes do you think we should make in order to solve the problem?

    1. We are setting the amount listed in formattedPrice here

    2. In upgrade into page, we are setting the formattedPrice logic in useMemo block here, the price value comes from CONST.SUBSCRIPTION_PRICES

    3. We need to update the SUBSCRIPTION_PRICES > USD > corporate > yearly2018: 500 here

    [this.SUBSCRIPTION.TYPE.ANNUAL]: 500,

    What alternative solutions did you explore? (Optional)

    n/A

    Result

    Image
  10. dukenv0307 commented on Nov 18, 2025

    @dukenv0307
    Contributor

    @ShridharGoel @PiyushChandra17 Do you guys know how to reproduce?

  11. PiyushChandra17 commented on Nov 18, 2025

    @PiyushChandra17
    Contributor

    @dukenv0307 Yes,

    1. Go to "Workspaces" tab
    2. Go to "Reports"
    3. Toggle "Report field"
  12. 17 remaining items

  13. changed the title [-][$250] Upgrade Option Has Incorrect Amount Listed[/-] [+][Due for payment 2025-12-04] [$250] Upgrade Option Has Incorrect Amount Listed[/+] on Nov 27, 2025
  14. melvin-bot commented on Nov 27, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Nov 27, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ShridharGoel requires payment through NewDot Manual Requests
    • @dukenv0307 requires payment through NewDot Manual Requests
  16. melvin-bot commented on Nov 27, 2025

    @melvin-bot

    @dukenv0307 @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. CortneyOfstad commented on Dec 1, 2025

    @CortneyOfstad
    ContributorAuthor

    @dukenv0307 — can you complete the checklist before the payment date so there is no risk of delay? Thanks!

  18. dukenv0307 commented on Dec 2, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/54340/files#r2581272117

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: New requirement

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Be on a free plan.
    2. Create an expense in a report.
    3. Go the expense details.
    4. Click on the "Report" menu item.
    5. Check the amount shown in the upgrade RHP.

    Do we agree 👍 or 👎

  19. dukenv0307 commented on Dec 2, 2025

    @dukenv0307
    Contributor

    @CortneyOfstad I completed, thank you

  20. CortneyOfstad commented on Dec 4, 2025

    @CortneyOfstad
    ContributorAuthor

    Payment Summary

    @ShridharGoel — to be paid $250 via NewDot
    @dukenv0307 — to be paid $250 via NewDot

    Regression Test

    https://github.com/Expensify/Expensify/issues/574581

  21. twisterdotcom commented on Dec 8, 2025

    @twisterdotcom
    Contributor

    @ShridharGoel has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-c469-aa1f-9c7e-22b950099bb4
  22. quinthar commented on Dec 19, 2025

    @quinthar
    Contributor

    Approved $250 to @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions