You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-05-24] [$1000] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form #7535
With the implementation of our new Form component we need to refactor Picker to be Form compatible. Here are the changes that need to be made:
An optional isFormInput prop.
If isFormInput is true, require a inputID prop. Use getInputIDPropTypes to enforce this propType rule.
Add an optional shouldSaveDraft prop. Defaults to false.
Make the value prop optional.
In the input’s onBlur method, call props.onBlur().
In the input’s onChange method (or equivalent e.g. onTextChange, etc), call props.onChange().
Remove the hasError prop.
Add an optional errorText prop. Defaults to an empty string.
Update the error message to display if errorText is truthy.
Update the inline error display style so it is left aligned with the label and input value. See example image for TextInput:
Make sure that props.ref is attached to the appropriate DOM node. This could involve forwarding the ref to a child component. This is important so we can call ref.focus().
Add the input to the test Form stories and make sure that it works. You can check this by running npm run storybook and testing the component in the example form.
Remove any unused code.
There's an example of a refactor to TextInput in this PR.
changed the title [-][HOLD for payment 2022-05-24] [$250] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form[/-][+][HOLD for payment 2022-05-24] [$1000] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form[/+]on May 18, 2022
Activity
MelvinBot commentedon Feb 2, 2022
Triggered auto assignment to @sonialiap (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Feb 2, 2022
Triggered auto assignment to @laurenreidexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.laurenreidexpensify commentedon Feb 3, 2022
https://www.upwork.com/jobs/~013e89828de19f7536
113 remaining items
LucioChavezFuentes commentedon May 18, 2022
I have a question, I requested a rise on cost to this issue to $1000 and it was accepted . Is it normal to still show $250 on the title?
[-][HOLD for payment 2022-05-24] [$250] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form[/-][+][HOLD for payment 2022-05-24] [$1000] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form[/+]kadiealexander commentedon May 18, 2022
Ah, yes! That title doesn't update automatically. I've updated this to reflect the correct amount.
Santhosh-Sellavel commentedon May 23, 2022
@laurenreidexpensify Can you set up a job on Upwork or send an invite for this issue! Its payment is due tomorrow. Thanks!
laurenreidexpensify commentedon May 24, 2022
@Santhosh-Sellavel sent you a proposal, ignore the per hour bit - I'll issue payment as a bonus as soon as you accept today
laurenreidexpensify commentedon May 24, 2022
@LucioChavezFuentes payment has been issued 👍🏽
Santhosh-Sellavel commentedon May 24, 2022
Accepted the offer, @laurenreidexpensify!
laurenreidexpensify commentedon May 24, 2022
Paid @Santhosh-Sellavel 🙌🏽
parasharrajat commentedon May 24, 2022
@laurenreidexpensify I am eligible for a bonus here #7535 (comment).
laurenreidexpensify commentedon May 25, 2022
Sorry @parasharrajat will sort you out now!
laurenreidexpensify commentedon May 25, 2022
@parasharrajat created a new job here https://www.upwork.com/ab/applicants/1529457532430389248/job-details - I'll issue payment as soon as you're hired
laurenreidexpensify commentedon May 25, 2022
@parasharrajat all done - sorry about that!