Skip to content

[HOLD for payment 2022-05-24] [$1000] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form #7535

Closed

Description

@luacmartins

With the implementation of our new Form component we need to refactor Picker to be Form compatible. Here are the changes that need to be made:

  1. An optional isFormInput prop.
  2. If isFormInput is true, require a inputID prop. Use getInputIDPropTypes to enforce this propType rule.
  3. Add an optional shouldSaveDraft prop. Defaults to false.
  4. Make the value prop optional.
  5. In the input’s onBlur method, call props.onBlur().
  6. In the input’s onChange method (or equivalent e.g. onTextChange, etc), call props.onChange().
  7. Remove the hasError prop.
  8. Add an optional errorText prop. Defaults to an empty string.
  9. Update the error message to display if errorText is truthy.
  10. Update the inline error display style so it is left aligned with the label and input value. See example image for TextInput:
    Screen Shot 2022-02-02 at 10 37 38 AM
  11. Make sure that props.ref is attached to the appropriate DOM node. This could involve forwarding the ref to a child component. This is important so we can call ref.focus().
  12. Add the input to the test Form stories and make sure that it works. You can check this by running npm run storybook and testing the component in the example form.
  13. Remove any unused code.

There's an example of a refactor to TextInput in this PR.

Activity

  1. MelvinBot commented on Feb 2, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Feb 2, 2022
  3. MelvinBot commented on Feb 2, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  4. laurenreidexpensify commented on Feb 3, 2022

    @laurenreidexpensify
    Contributor
  5. 113 remaining items

  6. LucioChavezFuentes commented on May 18, 2022

    @LucioChavezFuentes
    Contributor

    I have a question, I requested a rise on cost to this issue to $1000 and it was accepted . Is it normal to still show $250 on the title?

  7. changed the title [-][HOLD for payment 2022-05-24] [$250] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form[/-] [+][HOLD for payment 2022-05-24] [$1000] [HOLD for payment after regression testing] Refactor Picker to be compatible with Form[/+] on May 18, 2022
  8. kadiealexander commented on May 18, 2022

    @kadiealexander
    Contributor

    Ah, yes! That title doesn't update automatically. I've updated this to reflect the correct amount.

  9. Santhosh-Sellavel commented on May 23, 2022

    @Santhosh-Sellavel
    Collaborator

    @laurenreidexpensify Can you set up a job on Upwork or send an invite for this issue! Its payment is due tomorrow. Thanks!

  10. laurenreidexpensify commented on May 24, 2022

    @laurenreidexpensify
    Contributor

    @Santhosh-Sellavel sent you a proposal, ignore the per hour bit - I'll issue payment as a bonus as soon as you accept today

  11. laurenreidexpensify commented on May 24, 2022

    @laurenreidexpensify
    Contributor

    @LucioChavezFuentes payment has been issued 👍🏽

  12. Santhosh-Sellavel commented on May 24, 2022

    @Santhosh-Sellavel
    Collaborator

    Accepted the offer, @laurenreidexpensify!

  13. laurenreidexpensify commented on May 24, 2022

    @laurenreidexpensify
    Contributor

    Paid @Santhosh-Sellavel 🙌🏽

  14. parasharrajat commented on May 24, 2022

    @parasharrajat
    Member

    @laurenreidexpensify I am eligible for a bonus here #7535 (comment).

  15. laurenreidexpensify commented on May 25, 2022

    @laurenreidexpensify
    Contributor

    Sorry @parasharrajat will sort you out now!

  16. laurenreidexpensify commented on May 25, 2022

    @laurenreidexpensify
    Contributor

    @parasharrajat created a new job here https://www.upwork.com/ab/applicants/1529457532430389248/job-details - I'll issue payment as soon as you're hired

  17. laurenreidexpensify commented on May 25, 2022

    @laurenreidexpensify
    Contributor

    @parasharrajat all done - sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions