You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.2.59-0 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A Email or phone of affected tester (no customers):jsat+todo@applausemail.com Issue reported by: Applause Internal Team Device used: Macbook Pro/iOS 13.7.8 App Component: Money Requests
Action Performed:
Precondition: Location permission DISABLED / Location feature OFF
Login macOS Expensify App with valid credentials
Click on "FAB" button.
Click on "Create expense"
Click on "Scan" option
Choose a file
Choose any recipient
Click on "Create expense"
Click on "Settings" button on location modal
Close native settings without allowing location permission
Expected Result:
After closing native settings without allowing location permission, the "Settings" button should appear enable to click again.
Actual Result:
After closing native settings without allowing location permission, the "Settings" button remains stuck with an infinite loading spinner and cannot be accessed.
Please re-state the problem that we are trying to solve in this issue.
After closing native settings without allowing location permission, the "Settings" button remains stuck with an infinite loading spinner and cannot be accessed.
What is the root cause of that problem?
When the user clicks the Settings button, the app enters a loading state.
However, since the default permission is not granted, the hasError value remains true, and the function returns early — causing the loading state to never be resolved.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@situchan@CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Location permission DISABLED / Location feature OFF
Test:
Click on "FAB" button.
Click on "Create expense"
Click on "Scan" option
Choose a file
Choose any recipient
Click on "Create expense"
Click on "Continue" button on location modal (android only)
Click on "Settings" button on location modal
Close native settings without allowing location permission
Verify that the "Settings" (or "Continue") button appears enabled to click again
(On web, Clicking "Got it" button creates expense immediately)
Activity
melvin-bot commentedon Nov 18, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dmkt9 commentedon Nov 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
After closing native settings without allowing location permission, the "Settings" button remains stuck with an infinite loading spinner and cannot be accessed.
What is the root cause of that problem?
When the user clicks the Settings button, the app enters a loading state.
App/src/components/LocationPermissionModal/index.desktop.tsx
Line 73 in f34c0e3
However, since the default permission is not granted, the
hasErrorvalue remainstrue, and the function returns early — causing the loading state to never be resolved.App/src/components/LocationPermissionModal/index.desktop.tsx
Lines 72 to 79 in f34c0e3
What changes do you think we should make in order to solve the problem?
setIsLoading(true);below theifcheck.App/src/components/LocationPermissionModal/index.desktop.tsx
Lines 72 to 79 in f34c0e3
const handledBlockedPermission = (cb: () => void) => () => { - setIsLoading(true); if (hasError) { window.electron.invoke(ELECTRON_EVENTS.OPEN_LOCATION_SETTING); return; } + setIsLoading(true); cb(); };setHasErrorto automatically switch from Settings to Continue button if the user grants permission.App/src/components/LocationPermissionModal/index.desktop.tsx
Lines 25 to 32 in f34c0e3
const checkPermission = useCallback(() => { getLocationPermission().then((status) => { if (status !== RESULTS.GRANTED && status !== RESULTS.LIMITED) { + setHasError(true); return; } + setHasError(false); onGrant(); }); }, [onGrant]);What alternative solutions did you explore? (Optional)
Clear the loading state when the user returns to the app or when
timeout === CONST.GPS.TIMEOUT.App/src/components/LocationPermissionModal/index.desktop.tsx
Lines 74 to 77 in f34c0e3
if (hasError) { window.electron.invoke(ELECTRON_EVENTS.OPEN_LOCATION_SETTING); + shouldClearLoadingRef.current = true; return; }App/src/components/LocationPermissionModal/index.desktop.tsx
Lines 41 to 43 in f34c0e3
const unsubscribe = Visibility.onVisibilityChange(() => { debouncedCheckPermission(); + if (shouldClearLoadingRef.current && Visibility.isVisible()) { + shouldClearLoadingRef.current = false; + setIsLoading(false); + } });[-]Desktop - Money Requests - Location permission denied leaves Setting button infinite loading[/-][+][$250] Desktop - Money Requests - Location permission denied leaves Setting button infinite loading[/+]melvin-bot commentedon Nov 25, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021993450791123591806
melvin-bot commentedon Nov 25, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (
External)CortneyOfstad commentedon Nov 25, 2025
Hey @ahmedGaber93! There is a proposal above for you to review – thank you!
50 remaining items
CortneyOfstad commentedon Dec 29, 2025
deployed to staging 4 hours ago! 🎉
[-][$250] Desktop - Money Requests - Location permission denied leaves Setting button infinite loading[/-][+][Due for payment 2026-01-06] [$250] Desktop - Money Requests - Location permission denied leaves Setting button infinite loading[/+]melvin-bot commentedon Dec 30, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 30, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-06. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 30, 2025
@situchan @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
CortneyOfstad commentedon Jan 5, 2026
@situchan — please make sure to complete the checklist before tomorrow so there is no delay in issuing payment. Thank you!
situchan commentedon Jan 5, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/57660/changes#r2662518889
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Location permission DISABLED / Location feature OFF
Test:
(On web, Clicking "Got it" button creates expense immediately)
Do we agree 👍 or 👎
CortneyOfstad commentedon Jan 6, 2026
Payment Summary
@situchan — paid $250 via Upwork
@apeyada — paid $250 via Upwork
Regression Test
https://github.com/Expensify/Expensify/issues/584807