Skip to content

[Due for payment 2025-12-31] [$250] Web - Public room - Page freezes when anon user close attachment after press Ctrl K #75498

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.60-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2009/folder/13176964/41237765/1022757317
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Other

Action Performed:

  1. Open https://staging.new.expensify.com/r/2091104345528462 without login
  2. Click on any attachment
  3. Press on CTRL + K
  4. Click on X button for close attachment
  5. Click on any button or attachment of page

Expected Result:

User can login

Actual Result:

Click on an attachment and press CTRL + K, Sign in modal appears but hidden under attachment. Close attachment, sign in modal also disappears and page freezes

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021993335557192555754
  • Upwork Job ID: 1993335557192555754
  • Last Price Increase: 2025-12-02
Issue OwnerCurrent Issue Owner: @yuwenmemon

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 19, 2025
  2. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on Nov 19, 2025

    @bernhardoj
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-12-04 08:39:54 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Page freezes when using search shortcut and then closes the attachment page.

    What is the root cause of that problem?

    When we use the search shortcut as anon user, we will open the sign in RHP, but the attachment page still shows. When we close the attachment page, it dismiss the attachment modal and closes the sign in RHP, but the attachment page is still in the stack.

    () => {
    Session.callFunctionIfActionIsAllowed(() => {
    if (Navigation.isOnboardingFlow()) {
    return;
    }
    toggleSearch();
    })();
    },

    We already close any modal before opening the search router,

    close(
    () => {
    setIsSearchRouterDisplayed(true);
    searchRouterDisplayedRef.current = true;
    },
    false,
    true,
    );

    but this only happens if it passes teh callFunctionIfActionIsAllowed, which doesn't happen in this case.

    What changes do you think we should make in order to solve the problem?

    Use the Modal.close here instead

    () => {
    Session.callFunctionIfActionIsAllowed(() => {
    if (Navigation.isOnboardingFlow()) {
    return;
    }
    toggleSearch();
    })();
    },

    OR

    Move the callFunctionIfActionIsAllowed to here

    close(
    () => {
    setIsSearchRouterDisplayed(true);
    searchRouterDisplayedRef.current = true;
    },
    false,
    true,
    );

    close(
        callFunctionIfActionIsAllowed(() => {
            setIsSearchRouterDisplayed(true);
            searchRouterDisplayedRef.current = true;
        }),
        false,
        true,
    );

    OR

    Use the Modal.close here instead if the user is anonymous because it'll always open a sign-in RHP.

    function callFunctionIfActionIsAllowed<TCallback extends ((...args: any[]) => any) | void>(callback: TCallback, isAnonymousAction = false): TCallback | (() => void) {
    if (isAnonymousUser() && !isAnonymousAction) {
    return () => {
    signOutAndRedirectToSignIn();
    };
    }

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 25, 2025
  5. changed the title [-]Web - Public room - Page freezes when anon user close attachment after press Ctrl K[/-] [+][$250] Web - Public room - Page freezes when anon user close attachment after press Ctrl K[/+] on Nov 25, 2025
  6. melvin-bot commented on Nov 25, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 25, 2025
  8. melvin-bot commented on Nov 25, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  9. 24 remaining items

  10. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.86-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-31. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    @bernhardoj / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. mallenexpensify commented on Dec 31, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @bernhardoj due $250 via NewDot
    Contributor+: @shubham1206agra due $250 via NewDot

    @shubham1206agra plz complete the BZ checklist.

  14. melvin-bot commented on Dec 31, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  15. shubham1206agra commented on Jan 2, 2026

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/49984/changes#r2657620922

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open a public room with image attachment as an anonymous user
    2. Open the image attachment
    3. Press search shortcut (CTRL/CMD + K)
    4. Verify the attachment is closed, and the sign-in RHP is open, and the app is responsive

    Do we agree 👍 or 👎

  16. bernhardoj commented on Jan 2, 2026

    @bernhardoj
    Contributor

    Requested in ND.

  17. garrettmknight commented on Jan 5, 2026

    @garrettmknight
    Contributor

    $250 approved for @bernhardoj

  18. garrettmknight commented on Apr 2, 2026

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions