You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-31] [$250] Web - Public room - Page freezes when anon user close attachment after press Ctrl K #75498
Click on an attachment and press CTRL + K, Sign in modal appears but hidden under attachment. Close attachment, sign in modal also disappears and page freezes
🚨 Edited by proposal-police: This proposal was edited at 2025-12-04 08:39:54 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Page freezes when using search shortcut and then closes the attachment page.
What is the root cause of that problem?
When we use the search shortcut as anon user, we will open the sign in RHP, but the attachment page still shows. When we close the attachment page, it dismiss the attachment modal and closes the sign in RHP, but the attachment page is still in the stack.
changed the title [-]Web - Public room - Page freezes when anon user close attachment after press Ctrl K[/-][+][$250] Web - Public room - Page freezes when anon user close attachment after press Ctrl K[/+]on Nov 25, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.86-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@bernhardoj / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Open a public room with image attachment as an anonymous user
Open the image attachment
Press search shortcut (CTRL/CMD + K)
Verify the attachment is closed, and the sign-in RHP is open, and the app is responsive
Activity
melvin-bot commentedon Nov 19, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Nov 19, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-04 08:39:54 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Page freezes when using search shortcut and then closes the attachment page.
What is the root cause of that problem?
When we use the search shortcut as anon user, we will open the sign in RHP, but the attachment page still shows. When we close the attachment page, it dismiss the attachment modal and closes the sign in RHP, but the attachment page is still in the stack.
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 285 to 292 in 9952437
We already close any modal before opening the search router,
App/src/components/Search/SearchRouter/SearchRouterContext.tsx
Lines 75 to 82 in 9952437
but this only happens if it passes teh
callFunctionIfActionIsAllowed, which doesn't happen in this case.What changes do you think we should make in order to solve the problem?
Use the Modal.close here instead
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 285 to 292 in 9952437
OR
Move the
callFunctionIfActionIsAllowedto hereApp/src/components/Search/SearchRouter/SearchRouterContext.tsx
Lines 75 to 82 in 9952437
OR
Use the Modal.close here instead if the user is anonymous because it'll always open a sign-in RHP.
App/src/libs/actions/Session/index.ts
Lines 425 to 430 in 2b2e960
[-]Web - Public room - Page freezes when anon user close attachment after press Ctrl K[/-][+][$250] Web - Public room - Page freezes when anon user close attachment after press Ctrl K[/+]melvin-bot commentedon Nov 25, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021993335557192555754
melvin-bot commentedon Nov 25, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)24 remaining items
melvin-bot commentedon Dec 24, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 24, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.86-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-31. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 24, 2025
@bernhardoj / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mallenexpensify commentedon Dec 31, 2025
Payment Summary
Contributor: @bernhardoj due $250 via NewDot
Contributor+: @shubham1206agra due $250 via NewDot
@shubham1206agra plz complete the BZ checklist.
melvin-bot commentedon Dec 31, 2025
Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
shubham1206agra commentedon Jan 2, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/49984/changes#r2657620922
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
bernhardoj commentedon Jan 2, 2026
Requested in ND.
garrettmknight commentedon Jan 5, 2026
$250 approved for @bernhardoj
garrettmknight commentedon Apr 2, 2026
$250 approved for @shubham1206agra