Skip to content

[READY FOR PAYMENT 2025-12-04][$250] Use correct loading indicator in MapView component #75534

Closed

Description

@mateuuszzzzz

Details

MapView uses FullscreenLoadingIndicator, but it is not necessarily rendered fullscreen. With our recent changes to FullscreenLoadingIndicator which now renders a back button after 10 seconds to provide a recovery path in case of infinite loading, using this component on non-fullscreen pages could lead to a confusing UI, since those pages either aren’t fullscreen or already have their own navigation options. That’s why the Back Button feature is currently disabled by default.

We should change the component to ActivityIndicator while keeping the current design.

List of components to change:

  • src/components/MapView/MapView.website.tsx

Parent issue: #69850, summary comment

Example of the FullscreenLoadingIndicator component:

Image
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021993085402522459370
  • Upwork Job ID: 1993085402522459370
  • Last Price Increase: 2025-11-24
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. Eskalifer1 commented on Nov 19, 2025

    @Eskalifer1
    Contributor

    If it's open to contributors, I'd like to work on it.

  2. self-assigned this
    on Nov 19, 2025
  3. changed the title [-]Use correct loading indicator in `MapView` component[/-] [+][HOLD] Use correct loading indicator in `MapView` component[/+] on Nov 19, 2025
  4. Julesssss commented on Nov 24, 2025

    @Julesssss
    Contributor

    Hi @Eskalifer1, yes I will assign you now. Let us know if you have any questions!

  5. changed the title [-][HOLD] Use correct loading indicator in `MapView` component[/-] [+][$250] Use correct loading indicator in `MapView` component[/+] on Nov 24, 2025
  6. melvin-bot commented on Nov 24, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed on Nov 24, 2025
  8. melvin-bot commented on Nov 24, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  9. 11 remaining items

  10. Julesssss commented on Nov 25, 2025

    @Julesssss
    Contributor

    PR merged

  11. linhvovan29546 commented on Dec 1, 2025

    @linhvovan29546
    Contributor

    The PR has been deployed to production, the payment due date should be 2025-12-04
    #75946 (comment)

  12. Eskalifer1 commented on Dec 8, 2025

    @Eskalifer1
    Contributor

    Hi everyone! I think something went wrong with the automation here, and this task is ready for payment since 04.12.(Deployed to prod 26.11)

  13. changed the title [-][$250] Use correct loading indicator in `MapView` component[/-] [+][READY FOR PAYMENT 2025-12-04][$250] Use correct loading indicator in `MapView` component[/+] on Dec 8, 2025
  14. Eskalifer1 commented on Dec 16, 2025

    @Eskalifer1
    Contributor

    Hi everyone! Gentle bump on payment here :)

  15. linhvovan29546 commented on Dec 16, 2025

    @linhvovan29546
    Contributor
  16. linhvovan29546 commented on Dec 16, 2025

    @linhvovan29546
    Contributor

    This is improvement so the checklist isn't necessary

  17. mallenexpensify commented on Dec 16, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @Eskalifer1 paid $250 via Upwork
    Contributor+: @linhvovan29546 paid $250 via Upwork

    Can you both please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021993085402522459370

  18. linhvovan29546 commented on Dec 16, 2025

    @linhvovan29546
    Contributor

    Thank you! I've accepted

  19. Eskalifer1 commented on Dec 16, 2025

    @Eskalifer1
    Contributor

    Thank you! Same as above

  20. mallenexpensify commented on Dec 16, 2025

    @mallenexpensify
    Contributor

    @linhvovan29546 and @Eskalifer1 paid, summary updated above, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions