Skip to content

Tighten up search results expectations #7582

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

There are a number of different types of chats and users, and it's not clearly documented anywhere the order in which those should appear when searching for them.

Solution

  1. First, clearly and thoroughly define the results ordering, accounting for:
    1. Exact matches
    2. DM's, group chats, policy default rooms, workspace chats, user-created rooms
    3. How the order might change for the New Chat or New Group pages, and for users that don't yet have Expensify accounts.
  2. Create unit tests to cover all those expected results.
  3. (optional but ideal) Create some kind of benchmarking for search results and test them with an account with many report participants.
  4. Attempt to DRY up and generalize all the OptionsListUtils search logic we have now.
  5. Patch logic as necessary to make tests pass.
  6. Monitor the benchmarks created in step 3 and ensure that we aren't slowing down search by a significant amount. Make it faster if necessary.

View all open jobs on GitHub

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 5, 2022
  2. self-assigned this
    on Feb 5, 2022
  3. roryabraham commented on Feb 5, 2022

    @roryabraham
    ContributorAuthor

    Going to make this internal for step 1 only, then will pass off to contributors.

  4. roryabraham commented on Feb 17, 2022

    @roryabraham
    ContributorAuthor

    No update here

  5. roryabraham commented on Mar 2, 2022

    @roryabraham
    ContributorAuthor

    Was hoping to get to this, but going to have to punt again.

  6. roryabraham commented on Mar 16, 2022

    @roryabraham
    ContributorAuthor

    Have to punt again 😞

  7. 9 remaining items

  8. roryabraham commented on May 6, 2022

    @roryabraham
    ContributorAuthor

    No update again.

  9. roryabraham commented on May 18, 2022

    @roryabraham
    ContributorAuthor

    Going to switch this to monthly until things settle down a bit. Seems pretty valuable, but not urgent.

  10. roryabraham commented on Jun 23, 2022

    @roryabraham
    ContributorAuthor

    No update here

  11. roryabraham commented on Jul 25, 2022

    @roryabraham
    ContributorAuthor

    Going to just close this. Since opening this issue we've seen an increase in unit tests around this flow and also a number of regression tests added to TF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions