You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a number of different types of chats and users, and it's not clearly documented anywhere the order in which those should appear when searching for them.
Solution
First, clearly and thoroughly define the results ordering, accounting for:
Exact matches
DM's, group chats, policy default rooms, workspace chats, user-created rooms
How the order might change for the New Chat or New Group pages, and for users that don't yet have Expensify accounts.
Create unit tests to cover all those expected results.
(optional but ideal) Create some kind of benchmarking for search results and test them with an account with many report participants.
Attempt to DRY up and generalize all the OptionsListUtils search logic we have now.
Patch logic as necessary to make tests pass.
Monitor the benchmarks created in step 3 and ensure that we aren't slowing down search by a significant amount. Make it faster if necessary.
Going to just close this. Since opening this issue we've seen an increase in unit tests around this flow and also a number of regression tests added to TF.
Activity
roryabraham commentedon Feb 5, 2022
Going to make this internal for step 1 only, then will pass off to contributors.
roryabraham commentedon Feb 17, 2022
No update here
roryabraham commentedon Mar 2, 2022
Was hoping to get to this, but going to have to punt again.
roryabraham commentedon Mar 16, 2022
Have to punt again 😞
9 remaining items
roryabraham commentedon May 6, 2022
No update again.
roryabraham commentedon May 18, 2022
Going to switch this to monthly until things settle down a bit. Seems pretty valuable, but not urgent.
roryabraham commentedon Jun 23, 2022
No update here
roryabraham commentedon Jul 25, 2022
Going to just close this. Since opening this issue we've seen an increase in unit tests around this flow and also a number of regression tests added to TF.